Release 5.2.0

Merge pull request #118 from dylancom/issue-117
fix: prevent mediainfo not being available yet in callbacks
2021-07-20 10:50:43 -07:00 · 2021-07-20 10:32:34 -07:00 · 2021-07-20 10:32:16 -07:00 · 2021-07-19 18:40:01 +02:00
2 changed files with 5 additions and 3 deletions
@@ -440,8 +440,9 @@ extension SAPlayer {
        // This prevents a crash where an owning engine already exists.
        presenter.handleClear()
        
-        presenter.handlePlaySavedAudio(withSavedUrl: url)
+        // order here matters, need to set media info before trying to play audio
        self.mediaInfo = mediaInfo
+        presenter.handlePlaySavedAudio(withSavedUrl: url)
    }
    
    /**
@@ -479,8 +480,9 @@ extension SAPlayer {
        // This prevents a crash where an owning engine already exists.
        presenter.handleClear()
        
-        presenter.handlePlayStreamedAudio(withRemoteUrl: url, bitrate: bitrate)
+        // order here matters, need to set media info before trying to play audio
        self.mediaInfo = mediaInfo
+        presenter.handlePlayStreamedAudio(withRemoteUrl: url, bitrate: bitrate)
    }
    
    /**
@@ -8,7 +8,7 @@

 Pod::Spec.new do |s|
  s.name             = 'SwiftAudioPlayer'
-  s.version          = '5.1.0'
+  s.version          = '5.2.0'
  s.summary          = 'SwiftAudioPlayer is a Swift based audio player that can handle streaming from a remote location and audio manipulation.'

 # This description is used to generate tags and improve search results.
Author	SHA1	Message	Date
tanhakabir	0b40a6f0b4	Release 5.2.0	2021-07-20 10:50:43 -07:00
tanhakabir	f9465f54a0	Merge pull request #118 from dylancom/issue-117 fix: prevent mediainfo not being available yet in callbacks	2021-07-20 10:32:34 -07:00
tanhakabir	8ce28db471	Add documentation for important order	2021-07-20 10:32:16 -07:00
Dylan Companjen	a84f834f45	fix: prevent mediainfo not being available yet in callbacks	2021-07-19 18:40:01 +02:00