There are 2 problems with the way combat music interacts with the menu (and the
credits you can view from there):
* When the menu is closed, the combat music becomes the "last request", so it
never stops even if combat finishes.
* If the creidts are viewed, the requested credits music is ignored because
combat is active, and the music player is checking the actor's status to
decide whether to change tracks.
This fixes both those problems, and restores the original game behavior of just
turning off the music when the menu is opened. I also removed the coupling of
actor state from the music process. I think this now works properly in all
situations.
Cause was deleting _shapes without _shapes being initialized to nullptr
Error occured when Bladerunner engine exited early due to missing data files. In this case the _shapes is not yet initialized, yet its deletion was calling the Shapes destruction and the array clear function leading to a segmentaiton fault. To reproduce just remove or rename one of the required files for BladeRunner and run the game (the error might not be triggered the first time).
On macOS Catalina, the application needs to ask for permissions to
access some folders, such as the Desktop, Downloads, and Documents
folder. It for example asks for permission when listing files in
one of those folders or trying to read a file that was created by
another application and not selected using the system Open panel.
Since the default savegame path on macOS is in the Documents
folder it will ask for permissions to access this folder when we
open the Load Game dialog or try to load a savegame that was
copied there manually). So, while not required, it seems a good
idea to provide an explanation why ScummVM wants access to the
Documents folder.
macOS 10.14 introduced a dark theme in addition to the nornal
aqua theme. Applications compiled with the 10.14 SDK or above
are automatically opt in for both, but applications compiled
with an older SDK are not and still use the aqua theme even
when the system is set to use the dark theme. Those applications
need to explicitely opt in to use the dark theme.
This fixes bug #11305: Dark Mode is not supported
This resolves confusion with Texture originally using a uint32 * buffer,
but then force casting to an uint16 * when in 16bpp pixel mode and
TEX_FMT_NATIVE is being used. Now using a surface, it's more able to
manage it's own buffer, and there'll be less confusion about how the
data is contained
The minimap appears incorrectly for 2 reasons:
* The memset_32 implementation is buggy - it uses a logical or instead
of a binary or, and it fails to move the buffer pointer after doing
the aligned section. This becomes more obvious in 16bpp mode.
* The top line is not long enough
This corrects both issues.
The 'Too few args' message should only be
displayed if some but not enough arguments
are provided. Otherwise just show the
instructions of the command.
Fixes#1464.
Paul Gilbert
Matthew Duggan
Dries Harnie
Eric Fry
rsn8887
Thanasis Antoniou
IlDucci
Zvika Haramaty
Filippos Karapetis
Thierry Crozat
Anubhab Ghosh
Roland van Laar
GunnarBirke
lolbot-iichan