Our derivate work remains GPLv3+, since the original allowed it thanks
to its GPLv2+ license, but when we quote the original license we can't
(and shouldn't) change the fact that it was GPLv2+.
Found while doing a review of our existing workarounds for those
versions, and the system features which can be used there.
Also fix indentation and some typos while there.
We now hide the mini map gump instead of closing to keep surface it draws infrom being discarded. The surface will be drawn on run instead of paint so it can continue updating even while the gump is hidden. This does not yet persist the mini map when saving or on map change.
This fixes an issue in which saving a game in a situation in which the camera
is frozen (i.e. having the inventory open) and then reloading it, doesn't keep the
camera state, leading to slight graphical glitches. The original interpreter saves this
parameter, so we better do that too.
Restores correct adjustments for vector patterns that extend past the
left or top picture edges. This was accidentally altered to occur
after the port adjustment in: 44b6050915
Fixes bug #13914 where the top of PQ2 room 1 was drawn out of bounds.
In the French VGA floppy release of Monkey Island 1 (and, apparently,
this release alone), the easter egg making fun of Sierra games has a
dark blue background that makes the black text really hard to read (very
much like the MI1 v5 issue in front of the Governor's mansion, which we
already fix). The problem is in the OI itself, which was redrawn to
feature a translated text.
This problem doesn't exist in the other French releases (including the
Amiga VGA one), and the non-French VGA floppy releases look fine, to me.
So, just force a white background instead of dark blue, for this object
and on this particular release only.
(Note: they also messed up the top and left borders of that object, and
so a small black horizontal line will suddenly appear when the "Guybrush
falling into the trees" animation starts. Unfortunately, this is a
horizontal line, while strips are drawn as a series of vertical lines,
so it's hard to only fix this line, especially since its black color is
reused in the same strip for Guybrush trousers... So, this enhancement
just concentrates on solving the main issue, which is the legibility
problem with the blue background.)
In this workaround, the Lemonhead lines that we restore went missing
with the v5 releases of MI1. But for whatever reason, those lines were
already missing from all the French MI1 v4 releases that I'm aware of.
So there's no official content to add back for this language, sorry!
Checked against my French floppy EGA, floppy VGA and v5 CD versions.
French Amiga and Atari releases checked on YouTube.
This thing went unnoticed for a while. It was brought to my attention by members of
the speedrunning community, since it caused dropped inputs during runs.