Commit Graph
4703 Commits
Author SHA1 Message Date
Torbjörn Andersson eb51135a6f GUI: Only show render mode options explicitly supported by the game
The render mode options are confusing, since they're just silently
ignored by games that don't support them. This way, games have to
explicitly declare which render options they support.
2022-11-07 00:27:34 +02:00
athrxx a84336c583 COMMON: more flexible gui options handling
This allows the meta engines to post process the gui options,
before they get to be used in the GUI. This allows adding or
removing options on a larger scale without having to modify
each detection entry individually. In this case, it is meant to be
used in the SCUMM engine, to allow adding render mode
gui options wothout modifying the tables.
2022-11-07 00:27:34 +02:00
Vladimir Serbinenko f9d0da86e3 GUI: Fix browsing in presence of files with \1 in names
Currently file containing \1 in its name causes erroring out
with "Wrong string format".

Hades Challenge Mac partiton has such files in the root. So if they are
copied then it's impossible to select folder with Hades Challenge. Many tools
skip (as they are hidden) or rename them while saving original name in
AppleDouble or MacBinary. dumper-companion also renames them but scummvm
transparently decodes punycode back.
2022-11-06 23:22:40 +01:00
Le Philousophe c6451a2ec9 GUI: Fix top dialog only drawing
Before that the parent was also drawn.
2022-11-06 20:02:59 +01:00
Le Philousophe c73fac1cda GUI: Fix strncpy usage 2022-11-06 17:27:21 +01:00
Orgad Shaneh aba347ed9e GUI: Make character validation less ugly 2022-11-02 22:15:16 +00:00
Eugene Sandulenko 9522773ca8 GUI: Do not run shader test when shader is cleared 2022-10-30 23:07:35 +01:00
Le Philousophe b8d56cd168 GUI: Remove visible check in theme
This slows down this time critical function and the value can never be
set anyway.
2022-10-30 12:33:53 +01:00
Hubert Maier 25bc55d83f GUI: Correct spelling mistake
loose -> lose
2022-10-27 15:56:06 +02:00
macca8 572b3a5f4a ENGINES: Properly identify the autosave file
Restructure isAutosave() function:
- Prioritize name test
- Access saveType test only if name test fails
Performs both tests when required, resolving false positives unique to each test, and ensures that only saves which fail both tests appear in autosave warning dialogs.

Properly fixes [https://bugs.scummvm.org/ticket/12363 #12363], refer [https://bugs.scummvm.org/ticket/13842 #13842]
2022-10-25 02:37:01 +03:00
Le Philousophe d8a4c106dd GUI: Don't use unsafe strcat and strcpy 2022-10-23 22:46:19 +02:00
Eugene Sandulenko dedeb489f2 GUI: And even more properly fix the shader override 2022-10-23 15:43:22 +02:00
Eugene Sandulenko 7b3c68480a GUI: Properly remove shader settings when GUI override is unchecked 2022-10-23 15:31:56 +02:00
Eugene Sandulenko 026479d30a GUI: Allow game gfx override to specify no shader. 2022-10-22 18:16:30 +02:00
Eugene Sandulenko 118d310b51 GUI: Fix Shader controls for Game Options 2022-10-22 18:16:30 +02:00
Lothar Serra Mari 6e82d770d5 GUI: Update translations datafile 2022-10-10 13:59:56 +02:00
Eugene Sandulenko 3d115750b3 GUI: Fix type 2022-10-10 13:29:23 +02:00
Eugene Sandulenko 8a75067db5 GUI: Fix behaviour when switching OpenGL -> SDL Surface 2022-10-10 00:15:00 +02:00
Eugene Sandulenko 17841ca8a2 GUI: Fix crash on switch SDL Surface -> OpenGL 2022-10-10 00:15:00 +02:00
Eugene Sandulenko 8c8b06e908 GRAPHICS: Move PM5544 test pattern drawing to a separate file 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 3e7ec681d1 GUI: Do not show empty hole in Graphics tab when Filtering is not supported by the backend 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 4237575f65 GUI: Fix crash when shaders are not supported 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 8d65ac4364 GUI: Regenerate theme files 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 57cd169a17 GUI: Allow both scalers and shaders to be enabled at the same time 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 4e4c149264 GUI: Bump theme version to 0.9.6 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 0351b86d64 GUI: Sync classic layout with shader controls 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 80f79f253d GUI: Make shaders/scalers work mutually exclusive 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 2fc93e58bd GUI: Fix scaler toggle behavior in game options 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 3aef14fa99 GUI: Initial code for making game options work with shader controls 2022-10-08 23:39:18 +02:00
Eugene Sandulenko ee9ede6681 GUI: Persist shader/scaler radiobutton state 2022-10-08 23:39:18 +02:00
Eugene Sandulenko ff00d3feea GUI: Move shader controls to Graphics tab and hide behind radiobutton 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 76dc20b4b5 GUI: Fix shader clear button behaviour 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 2c9731b16a GUI: Do not run test when there is no shader 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 0614eab5de GUI: Switch test pattern to 320z240 and improve dialog message 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 08706d3c0f GUI: Better wording for the schader test dialog. Courtesy of Thunderforge 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 3b1a1f0411 GUI: Formatting fixes, added copyright of the original work for test screen 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 2fd53a9bae JANITORIAL: Whitespace fixes 2022-10-08 23:39:18 +02:00
Eugene Sandulenko d9bebc379a GUI: Fixes to the test screen drawing 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 5b307826db GUI: More work on shader test screen 2022-10-08 23:39:18 +02:00
Eugene Sandulenko e11bd0f2f2 GUI: Initial code for test screen drawing 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 7cd63b418a GUI: Do not apply shadow on single dialog draw 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 655fea0de0 GUI: Draw only confirmation dialog on shader change 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 7df3792ae3 GUI: Implement drawing mode of top dialog only 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 26e5ef35ab GUI: Use countdown dialog on shader test 2022-10-08 23:39:18 +02:00
Eugene Sandulenko a8ba66c95e GUI: Implement CountdownMessageDialog 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 3dada376b1 GUI: Show test dialog when shader was changed 2022-10-08 23:39:18 +02:00
Eugene Sandulenko ff259665c5 GUI: Restore previous shader setting on load failure 2022-10-08 23:39:18 +02:00
Eugene Sandulenko 51295e3a6a JANITORIAL: Whitespace fixes 2022-10-08 23:39:18 +02:00
Cameron Cawley 79fff69231 COMMON: Use Common::String for OSystem::setShader 2022-10-08 23:39:18 +02:00
Cameron Cawley 64c359b5cb GUI: Replace the options for selecting shaders 2022-10-08 23:39:18 +02:00