Commit Graph
53 Commits
Author SHA1 Message Date
Max Horn 9fcd50650c Removing this old workaround: It no longer works, and causes an infinite loop. Am working on a new workaround/fix
svn-id: r26104
2007-03-12 13:28:01 +00:00
Max Horn b3a14c6357 Fix a discrepancy between our V3 walking code and disasm (besides, using destbox instead of curbox was illogical, too)
svn-id: r26102
2007-03-12 12:16:41 +00:00
Max Horn f47670f5a3 Get rid of initActorClass
svn-id: r26101
2007-03-12 12:11:59 +00:00
Max Horn b07482b0b2 A long time ago, in a virtual machine far, far away...
It is a period of bug fixing. Rebel
developers, coding from a public
project, have won their umpteenth victory
against the evil Actor Walk Bugs.
 
During the debugging, programmers 
used secret plans to the LucasArts'
ultimate tool, the SCUMM engine, an
extensible scripting system with enough
power to create an entire adventure.

Pursued by ensuing sinister regressions,
High King Fingolfin gleefully jumps up
and down, making use of the hotkey
that can save his games and restore
them back again later....

[With apologies to George Lucas. Good
riddance to bugs #751662, #771483, #959001,
#1329457, #1329498, #1329529, #1527672,
#1538260, #1571701, #1571705, #1571740,
and a warm welcome to the regressions
this change will cause. :-) ]

svn-id: r26090
2007-03-11 15:23:50 +00:00
Max Horn f3e970f5b7 SCUMM: Renamed ActorOldWalk to Actor_v3, added new subclass Actor_v2
svn-id: r26057
2007-03-10 13:53:11 +00:00
Travis Howell a0d5795ee1 Add support for the New Kid verb option in Apple II and Commodore 64 verisons of Maniac Mansion.
svn-id: r25999
2007-03-06 07:09:18 +00:00
Travis Howell 19d2310b71 Add support for using disks images for Apple II version of Maniac Mansion.
svn-id: r25846
2007-02-25 07:23:52 +00:00
Max Horn e9f9792f2d Fix for bug #1660560 (MANIAC: Meteor faces wrong way during intro)
svn-id: r25705
2007-02-18 21:07:00 +00:00
Max Horn dc5ef8425b Introduced V12_X_SHIFT / V12_Y_SHIFT
svn-id: r25611
2007-02-15 18:12:29 +00:00
Max Horn be052be462 Rewrote the actor walk code for SCUMM V0-V2 games: Now it uses the C64 character coordinates internally, not pixel coordinates. This should fix some walk bugs, but also might cause some regressions. Watch out
svn-id: r25370
2007-02-04 01:24:43 +00:00
Max Horn 5395c4a2f4 Removed _actorPos locat vars, and instead use _pos directly
svn-id: r25344
2007-02-03 01:21:49 +00:00
Max Horn 27432a4dc1 Moved some stuff from CharsetRenderer (back) to ScummEngine, added comments
svn-id: r25250
2007-01-28 20:11:31 +00:00
Gregory Montoir cd79d127fa Since Actor::initActor is now virtual, it shouldn't be called directly from the base constructor (ActorC64::initActor won't get called as vtable hasn't yet been setup).
svn-id: r25015
2007-01-05 23:33:13 +00:00
Max Horn ae4ea4d989 Introduced ActorOldWalk subclass of Actor (for V1-V3 walk code)
svn-id: r24924
2006-12-25 17:21:54 +00:00
Max Horn ba991e3b3a SCUMM: Added ActorC64 subclass of Actor, and added a note stating that _miscflags isn't currently stored (possibly breaking C64 save states). Also reordered some HE specific code
svn-id: r24923
2006-12-25 15:37:20 +00:00
Max Horn 4ce7b74085 Changed ScummEngine::_actors from an Actor array to a an array of Actor points (i.e. indirection)
svn-id: r24922
2006-12-25 15:03:36 +00:00
Gregory Montoir cfd4ffb321 fixed bug #1620023 (script calls putActorAtXY with y == -1)
svn-id: r24910
2006-12-21 15:09:13 +00:00
Max Horn c210aff40c * Made Actor::_pos protected, added public Actor::getPos() method
* Added default params to Actor::putActor()
* Removed Actor::getActorXYPos

svn-id: r24742
2006-11-19 00:39:48 +00:00
Max Horn 41b4a34b5b cleanup
svn-id: r24565
2006-10-29 13:30:20 +00:00
Max Horn a0b9f78bd3 SCUMM: Introduced V12_X_MULTIPLIER and V12_Y_MULTIPLIER to make it a bit easier to find spots where we convert between C64-style coordinates and pixel coordinates (but beware, this probably doesnt't cover all relevant instances)
svn-id: r24384
2006-10-19 00:26:55 +00:00
Max Horn 92adf6a65c SCUMM: reordered contents of actor.cpp, grouping methods in a hopefully somewhat more logical fashion
svn-id: r24367
2006-10-18 14:01:28 +00:00
Max Horn dd7e4ff3e7 SCUMM: walbox related cleanup
svn-id: r24365
2006-10-18 13:33:42 +00:00
Max Horn d02e4d7f7c Removed CHECK_HEAP
svn-id: r23979
2006-09-23 11:29:32 +00:00
Max Horn 285aa5d0b2 renamed ScummEngine::restoreBG to restoreBackground; renamed and moved Gdi::copyVirtScreenBuffers to ScummEngine_v70he::restoreBackgroundHE
svn-id: r23925
2006-09-17 23:35:09 +00:00
Max Horn 8c0b0c0120 Changed ScummEngine::gdi to _gdi and allocate the Gdi object on the heap (i.e. _gdi is a pointer now)
svn-id: r23921
2006-09-17 20:22:47 +00:00
Max Horn b860f002b2 Replaced checkRange by assertRange, which has (a) an (IMO) more logical order of parameters, and (b) removes lots of useless duplicate information in error messages
svn-id: r23885
2006-09-16 13:38:43 +00:00
Max Horn 6162626323 cleanup; remove check whether _costume is valid, as that is already done by getResourceAddress
svn-id: r23884
2006-09-16 12:43:18 +00:00
Travis Howell 100b809836 Fix bug #1527630 - ZAK FM-TOWNS: Actor (Caponian) picks wrong line
svn-id: r23586
2006-07-24 10:52:14 +00:00
Travis Howell e87c31d35d Remove out dated comment
svn-id: r23483
2006-07-11 04:43:14 +00:00
Travis Howell 242edd0e39 Restrict recent walk code changes to to exact SCUMM versions required, to prevent regressions in earlier games
svn-id: r23476
2006-07-10 11:45:40 +00:00
Travis Howell 76e67fba92 Fix actor glitches in the stomach location of pajama3
svn-id: r23471
2006-07-10 10:14:10 +00:00
Max Horn eaff9344a4 Added OSystem::setFocusRectangle (first part of Nintendo DS patch)
svn-id: r23449
2006-07-09 09:40:44 +00:00
Travis Howell 6a53fa4cc3 Revert recent change to actorWalkStep(), caused regressions
svn-id: r23393
2006-07-07 12:47:44 +00:00
Travis Howell 3f4cc015b2 Fix bug #1518523 - FOA: Indy facing the wrong direction in intro. And adjust walk code to closer match original code of earlier games
svn-id: r23381
2006-07-07 07:31:13 +00:00
Travis Howell 4bbdf9daae Fix 1506002 - PUTTTIME: Weird Mouth Movement
svn-id: r23374
2006-07-06 11:17:14 +00:00
Travis Howell 4b26f8319e Add cyx's patch for bug #1508935 - FOA: Indy walks on the spot. Also fixes car failing to turn during smart star challenge in thinker1
svn-id: r23271
2006-06-24 01:46:54 +00:00
Travis Howell bc3e089842 Fix the buttons of paintings and safe in Nogroom of spyfox
svn-id: r23156
2006-06-17 06:27:44 +00:00
Travis Howell a0d14a0832 Fix Commodore 64 versions
svn-id: r22732
2006-05-29 12:45:11 +00:00
Max Horn aeef84c961 Moved AKOS stuff to class ScummEngine_v6
svn-id: r22229
2006-04-29 16:51:29 +00:00
Max Horn c4df5037dc * Renamed several methods in favor of a somewhat more uniform naming scheme: setupFOO for stuff that inits static data (i.e. will be called only once, or after loading savegames), vs. resetFOO / updateFOO methods which are called frequently and (re)set dynamic data.
* Doing this, split scummInit into setupScumm and resetScumm methods
* Moved some init code to new methods (huuuuge init methods are hard to read, and hard to customize using subclassing)
* Renmaed various setup???Palette methods to set???Palette
* Some minor cleanup / tweaks

svn-id: r22227
2006-04-29 16:24:39 +00:00
Max Horn d68f95b3be Move HE specific stuff from class Sound to its new subclass SoundHE
svn-id: r22115
2006-04-23 18:52:39 +00:00
Travis Howell 4f10a71b98 An actor is completely reset by showActor() in SCUMM1-2 games. Fixes bug #902391
svn-id: r21283
2006-03-14 13:16:11 +00:00
Travis Howell 259e3cf301 Adjust talk sound check in CHARSET_1(), since processSfxQueues() doesn't exist in HE games. Fixes glitch when time machine is used in putttime.
svn-id: r21195
2006-03-10 06:05:49 +00:00
Travis Howell 64ce4d6dd7 C64 maniac uses separate bitmasks for actor settings and misc settings
svn-id: r21004
2006-03-02 06:06:24 +00:00
Max Horn 6914121f61 Replaced MKID by MID_BE in most places in the SCUMM engine
svn-id: r20862
2006-02-25 02:12:58 +00:00
Max Horn e389bcf497 Replaced _gameId, _version, _heversion, _features, _midi, _platform with a simple ScummGameSettings instance: _game
svn-id: r20795
2006-02-20 16:51:30 +00:00
Eugene Sandulenko 10c7835cfc Moved all he-specific source files to engines/scumm/he/ subdirectory
svn-id: r20696
2006-02-15 00:57:50 +00:00
Travis Howell b796860ee8 Add extra costume tables (Used by HE games) to saved game. Fixes weird actor states when restoring saved game, in HE games.
svn-id: r20689
2006-02-14 10:11:15 +00:00
Travis Howell b9fec00c25 Only adjusted in SCUMM 5+
svn-id: r20598
2006-02-12 11:03:16 +00:00
Travis Howell 2873ae8186 Actually that should be before all code
svn-id: r20595
2006-02-12 07:03:04 +00:00