ScummVM/scummvm
1
0
Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
61,292 Commits 45 Branches 139 Tags
7331a7cbefed7be415da170a32a2549b1c18fd12
Commit Graph
69 Commits
Author SHA1 Message Date
Filippos Karapetis d530985a6b SCI: Avoid using g_sci for usesOldGfxFunctions() in the GfxPorts class 2013-06-21 13:19:37 +03:00
Willem Jan Palenstijn 0250fd8ee1 SCI: Fix hunk entry leak 2013-04-15 21:46:09 +02:00
Filippos Karapetis a73e3f44ad SCI: Add a workaround for the large text boxes in Freddy Pharkas CD 
Fixes bug #3575276 - "SCI: Freddy Pharkas: Text sometimes drawn/erased
incorrectly"
 2012-10-08 22:47:27 +03:00
Max Horn 88913c0139 ALL: Remove trailing whitespaces 
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
  git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
 2011-06-20 00:59:48 +02:00
strangerke 69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
md5 89f9c5a9c3 SCI: Moved the engine hunk pointer processing code inside the GfxPorts class 
This allows us make _windowList private again
 2011-03-20 15:29:12 +02:00
md5 4df049f4d7 SCI: Added a new console command "window_list" or "wl" 
This can be used to see a list of the currently open windows. Also, added
a sanity check for the "al" command and performed some minor cleanup
 2011-03-20 14:56:13 +02:00
md5 fd2c39591f SCI: Fixed the flashing icon bar in the Mac version of Castle of Dr. Brain 
Thanks to waltervn for his work and help on this
 2011-03-13 23:34:08 +02:00
Willem Jan Palenstijn 3f05221334 SCI: Always add new windows to back of list up to SCI_1_EGA_ONLY. 
Confirmed this behaviour in KQ1sci, KQ4, Iceman and QfG2.
Hoyle3-demo remains an exception.
 2011-03-02 23:48:57 +01:00
Willem Jan Palenstijn 1ef1f3e671 SCI: Call Graph(RedrawBox) from EndUpdate for SCI0/01 
Confirmed this behaviour in KQ1sci, KQ4, Iceman, and that
it isn't present in QfG2 and KQ5CD.

This fixes the graphics glitch in KQ4 when falling down the
stairs in room 61 (#3039775).
 2011-03-02 23:48:57 +01:00
Willem Jan Palenstijn 5972a6bbe9 SCI: Fix variable name 2011-03-02 08:37:22 +01:00
Willem Jan Palenstijn bc48b124f0 SCI: Change workaround for hoyle3-demo's rendering order 
This behaviour much more closely matches SSCI.
 2011-03-02 00:48:21 +01:00
Willem Jan Palenstijn db536da8d3 SCI: Skip Ports when iterating over Windows in GC 2011-02-28 21:37:12 +01:00
Willem Jan Palenstijn d17a889400 SCI: Fix negative window origin alignment. 
SSCI does a shr 1; shl 1 here in SetOrigin.
This fixes a crash in the ending scene of SQ3 (#3194199).
 2011-02-27 18:17:22 +01:00
Matthew Hoops 7b5792d6d2 SCI: Fix window height for some Mac SCI1/1.1 games 
Some games have removed the menu bar from the screen. This also fixes King's Quest V's icon bar.
 2011-02-18 15:58:23 -05:00
Filippos Karapetis cf94a99bb7 SCI: Changed the bShow parameter of GfxText16:Box() into a bool 
svn-id: r55179
 2011-01-09 00:32:26 +00:00
Filippos Karapetis 26dfb6affa SCI: Fixed bug #3041153 - "SCI Fanmade Games: Message window glitch" 
The left window dimension adjustment (rev #48772) has been moved from
GfxPorts::setOrigin() into GfxPorts::addWindow(), as the updated dimension is
later used when filling the contents of the window (apparent in some fan made
games)

svn-id: r54976
 2010-12-20 15:30:31 +00:00
Martin Kiewitz eefa151d70 SCI: saving/restoring script created windows now 
fixes "GfxPorts::kernelSetActive" error
based on code by [md5]

svn-id: r54012
 2010-11-01 16:09:33 +00:00
Torbjörn Andersson c91a07229a JANITORIAL: Removed most punctuation at end of warning() and error() 
Our warning() and error() functions always add an exclamation mark
to the end of the message anyway.

svn-id: r52791
 2010-09-18 10:55:16 +00:00
Martin Kiewitz 7b8add291e SCI: multiple changes for mother goose vga 
which is sci1 and sci1.1
fixes bug #3051145
- separating this mother goose from ega and sci2.1
- adding workaround when restoring saved games in these games, games try to calculate restored savedgameid instead of looking it up, we patch this code out and also set the global to the current savedgameid
- adding workaround for scripts checking savedgameid to be below 13 (our savedgameids begin at 100 now)
- changing official range for savedgameids from 1000->1999 to 100->199, otherwise mother goose would have required much larger patches and this range should be fine even if we replace savedgame dialogs later

svn-id: r52301
 2010-08-23 16:33:19 +00:00
Filippos Karapetis dd1708a1f1 Reverting r52224, as it was incorrect - fanmade games use the same interpreter as normal ones, so this doesn't make sense. Added a FIXME with a description about the graphics glitch in fanmade games 
svn-id: r52225
 2010-08-20 15:17:19 +00:00
Filippos Karapetis 273a9eb036 SCI: Fixed bug #3041153 - "SCI Fanmade Games: Message window glitch" 
svn-id: r52224
 2010-08-20 12:24:48 +00:00
Martin Kiewitz f8697e20b5 SCI: now reusing window ids on kNewWindow 
sq4cd recreates the inventory window several times, but also reuses old window ids, causing kernelSetActive errors. fixes bug #3044757

svn-id: r52079
 2010-08-14 08:03:32 +00:00
Martin Kiewitz 512bf22af6 SCI: adding workaround for camelot during ending 
fixes bug #3044734
also fixing heap corruption during the ending

svn-id: r52077
 2010-08-14 06:05:54 +00:00
Martin Kiewitz 6181241f57 SCI: extending life of port for sq4 gum wrapper 
fixes bug #3044507

svn-id: r52068
 2010-08-13 18:25:16 +00:00
Martin Kiewitz a06dcea2e5 SCI: kDisposeWindow changes 
kDisposeWindow doesn't free windows immediately anymore. We free them after some calls to kSetPort, so the handle will be valid for a short time. Fixes sq4cd and hoyle 4 (commented out patching of script for hoyle 4)

svn-id: r51932
 2010-08-08 18:26:40 +00:00
Martin Kiewitz 753c431937 SCI: adding script patching 
including a patch for hoyle 4 and commenting out the workaround code inside kDisposeWindow

svn-id: r51795
 2010-08-06 18:54:58 +00:00
Martin Kiewitz c71f1f1612 SCI: actually enable hoyle 4 workaround 
and adding additional comment

svn-id: r51754
 2010-08-05 07:54:33 +00:00
Martin Kiewitz 1b69257654 SCI: changing hoyle 4 workaround 
fixing hoyle 4 detection entry (not a demo)
adding direct selector fix, maybe we should replace this later with a script patch
adding detailed comment about the issue

svn-id: r51753
 2010-08-05 07:49:19 +00:00
Filippos Karapetis 624107319e SCI: Fixed an off-by-one error in GfxPorts::getPortById() and moved the error checking code outside the function. Also fixed script bug #3039305 - "HOYLE4: segfault" 
svn-id: r51733
 2010-08-04 12:41:00 +00:00
Martin Kiewitz 2e11c1cf96 SCI: reset ports when restoring 
fixes qfg3/fairy tales restoring (bug #3035626)
also fixes ScummVM menu restoring while a window is shown (e.g. sq5)

svn-id: r51712
 2010-08-03 19:43:16 +00:00
Martin Kiewitz 512fec56c7 SCI: adding offTop = 0 for mother goose sci1.1 
fixes graphics in that game

svn-id: r51643
 2010-08-02 18:04:23 +00:00
Martin Kiewitz 97b1cd34cf SCI: sci1.1 priority bands now changing in kDrawPic 
fixes qfg3: right guard on top of the palace having wrong priority
fixes sq5 and all sorts of sci1.1 games: when loading wrong priority for some actors that fixed itself after one frame

svn-id: r51397
 2010-07-27 23:20:43 +00:00
Filippos Karapetis 9da4c3f883 SCI: Some cosmetic changes to the warning thrown when fixing invalid windows 
svn-id: r51306
 2010-07-26 09:18:04 +00:00
Martin Kiewitz 32c81fa918 SCI: fixing kNewWindow (SCI1.1) 
check differently for null restoreRect, fixes pq3 some windows not getting fully removed
calling showBits on actual dims and not on restoreRect, fixes lb2 about window issues (and possible qfg1vga window issues as well)

svn-id: r51204
 2010-07-23 12:37:58 +00:00
Martin Kiewitz e857cc623e SCI: added comment - lsl5 also has too large windows 
svn-id: r50450
 2010-06-28 16:35:20 +00:00
Filippos Karapetis e6a9a9da82 Silenced a false positive in MSVC about a potentially uninitialized variable 
svn-id: r50392
 2010-06-27 20:22:09 +00:00
Max Horn 6ee82a2027 SCI: Introduce SciGameId enum 
svn-id: r50273
 2010-06-25 16:16:29 +00:00
Martin Kiewitz 72ee20bc4d SCI: cnick-laurabow & cnick-kq are called with -Nw 0 0... 
svn-id: r50187
 2010-06-23 17:05:54 +00:00
Martin Kiewitz d8968ee5b9 SCI: reversing r50168, demo is using the same offTop as well (demo.bat) 
svn-id: r50169
 2010-06-22 21:05:34 +00:00
Martin Kiewitz 93b2336aa2 SCI: demo of fairy tales uses regular offTop 
svn-id: r50168
 2010-06-22 21:01:34 +00:00
Martin Kiewitz a836f965f8 SCI: set offTop to 26 for mixed up fairy tales to fix all sorts of non-fully-removed windows 
svn-id: r50166
 2010-06-22 20:40:41 +00:00
Matthew Hoops 0ab7a16e45 Fix the Hoyle 4 (Hoyle Classic) demo's top offset. It currently errors out later from lacking a selector (static selector problem). 
svn-id: r50118
 2010-06-21 19:07:41 +00:00
Filippos Karapetis db70d66e4a Strict mode: Changed several warnings due to logic bugs into errors. If an error pops up from these ones, please add the game where it occurred and the steps to reproduce the error before turning it into a warning 
svn-id: r49973
 2010-06-17 23:50:28 +00:00
Max Horn 359be0c066 SCI: Change SciEngine's 'char *getGameID()' to 'Common::String getGameId()' 
svn-id: r49968
 2010-06-17 23:14:34 +00:00
Martin Kiewitz 27741ee970 SCI: dont subtract offTop on wmgrPort when using old gfx functions - fixes about window in pq2 
svn-id: r49947
 2010-06-17 19:42:34 +00:00
Martin Kiewitz ba2de6dfa4 SCI: putting SciGui::init into SciEngine, removing it from SciGui(32) 
svn-id: r49854
 2010-06-15 13:34:40 +00:00
Martin Kiewitz 3269e5cc4c SCI: adjust priority bottom, if its 200 to avoid possible out of bounds (sierra actually does the same) 
svn-id: r49592
 2010-06-11 09:17:11 +00:00
Filippos Karapetis c874ff15a8 Cleaned up the game ID code: 
- The game ID is now obtained from ScummVM ID directly, not by converting Sierra's internal ID
- Moved the code which reads the internal Sierra ID inside the resource manager
- Moved the code which converts the internal Sierra ID to ScummVM's IDs together with the rest of the detection code

svn-id: r49152
 2010-05-23 10:28:03 +00:00
Martin Kiewitz ae4da9debe SCI: setting port _menuPort, fixing crash on setFont() 
svn-id: r49043
 2010-05-15 15:59:46 +00:00