Commit Graph
791 Commits
Author SHA1 Message Date
sluicebox 4fa1d891d8 SCI: Fix QFG1 trip wire lockup
Fixes bug #15736
2025-02-25 22:55:18 -08:00
sluicebox 04a538dbaf SCI: Fix LSL6 CD Interface Help cursor 2025-02-16 17:33:58 -07:00
sluicebox 8a5c1f20e0 SCI32: Fix LSL6HIRES Interface Help cursor
Fixes bug #14591
2025-02-16 12:55:37 -07:00
sluicebox 995da76327 SCI: Fix LSL1 lockup when casino doors close
Fixes bug #15701
2025-01-19 21:28:30 -08:00
sluicebox 2a020f02c9 SCI: Fix KQ1 script lockup when drowning in cave
Fixes bug #15667
2025-01-07 04:51:29 -08:00
sluicebox 3ac24923fb SCI: Fix KQ5 CD lock up when falling in mountains
Fixes bug #15550

This began occurring in 2021 when kDoAudio was fixed to stop all
currently playing digital samples. The fix exposed that the KQ5 CD
mountain script is incompatible with playing digital samples from
within sound resources. The KQ5 CD sound driver never played these
samples, and the script was not written to handle this condition.
We play all samples when "prefer_digitalsfx" is enabled, and it is
enabled by default, so now we patch out the script incompatibility.
See: de9443407f

Thanks to @LaZar00 for reporting.

Thanks to @MusicallyInspired for audio consulting and testing.
2024-12-03 23:25:47 -08:00
sluicebox bdfb26f31a SCI: Fix script patch comment typos 2024-12-02 17:36:41 -08:00
sluicebox be6011de2a SCI: Fix Talker timer rollover in LSL5, SQ1, BRAIN1
Fixes bug #15303

Thanks to @eriktorbjorn for reporting this
2024-12-02 16:54:46 -08:00
sluicebox f209a2304e SCI: Fix script patch comment typos 2024-11-13 11:32:36 -08:00
sluicebox 2b9c11d36b SCI: Fix KQ4 Lolotte bedroom door
Fixes bug #15471
2024-11-12 01:58:43 -08:00
Hubert Maier 7fd0c0f68f JANITORIAL: SCI: Fix typos 2024-09-16 01:58:56 +03:00
sluicebox b53d5fea26 SCI32: Fix GK1 Italian patch being applied to Mac
The compatibility script patch for the GK1 Italian fan patch was being
accidentally applied to GK1 Mac as well, causing dialogs to crash.
2024-08-05 17:59:33 -07:00
sluicebox c0b6eb3317 SCI: Fix CAMELOT guard messages at Jaffa Gate
Fixes but #14811
2024-07-24 12:48:34 -07:00
sluicebox 71dd6872d9 SCI: Fix PEPPER lockup when entering kitchen
Fixes bug #15263
2024-07-22 17:25:57 -07:00
sluicebox 7bd9f0b81b SCI: Fix CAMELOT empty purse message
Fixes bug #15288
2024-07-22 12:42:40 -07:00
sluicebox 5ffad3bbfe SCI: Fix LSL5 poker jackpot when restarting 2024-07-21 16:44:18 -07:00
sluicebox 66f994d797 SCI: Fix Betrayed Alliance speed menu
Fixes #15159
2024-07-19 11:28:58 -07:00
sluicebox 5fa9935730 SCI: Fix PEPPER dictionary word in maze
Fixes bug #15266
2024-07-17 18:27:35 -07:00
sluicebox 2fab44097e SCI: Update script patch comments 2024-07-17 18:27:35 -07:00
Torbjörn Andersson fb5096b3f0 SCI: Fix double "the" in comment 2024-06-27 07:56:04 +02:00
sluicebox 00adc4642f SCI: Fix PEPPER unsolvable puzzle box
Congratulations to @eriktorbjorn for discovering what has to be one of
the funniest Sierra bugs yet: a truly unsolvable puzzle.

Thanks to @m-kiewitz for the initial patch and @eriktorbjorn for the
impressively thorough research.

Fixes bug #15225
2024-06-26 18:49:52 -07:00
sluicebox 9d605801f0 SCI32: Fix HOYLE5 volume sync on variants 2024-06-19 16:31:36 -06:00
sluicebox 039069e803 SCI: Replace ECO2 workaround with script patch
The workaround fixed the crash in the first scene, but the underlying
script bug still corrupted global variables
2024-06-19 16:31:36 -06:00
amytant 0866f10e22 JANITORIAL: Fix typo in SCI script_patches.cpp 2024-06-16 00:56:52 +03:00
sluicebox dbb93adee4 SCI32: Add support for HOYLE5 School House Math variant 2024-06-15 00:12:04 -06:00
sluicebox 2dec932aff SCI32: HOYLE5 script patch cleanup 2024-06-15 00:00:56 -06:00
sluicebox 283a9022bd SCI: Fix HOYLE4/HOYLE5 Hearts strategy
Replaces uninit-variable workarounds with script patches.

The workarounds hard-coded a utility function in Hearts to always
return the first player's hand. The workarounds also used bytecode
signatures that only matched some game versions.

Now the correct Hearts hand is returned and all versions are fixed.
2024-06-14 16:43:22 -06:00
sluicebox 474ef22e24 SCI32: Fix QFG4 crash when throwing at rock pile
Fixes bug #14921
2024-03-28 09:21:21 -07:00
sluicebox f5aec9593b SCI: Fix HOYLE4 unexpected discard in Euchre
Fixes bug #14874

Thanks to @Karunamon for reporting this
2024-01-19 15:32:54 -07:00
sluicebox d2efce1c64 SCI: Fix LSL5 TPrint script patch
The patch altered the frame size of a call instruction, but I failed
to update the matching argument count on the stack.

This caused Print to receive an incorrect argc and crash the
gymnastics scene in room 920.

See: 4a40ac92ea

Fixes bug #14791

Thanks to @EricTSten for reporting this
2024-01-02 00:17:23 -08:00
sluicebox a26252fadf SCI: Fix PQ3 wrong ending 2023-12-21 13:19:42 -08:00
sluicebox 9a9a13605f SCI: Fix SQ1VGA buckazoid inventory crash
Big thank you to @codengine for discovering this script bug, performing
the script analysis, and developing the initial script patch.
2023-12-14 16:26:00 -08:00
sluicebox 6ee2a62779 SCI: Fix BRAIN2 art puzzle lockup
Fixes bug #14543
2023-12-12 21:55:06 -08:00
sluicebox b7522b2bb9 SCI: Fix BRAIN2 crash in robot maze
Fixes bug #14556

Thanks to @eriktorbjorn for finding this
2023-12-12 12:05:19 -08:00
sluicebox c59521f979 SCI32: Fix PHANT1 crash when leaving Harriet in the barn
Thanks to speedrunner @hitmarty for discovering this.

Thanks to @deckarep for the recent `errorString` feature that
helped diagnose this script bug from a screenshot.
2023-11-13 12:59:36 -08:00
sluicebox c241f21baa SCI: Reduce scope of variables 2023-11-03 15:12:40 -07:00
sluicebox d2b85bf473 SCI32: Update HOYLE5 Solitaire workarounds for Mac 2023-09-17 15:34:21 -07:00
sluicebox 49da510f80 SCI32: Fix PHANT1 dragon passage lockup
Fixes bug #14568

Thanks to @DustyShinigami for reporting this
2023-09-17 15:34:19 -07:00
sluicebox 2c7803d711 SCI32: Fix SQ6 trash can priority 2023-07-28 14:05:24 -07:00
sluicebox f16f8c792f SCI32: Fix SQ6 demo inventory crash
Fixes bug #14547
2023-07-18 11:46:38 -07:00
sluicebox 6a83bcbd95 SCI32: Fix SQ6 broken walk icon
Fixes bug #14537

Thanks to @Twixxi691 for reporting this
2023-07-15 12:18:25 -07:00
sluicebox 7cee0a5480 SCI: Update speed test overflow fix for more versions 2023-07-13 16:34:37 -07:00
sluicebox ddb0ef1de5 SCI: Fix overflow in SCI0 speed test script
Fixes a long delay on a black screen at the end of KQ4 introduction.

Thanks to @eriktorbjorn for reporting and reproducing this
2023-07-13 14:56:24 -07:00
sluicebox 0243c1f775 SCI: Update LSL5 palette animation patch 2023-07-12 21:57:00 -07:00
Torbjörn Andersson 636e2d341d SCI: Speed up the palette animation for Mr. Bigg's closeup in LSL5
This happens during the first meeting in the LSL5 intro. There is no
consensus on how fast this animation should run, but ScummVM runs it
extremely slow, possibly due to speed throttling. This speeds it up
by updating the animation ever 6th time the doit script is run,
rather than the original every 32nd time.
2023-07-12 21:57:00 -07:00
sluicebox 811033288e SCI32: Add compatibility with GK1 CD Italian fan translation
Fixes errors when displaying text and using the Walkman.
2023-05-24 13:49:50 -07:00
sluicebox 036c390478 SCI: Update LSL1 elevator polygon patch
The patch is now only applied to versions with the script bug
2023-04-28 13:39:32 -07:00
sluicebox 0c91983ee9 SCI: Update QFG2 patch notes for saurus freeze
I confirmed that the potential conflict identified in the notes
is not an issue, but added an alternate approach if needed.
2023-04-26 10:13:45 -07:00
sluicebox 6fe44fcbbf SCI: Update ECO1 stayAndHelp script patch
Simplifies the patch
2023-04-24 16:38:15 -07:00
sluicebox 9b6d2314dc SCI: Fix QFG2 visa crash 2023-04-24 15:41:30 -07:00