Commit Graph
86814 Commits
Author SHA1 Message Date
Torbjörn Andersson 10bd159d0d SWORD2: Add assert()s prompted by code analysis warnings.
See bug #3087857.

svn-id: r53509
2010-10-15 19:08:56 +00:00
Johannes Schickel cf8b589984 COMMON: Made some constructors explicit, where we wouldn't really like implicit conversion.
svn-id: r53508
2010-10-15 18:30:29 +00:00
Johannes Schickel 08afc68df0 COMMON: Extend workaround in HashMap code for sgi IRIX MIPSpro to also apply for Intel's C++ compiler.
svn-id: r53507
2010-10-15 18:20:21 +00:00
Johannes Schickel 4306a65577 COMMON: Revert attempt to silence MSVC warning in Common::gcd.
svn-id: r53506
2010-10-15 18:20:01 +00:00
Filippos Karapetis e7ff1574ef M4: Fixed OP_NOT and OP_COMP behavior again (thanks wjp)
svn-id: r53505
2010-10-15 15:51:59 +00:00
Filippos Karapetis 7f43ed3f9d SCI: Changed the check for vertex_min into an assert (thanks wjp)
svn-id: r53504
2010-10-15 15:40:36 +00:00
Filippos Karapetis db369838e2 AGOS: Fixed code analysis warnings - bug #3087828
svn-id: r53503
2010-10-15 15:23:53 +00:00
Filippos Karapetis 5961857049 TOON: Fixed code analysis warning - bug #3087867
svn-id: r53502
2010-10-15 15:17:49 +00:00
Filippos Karapetis c2e08538ee M4: Fixed code analysis warnings - bug #3087845
svn-id: r53500
2010-10-15 15:05:23 +00:00
Filippos Karapetis abcceb8a4e QUEEN: Fixed code analysis warning - bug #3087851
svn-id: r53499
2010-10-15 14:37:50 +00:00
Filippos Karapetis f3270f1957 SCI: Fixed access to dest in kTextSize() (thanks LordHoto)
svn-id: r53498
2010-10-15 14:33:57 +00:00
Johannes Schickel 5c102d4f08 COMMON: Silence gcc warning introduced with r53496.
svn-id: r53497
2010-10-15 14:18:58 +00:00
Johannes Schickel 8fc3c21bd0 COMMON: Attempt to silence MSVC warning in Common::gcd.
svn-id: r53496
2010-10-15 14:14:51 +00:00
Johannes Schickel d221176c47 CRUISE: Replace some strncpy with strlcpy.
svn-id: r53495
2010-10-15 14:14:33 +00:00
Johannes Schickel 36d7ec96b9 KYRA: Fix valid warnings of bug #3087837 "KYRA: Code analysis warnings".
svn-id: r53494
2010-10-15 14:14:10 +00:00
Sven Hesse ccb3506719 GRAPHICS: Fix code analysis warnings
See bug report #3087917

svn-id: r53493
2010-10-15 13:56:14 +00:00
Sven Hesse 81de95671c GOB: Properly fixing the captureCounter code analysis warning
svn-id: r53492
2010-10-15 13:55:46 +00:00
Sven Hesse 835455798f GOB: Remove the now useless helper.h
svn-id: r53491
2010-10-15 13:55:18 +00:00
Sven Hesse 5c48c3fd2b GOB: Remove strncpy0()
Replacing it (and some strncpy + manual terminating) with
Common::strlcpy()

svn-id: r53490
2010-10-15 13:54:23 +00:00
David Turner 04973e85be VIDEO : Corrections to QDM2 codec for bug #3087917 "Code Analysis Warnings"
The first correction was to use a temporary variable to remove the possibility of a memory leak when using realloc.
The second correction was to remove the gain variable from QDM2Stream::qdm2_calculate_fft() which has always evaluated to 1.0f and so has no effect.

svn-id: r53489
2010-10-15 13:11:34 +00:00
Filippos Karapetis e74e4814e4 SWORD1: Fixed bug #3087855 - "SWORD1: Code analysis warnings"
svn-id: r53488
2010-10-15 13:07:31 +00:00
Filippos Karapetis 9717686337 MADE: Fixed bug #3087849 - "MADE: Code analysis warnings"
svn-id: r53487
2010-10-15 13:00:19 +00:00
Filippos Karapetis c1e47e0e60 SAGA: Added sanity checks for realloc() calls - bug report #3087852
svn-id: r53486
2010-10-15 12:56:17 +00:00
Max Horn 4ccce19876 ENGINES: Enhance namespace comments a bit
svn-id: r53484
2010-10-15 12:48:19 +00:00
Travis Howell 42f2a13155 Reverted revision 53456, as requested.
svn-id: r53483
2010-10-15 12:41:11 +00:00
Filippos Karapetis 7cdddd5ffb SCI: Fixed code bugs from bug #3087872 - "SCI: Code analysis warnings"
svn-id: r53482
2010-10-15 12:40:24 +00:00
Max Horn 34cc54eaa9 Add doxygen comment for namespaces of several engines.
This is an empty template which ideally engine maintainers
would update and complete with concrete information...

svn-id: r53481
2010-10-15 12:28:56 +00:00
Max Horn 2fed5ff832 COMMON: Move XMLParser method impls to .cpp file; make skipComments non-virtual
svn-id: r53480
2010-10-15 12:19:34 +00:00
Max Horn 36cd5caf95 COMMON: Add XMLParser::parseIntegerKey variant accepting a Common::String
Almost all places where we used XMLParser::parseIntegerKey were using
it like this:
  XMLParser::parseIntegerKey(str.c_str(), ...)
Since this makes the code harder to read, I overloaded the method to
also accept Commmon::String directly.
Also removed all .c_str() invocations where necessary.

svn-id: r53479
2010-10-15 12:19:13 +00:00
Max Horn f52b31a05f SWORD25: Typo, cleanup
svn-id: r53478
2010-10-15 12:18:41 +00:00
Max Horn 550073ee04 SWORD25: Do not use Kernel::GetService directly anymore
svn-id: r53477
2010-10-15 12:18:19 +00:00
Max Horn 2b5de8c892 SWORD25: Adapted a few things to our code formatting conventions; translated rest of graphicengine.h to german
svn-id: r53476
2010-10-15 12:17:20 +00:00
Max Horn f8c15c90ff SWORD25: Fix a few global constructor warnings
svn-id: r53475
2010-10-15 12:16:57 +00:00
Paul Gilbert 96585f24d9 SWORD25: Fix unloading of movies so the menu animation properly loops
svn-id: r53474
2010-10-15 10:52:23 +00:00
Eugene Sandulenko 9b9e8f7d8d DRASCULA: Fix some code analysis warnings (bug #3087830)
svn-id: r53473
2010-10-15 09:08:54 +00:00
Eugene Sandulenko b0923dfd76 CRUISE: Fix some code analysis warnings (bug #3087829)
svn-id: r53472
2010-10-15 08:57:18 +00:00
Paul Gilbert 168670acb2 TINSEL: Fix for #3087863 - Code analysis warnings
svn-id: r53471
2010-10-15 08:52:22 +00:00
Eugene Sandulenko 764eaa554c AGI: Fix some code analysis warnings (bug #3087825)
svn-id: r53470
2010-10-15 08:49:20 +00:00
Paul Gilbert 63cb051351 LURE: Fix for #3087842 - Code analysis warnings
Only the warning for res_struct.cpp is valid to be fixed

svn-id: r53469
2010-10-15 08:29:23 +00:00
Arnaud Boutonné bd18e20f7d HUGO: Merge engine and hugo files
- Move initNewScreenDisplay to display.cpp
- Merge engine.cpp and hugo.cpp

svn-id: r53468
2010-10-15 06:16:27 +00:00
Torbjörn Andersson e5ec399c55 SWORD2: Fix some code analysis warnings (bug #3087857)
svn-id: r53467
2010-10-15 06:12:23 +00:00
Arnaud Boutonné 6049a370b3 HUGO: Fix NULL pointer dereferencing
svn-id: r53466
2010-10-15 06:08:42 +00:00
Vladimir Menshakov bacbf08900 Bug #3087858: fixed null pointer dereferencing
svn-id: r53465
2010-10-15 05:50:19 +00:00
Sven Hesse 089988c11c GOB: Fix Code analysis warnings
See bug report #3087831

svn-id: r53464
2010-10-15 04:37:44 +00:00
Matthew Hoops dad3f32278 MACOSX: Fix make bundle when compiling with libpng
svn-id: r53463
2010-10-15 03:33:54 +00:00
Yotam Barnoy 6fc10aeeac PSP: made image in viewer movable by pushing nub continuously
svn-id: r53462
2010-10-14 22:33:32 +00:00
Jordi Vilalta Prat 06c2b6bace TOON: Fixed the Spanish special characters.
- Wrap the text to font mapping in a function to give more flexibility.
- Add mapping of the opening exclamation and question marks to the common
  mapping array.
- Added a special case for a character already mapped incorrectly in the
  original interpreter, which seems to conflict with what's required by
  the other languages.

svn-id: r53461
2010-10-14 22:27:48 +00:00
Yotam Barnoy a4537b84bd PSP: made image viewer reset to the first image between engine loads
svn-id: r53460
2010-10-14 22:11:17 +00:00
Eugene Sandulenko f67bbc4ecc SWORD25: Attempt to optimize movie rendering
Current code makes about 5 blits of each frame which is a huge
overhead. This code is an attempt to make that 1. Doesn't work yet
as the rendering pipe keeps blitting invisible pictures.

svn-id: r53459
2010-10-14 20:44:44 +00:00
Jordi Vilalta Prat 00a477fa79 TOON: Fix some labels of the Spanish version.
The solution was suggested by Strangerke after realising it looked like a
copy-paste typo from the Russian version.

svn-id: r53458
2010-10-14 18:51:11 +00:00