Commit Graph
86814 Commits
Author SHA1 Message Date
Johannes Schickel 867c0d9645 COMMON: Add an erase method which takes an iterator to HashMap.
Currently there is no iterator returned from this method, to have some
similarity to associative containers of the STL.

I also "added" one unit test for this method, which is basically just
a copy of the HashMap::erase(const Key &) test with the required adaptions.

svn-id: r55661
2011-01-30 17:28:35 +00:00
David Turner ec885e5665 SCUMM: Fix Valgrind mismatched delete errors in SMUSH channel base class.
This was due to the SMUSH channel base class using new/delete to manage buffer, but the imuse_channel and saud_channel classes which subclass and override this using malloc/free.
The more C++ solution of moving all to new/delete was tried, but the buffer is passed into a MemoryReadStream and free()'d there, so all classes have been moved to malloc/free instead.
This is not a critical problem as the buffers are byte primitive type anyway.

svn-id: r55660
2011-01-30 16:50:55 +00:00
David Turner b644c6d466 SCUMM: Remove direct usage of OSystem quit() function in SCUMM engine code.
This would cause leaks, but occurs in development code only.

svn-id: r55659
2011-01-30 14:53:47 +00:00
David Turner 7d5dcc2a0a SWORD1: Fix possible uninitialized memory read in Screen object.
This was detected during playtest with Valgrind during Act 5 (Spain).

svn-id: r55658
2011-01-30 14:41:27 +00:00
Bastien Bouclet 0b69b6a842 MOHAWK: Myst, pass the playback direction from the calling script to the movie player.
svn-id: r55657
2011-01-30 13:54:39 +00:00
Bastien Bouclet b43fae5c18 MOHAWK: Myst, display a warning when trying to play a movie backwards.
svn-id: r55656
2011-01-30 13:44:01 +00:00
Sylvain Dupont 3cd1ac9ca6 TOON: Add coordinates clamping for safety
In some rare cases, Drew position is outside the valid area. 
Made sure it does not crash in these cases.

svn-id: r55655
2011-01-30 13:31:13 +00:00
Sven Hesse f8d61c9e55 GOB: Work around the unimplemented copyFile :P
svn-id: r55654
2011-01-30 13:14:54 +00:00
Sven Hesse c88ee19478 GOB: Stub some Adibou mult stuff
svn-id: r55653
2011-01-30 13:14:32 +00:00
Bastien Bouclet a95f69c502 MOHAWK: Implement Stoneship cloud orbs
svn-id: r55652
2011-01-30 12:33:39 +00:00
Arnaud Boutonné aba8451744 HUGO: Fix a crash in maze and a bug in lineHandler()
svn-id: r55651
2011-01-30 07:53:44 +00:00
Sylvain Dupont 5934ccd184 TOON: Fix the last known z-order issues
Rewrote the Z-order management, it's now very close to the original code

svn-id: r55650
2011-01-30 02:18:53 +00:00
Sylvain Dupont 01c32f7287 TOON: More Drew visibility fixes
In the castle, Drew disappeared if you clicked twice on the closed door.

svn-id: r55649
2011-01-30 00:44:51 +00:00
Sven Hesse fc59e0b6b3 GOB: Add o7_playVmdOrMusic
svn-id: r55648
2011-01-30 00:04:04 +00:00
Sven Hesse e4a9cafab8 GOB: Add a sanity check to the copyFile stub
svn-id: r55647
2011-01-30 00:03:35 +00:00
Sven Hesse 4588d4cc97 GOB: Add Inter_Playtoons::readSprite()
svn-id: r55646
2011-01-30 00:03:12 +00:00
Sven Hesse c498d70dd2 GOB: Change SPRITES_COUNT into a const
svn-id: r55645
2011-01-30 00:02:42 +00:00
Sven Hesse 0793e5c0a3 GOB: Adibou has background atmosphere
svn-id: r55644
2011-01-30 00:02:14 +00:00
Sven Hesse d635c7b950 GOB: Fix Inter_v6::probe16bitMusic()
svn-id: r55643
2011-01-30 00:01:43 +00:00
Arnaud Boutonné 98e329bbd1 HUGO: Cleanup drawRectangle() and keyHandler()
svn-id: r55642
2011-01-29 23:05:12 +00:00
Sylvain Dupont 9c17cedd40 TOON: Bug #3124518 with disappearing inventory items fixed
Bug #3124518: "TOON: loss of inventory items in Bricabrac's machine room"
Was caused by recursive walkTo that were not canceling out.

svn-id: r55641
2011-01-29 23:03:08 +00:00
Sven Hesse 4e66280388 GOB: Implement o7_loadFunctions and o7_callFunction
svn-id: r55640
2011-01-29 22:50:41 +00:00
Sven Hesse 078162c665 GOB: Add setExtension()
svn-id: r55639
2011-01-29 22:50:11 +00:00
Sven Hesse ec288c0603 GOB: Rename loadGroups/callGroup to loadFunctions/callFunctions
svn-id: r55638
2011-01-29 22:49:40 +00:00
Sven Hesse 993a543432 GOB: Add Inter_Playtoons::getFile()
svn-id: r55637
2011-01-29 22:49:15 +00:00
Sven Hesse ffc4af820f GOB: _environments doesn't need to be a pointer
svn-id: r55636
2011-01-29 22:48:44 +00:00
Sven Hesse d2c9893327 GOB: Remove the long obsolete inter_execPtr
svn-id: r55635
2011-01-29 22:48:18 +00:00
Sven Hesse 65bc46d3ab GOB: Add Script::evalInt() and Script::evalString()
svn-id: r55634
2011-01-29 22:47:53 +00:00
Sven Hesse 40bf0286a1 GOB: Rename Script::evalBoolResult() to Script::evalBool()
svn-id: r55633
2011-01-29 22:47:14 +00:00
Sven Hesse b54416b46e GOB: Stub o7_loadGroups
svn-id: r55632
2011-01-29 22:46:41 +00:00
Sven Hesse 9b9c34a378 GOB: o7_draw0x59 is o7_callGroup
svn-id: r55631
2011-01-29 22:46:16 +00:00
Sven Hesse ce3d4b5d1b GOB: Add GobEngine::isCurrentTot()
svn-id: r55630
2011-01-29 22:45:51 +00:00
Sven Hesse 0c3a33c354 GOB: Change _curTotFile and _totToLoad into Common::String
svn-id: r55629
2011-01-29 22:45:15 +00:00
Sven Hesse 05d5d64d6c GOB: Rename "skipPlay" to "function" in playTot
svn-id: r55628
2011-01-29 22:44:36 +00:00
Sven Hesse 14678f059b GOB: Move OpcodeFunc's return flag into its parameter
To make the meaning of the flag more clear and make the func
opcodes more similar to draw and gob opcodes.

svn-id: r55627
2011-01-29 22:44:06 +00:00
Sylvain Dupont c450ac28e9 TOON: Add workarounds in transformed barn scene
Drew does not disappear anymore in the barn when filling his can.
Slowed down the talk animations a bit

svn-id: r55626
2011-01-29 22:15:57 +00:00
Sylvain Dupont 7765c24558 TOON: Fix some palette issues
- In fade out when leaving certain rooms
- When loading a game in a cutaway/closeup state

svn-id: r55625
2011-01-29 20:59:46 +00:00
Sylvain Dupont 96f4cc4b8a TOON: Pathfinding & walking improvements
Use direct line path if possible
Smooth facing direction to avoid flickering (entering zanidu shuttle for example)
Fix possible lockups

svn-id: r55624
2011-01-29 20:12:27 +00:00
Johannes Schickel d925e38acf KYRA: Hopefully fix valgrind warnings in the HoF intro when text is disabled.
svn-id: r55623
2011-01-29 19:03:50 +00:00
Bastien Bouclet e2b3ac9f28 MOHAWK: More Stoneship progress, hologram viewer and drawers
svn-id: r55622
2011-01-29 18:45:45 +00:00
Sylvain Dupont 875a840a7a TOON: Fixed crash of bug #3166533
Bug #3166533: "TOON: crashes when leaving room"

svn-id: r55621
2011-01-29 18:42:33 +00:00
Johannes Schickel 2cc3bd880f KYRA: Clean up main menu code in Kyra2/Kyra3.
svn-id: r55620
2011-01-29 18:40:04 +00:00
David Turner 450dac35c7 KYRA: Fix Valgrind Uninitialized Memory Read at end of VQA Playback.
svn-id: r55619
2011-01-29 18:20:38 +00:00
David Turner f050e2d66f KYRA: Close Memory Leaks in Kyra 3 (Malcolm's Revenge) Menu.
svn-id: r55618
2011-01-29 18:18:29 +00:00
Sylvain Dupont 83866978be TOON: Reenable keyboard events
Was disabled when some sticky keyboard flags were activated

svn-id: r55617
2011-01-29 16:19:55 +00:00
Sylvain Dupont 896b87c710 TOON: Bug #3166570 fixed. Magnifier effect when selecting Enigma book
Bug #3166570: "TOON: Wrong mouse-cursor for Item "Book-Enigma"

svn-id: r55616
2011-01-29 16:02:20 +00:00
Jordi Vilalta Prat fad6d32e02 NEWS: Add proper punctuation.
svn-id: r55615
2011-01-29 15:27:30 +00:00
Arnaud Boutonné 946bdcd389 HUGO: Display all (clipped) object zones in God Mode
svn-id: r55614
2011-01-29 14:10:47 +00:00
Filippos Karapetis 1da472a2db SWORD25: Translated some comments, and removed some superfluous ones
svn-id: r55613
2011-01-29 10:56:34 +00:00
Bastien Bouclet 6ed7f48442 MOHAWK: Implement more Stoneship puzzles, up to linking back to Myst
svn-id: r55612
2011-01-29 10:49:15 +00:00