ScummVM/scummvm
1
0
Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
86,814 Commits 45 Branches 139 Tags
578a6794de9ba7679966fee9aec02c6b2bdbce94
Commit Graph
54649 Commits
Author SHA1 Message Date
Adrian Frühwirth 788d85d6b8 SCUMM: Work around distorted speech on submarine in Indy4 
The speech sample at VCTL offset 0x76ccbca ("Hey you!") which is used
when Indy gets caught on the German submarine seems to not be a VOC
but raw PCM s16be at (this is a guess) 44.1 kHz with a bogus VOC header.
To work around this we skip the VOC header and decode the raw PCM data.

Fixes Trac#10559
 2018-06-06 18:20:20 +00:00
Torbjörn Andersson fba0afefa5 SCUMM: Remove unnecessary space. 2018-06-04 06:41:51 +02:00
Adrian Frühwirth d433aedf37 SCUMM: Improve 'imuse play' debugger command error handling 
This commit introduces the following (seemingly non-invasive) changes
to make the 'imuse play' debugger command more useful (i.e. don't crash
when trying to load the wrong kind of (sound) resource.

* ScummEngine::readSoundResource()
  Instead of fatally error()'ing upon hitting a non-sound resource type,
  e.g. a room header (0x524d4844 aka RMHD), we now only issue a warning().
  This enables the already existing dead code which properly returns 0
  (aka no resource loaded).

* ResourceManager::validateResource()
  Instead of fatally error()'ing upon hitting an illegal glob type we now
  only issue a warning() and return false (also existing dead code).
  All methods calling validateResource() check its return value so this
  seems like the right thing to do anyway.

* ScummDebugger::Cmd_IMuse()
  Instead of directly calling ensureResourceLoaded() we now call
  getResourceAddress() instead (which in turn calls ensureResourceLoaded()
  and handles other edge cases) and only attempt to play a sound if the
  returned pointer actually is valid.

Fixes Trac#10527.
 2018-06-03 19:38:52 +01:00
David Fioramonti 8405c5d5f0 SAGA: Don't show pause message in saved thumbnail 
Fixes Trac#10008. Previously, the game would show
a paused game message in the thumbnail when the
game was saved using the gmm.
 2018-06-03 19:36:58 +01:00
Thierry Crozat 4229e2642e Merge pull request #1141 from DanielSWolf/larryscale 
SCI: High-quality "LarryScale" cel scaler for LSL7
 2018-06-03 17:41:47 +01:00
Bastien Bouclet 643ce81cf7 BASE: Remove temporary targets when they fail to launch 
Prevents invalid targets created from the command line to show up in the
launcher.

Fixes Trac#2788.
 2018-06-03 13:48:31 +02:00
Adrian Frühwirth 56d2bf77ba SCUMM: Ensure pointer returned by getResourceAddress() is usable 
In some cases the pointer returned is used directly without further
error checking.
As most instances already assert() in this case this commit simply
adds asserts where missing and deemed appropriate.
 2018-06-01 17:08:39 +00:00
Simei Yin 8ead8de284 SLUDGE: Move save game getter to StackHandler 2018-05-31 23:15:09 +02:00
Simei Yin fa72209845 SLUDGE: Move stack size getter to struct StackHandler 2018-05-31 23:15:09 +02:00
Simei Yin 80478ee470 SLUDGE: Move copyStack() to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin ca583ebfcf SLUDGE: Move last stack finding function to struct VariableStack 2018-05-31 23:15:09 +02:00
Simei Yin 9fb57f944d SLUDGE: Move stack variable getter/setter to VariableStack 2018-05-31 23:15:09 +02:00
Simei Yin dc18ec2fd0 SLUDGE: Move FastArray getter to struct FastArrayHandler 2018-05-31 23:15:09 +02:00
Simei Yin 399ff4788c SLUDGE: Move fastarray functions to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 746fb3819f SLUDGE: Move value getters to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 9d85b807fb SLUDGE: Move add/comparison functions to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 719f5842fa SLUDGE: Move costume functions to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 04ef7becf3 SLUDGE: Move PersonAnimation functions into struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 805a47b74a SLUDGE: Move text related functions to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 98f764050a SLUDGE: Move copyVariable to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 56f0821876 SLUDGE: Move save/loadVariable() to struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 2ab7665e56 SLUDGE: Move SetVariable() into struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 04444b70f9 SLUDGE: Move unlinkVar into struct Variable 2018-05-31 23:15:09 +02:00
Simei Yin 6004cd319d SLUDGE: Move createCString() with string tools 2018-05-31 23:15:09 +02:00
Paul Gilbert 7edac197e4 XEEN: Correct scroll and music when signing into tavern 2018-05-30 20:12:13 -04:00
Paul Gilbert d6841efd63 XEEN: Fix Direction Sense display 2018-05-30 18:51:40 -04:00
Paul Gilbert b191cbf909 XEEN: Stop re-rolling new character stats when some areas of screen clicked 2018-05-30 18:15:50 -04:00
Paul Gilbert 46c9c9f0c1 XEEN: Properly reset subtitles when replaying cutscenes 2018-05-30 18:00:39 -04:00
Eugene Sandulenko 1e1ed29704 SCUMM: HE: Mark Bink as engine dependency 2018-05-30 09:26:17 +02:00
Simei Yin 3e88827c4c SLUDGE: Move function/variable load/save functions to related files 2018-05-29 22:59:52 +02:00
Simei Yin 87e58a9b7e SLUDGE: Split runSludge() to runAllFunctions() and handleSaveLoad() 2018-05-29 22:37:10 +02:00
Simei Yin dc320b86bc SLUDGE: Create constructor of Variable instead of initVarNew 2018-05-29 22:37:10 +02:00
Simei Yin 1ec5ef3e4d SLUDGE: Move resource names to ResourceManager 2018-05-29 22:37:10 +02:00
Simei Yin 0548765479 SLUDGE: Objectify FatalMsgManager 2018-05-29 22:37:10 +02:00
Simei Yin b6c2dc385a SLUDGE: Split out function.h/cpp for upcoming refactoring 2018-05-29 22:37:10 +02:00
Thierry Crozat 44bc04e0d9 GUI: Move UnknownGameDialog to gui 2018-05-28 20:55:00 +01:00
Bastien Bouclet 61f9398b04 Merge pull request #1187 from bgK/detection-refactor-unknown 
ENGINES: Return unknown game variants with the list of detected games
 2018-05-28 18:43:15 +02:00
Bastien Bouclet 8d654285cb MOHAWK: MYST: Fix drawing the Stoneship red page open door 
When the lights are on, the open door image would not draw at the
correct position in Myst ME only.

This is due to the open door image being too small. The original has a
special case for that image. We reproduce that same hack.

Fixes Trac#7143.
 2018-05-28 15:20:09 +02:00
Bastien Bouclet 35f4983ca1 Merge pull request #1201 from ccawley2011/mohawk-sound 
MOHAWK: Fix decoding sounds with 16 bit samples
 2018-05-28 10:44:21 +02:00
Paul Gilbert 69ebe3747a XEEN: Fix compiler warning 2018-05-27 20:43:04 -04:00
Paul Gilbert 23f3f171df XEEN: Fix close-up objects placement, incorrect skill text in Create Char dialog 2018-05-27 19:56:41 -04:00
Simei Yin 881c946361 SLUDGE: Move global variable lastFramesPerSecond to class Timer 2018-05-27 22:11:38 +02:00
Simei Yin bf3084df0e SLUDGE: Move built-in function parameter number to structure 2018-05-27 22:11:38 +02:00
Paul Gilbert 057bf6ea92 XEEN: Leave chests open after their contents are taken 2018-05-27 14:45:01 -04:00
Paul Gilbert 9abcaecb0c XEEN: Animate open treasure chests with treasure 2018-05-27 13:56:15 -04:00
Bastien Bouclet 2925d2ef2f Merge pull request #1198 from dafioram/mohawk10536 
MOHAWK: README: Minor autosave changes and notes for autosaving
 2018-05-26 09:01:57 +02:00
Cameron Cawley 8f1d1836f3 MOHAWK: Fix decoding sounds with 16 bit samples 2018-05-24 17:22:15 +01:00
Adrian Frühwirth cee4d6b853 JANITORIAL: Fix trailing whitespace 2018-05-24 15:30:55 +02:00
Adrian Frühwirth bc949250de JANITORIAL: Convert line endings from CRLF/mixed to LF 2018-05-24 15:30:55 +02:00
Gabriel Corona 39c2477fbe FULLPIPE: fix URI 
The previous URI spawns many useless subshells on the POSIX backend
through (harmless) shell command injection.
 2018-05-24 01:08:28 +02:00