ScummVM/scummvm
1
0
Fork 0
mirror of https://github.com/scummvm/scummvm.git synced 2026-06-20 05:45:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

SDL: Fix bug where config file path could exceed maximum path length.

Browse Source 
The fix is the change in the MAXPATHLEN check, but have also migrated
this to Common::String to make the fix easier.

Thanks to klusark for pointing out this problem.
This commit is contained in:
D G Turner
2013-11-14 18:35:03 +00:00
parent ed68aea5ba
commit 8b9d4348f8
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backends/platform/sdl/posix/posix.cpp
+6 -5
View File
@@ -80,15 +80,16 @@ bool OSystem_POSIX::hasFeature(Feature f) {
}
Common::String OSystem_POSIX::getDefaultConfigFileName() {
char configFile[MAXPATHLEN];
Common::String configFile;
// On POSIX type systems, by default we store the config file inside
// to the HOME directory of the user.
const char *home = getenv("HOME");
if (home != NULL && strlen(home) < MAXPATHLEN)
snprintf(configFile, MAXPATHLEN, "%s/%s", home, _baseConfigName.c_str());
else
strcpy(configFile, _baseConfigName.c_str());
if (home != NULL && (strlen(home) + 1 + _baseConfigName.size()) < MAXPATHLEN) {
configFile = Common::String::format("%s/%s", home, _baseConfigName.c_str());
} else {
configFile = _baseConfigName;
}
return configFile;
}