Fixed some breakage in the 'Add Game' code I recently introduced; added a FIXME comment regarding the 'description' config file key

svn-id: r21943
This commit is contained in:
Max Horn
2006-04-16 13:58:11 +00:00
parent 1a20a9ae09
commit 555a568e59
3 changed files with 26 additions and 2 deletions
+10
View File
@@ -553,6 +553,16 @@ void ConfigManager::setActiveDomain(const String &domName) {
_activeDomainName = domName;
}
void ConfigManager::addGameDomain(const String &domName) {
assert(!domName.empty());
assert(isValidDomainName(domName));
// TODO: Do we want to generate an error/warning if a domain with
// the given name already exists?
_gameDomains[domName];
}
void ConfigManager::removeGameDomain(const String &domName) {
assert(!domName.empty());
assert(isValidDomainName(domName));
+1 -1
View File
@@ -146,7 +146,7 @@ public:
const Domain * getActiveDomain() const { return _activeDomain; }
const String & getActiveDomainName() const { return _activeDomainName; }
// void addDomain(const String &domName);
void addGameDomain(const String &domName);
void removeGameDomain(const String &domName);
void renameGameDomain(const String &oldName, const String &newName);
bool hasGameDomain(const String &domName) const;
+15 -1
View File
@@ -616,8 +616,22 @@ void LauncherDialog::addGame() {
suffix++;
domain += suffix;
}
ConfMan.set("description", result.description, domain);
}
// Add the name domain
ConfMan.addGameDomain(domain);
// TODO: Setting the description field here has the drawback
// that the user does never notice when we upgrade our descriptions.
// It might be nice ot leave this field empty, and only set it to
// a value when the user edits the description string.
// However, at this point, that's impractical. Once we have a method
// to query all backends for the proper & full description of a given
// game target, we can change this (currently, you can only query
// for the generic gameid description; it's not possible to obtain
// a description which contains extended information like language, etc.).
ConfMan.set("description", result.description, domain);
ConfMan.set("gameid", result.gameid, domain);
ConfMan.set("path", dir.path(), domain);