Fixed extract_agos, compress_tinsel, sciunpack and tools.h for warnings given by cppcheck.

Compiles fine, but slightly unsure of possible effect of tools.h change. Needs testing.

svn-id: r47310

engines/agos/extract_agos.cpp

@@ -53,14 +53,13 @@ void ExtractAgos::execute() {
 	if (out) {
 		if (simon_decr(x, out, _filelen)) {
 			savefile(_outputPath.getFullPath(), out, decrlen);
+			free(x);
+			free(out);
 		} else {
 			free(x);
 			free(out);
 			error("%s: decrunch error\n", infilename.getFullPath().c_str());
 		}
-
-		free(x);
-		free(out);
 	}
 }
 

engines/tinsel/compress_tinsel.cpp

@@ -158,6 +158,7 @@ void CompressTinsel::convertTinselADPCMSample (uint32 sampleSize) {
 	outBuffer = (int16 *)malloc(uncompressedSize);
 	if (!outBuffer) {
 		print("malloc failed!\n");
+		free(inBuffer);
 		return;
 	}
 

sci/sciunpack.cpp

@@ -437,6 +437,7 @@ void unpack_resource(int stype, int snr, char *outfilename) {
 					guint8 *outdata = makeMIDI0(found->data, &midilength, midimask);
 					if (!outdata) {
 						fprintf(stderr, "MIDI conversion failed. Aborting...\n");
+						close(outf);
 						return;
 					}
 					if (verbose) printf("MIDI conversion from %d bytes of sound resource"

tools.h

@@ -33,7 +33,7 @@
 class Tools {
 public:
 	Tools();
-	~Tools();
+	virtual ~Tools();
 
 	typedef std::vector<Tool *> ToolList;