mirror of
https://github.com/ProtonMail/android-mail.git
synced 2026-05-15 09:50:40 +00:00
Remove Share Logs from Sidebar
ET-4140
This commit is contained in:
committed by
MargeBot
parent
b68ce03bc7
commit
d43b62894d
@@ -740,7 +740,6 @@ private fun buildSidebarActions(navController: NavHostController, launcherAction
|
||||
onSubscription = launcherActions.onSubscription,
|
||||
onContacts = { navController.navigate(Screen.Contacts.route) },
|
||||
onReportBug = { navController.navigate(Screen.BugReporting.route) },
|
||||
onExportLogs = { navController.navigate(Screen.ApplicationLogs.route) },
|
||||
onUpselling = { entryPoint, type -> navController.navigate(Screen.FeatureUpselling(entryPoint, type)) }
|
||||
)
|
||||
|
||||
|
||||
-10
@@ -47,7 +47,6 @@ import ch.protonmail.android.mailsidebar.presentation.common.ProtonSidebarItem
|
||||
import ch.protonmail.android.mailsidebar.presentation.common.ProtonSidebarLazy
|
||||
import ch.protonmail.android.mailsidebar.presentation.common.ProtonSidebarReportBugItem
|
||||
import ch.protonmail.android.mailsidebar.presentation.common.ProtonSidebarSettingsItem
|
||||
import ch.protonmail.android.mailsidebar.presentation.common.ProtonSidebarShareLogs
|
||||
import ch.protonmail.android.mailsidebar.presentation.common.ProtonSidebarSubscriptionItem
|
||||
import ch.protonmail.android.mailsidebar.presentation.label.SidebarLabelAction
|
||||
import ch.protonmail.android.mailsidebar.presentation.label.sidebarFolderItems
|
||||
@@ -153,7 +152,6 @@ fun Sidebar(
|
||||
|
||||
item { ProtonSidebarReportBugItem(onClick = actions.onReportBug) }
|
||||
|
||||
item { ProtonSidebarShareLogs(onClick = actions.onExportlogs) }
|
||||
item { VerticalSpacer(height = ProtonDimens.Spacing.ExtraLarge) }
|
||||
|
||||
item { SidebarDivider() }
|
||||
@@ -211,7 +209,6 @@ object Sidebar {
|
||||
val onSubscription: () -> Unit,
|
||||
val onContacts: () -> Unit,
|
||||
val onReportBug: () -> Unit,
|
||||
val onExportlogs: () -> Unit,
|
||||
val onUpselling: (entryPoint: UpsellingEntryPoint.Feature, type: UpsellingVisibility) -> Unit
|
||||
) {
|
||||
|
||||
@@ -223,7 +220,6 @@ object Sidebar {
|
||||
onSubscription = {},
|
||||
onContacts = {},
|
||||
onReportBug = {},
|
||||
onExportlogs = {},
|
||||
onUpselling = { _, _ -> }
|
||||
)
|
||||
}
|
||||
@@ -236,7 +232,6 @@ object Sidebar {
|
||||
val onSubscription: () -> Unit,
|
||||
val onContacts: () -> Unit,
|
||||
val onReportBug: () -> Unit,
|
||||
val onExportLogs: () -> Unit,
|
||||
val onUpselling: (entryPoint: UpsellingEntryPoint.Feature, type: UpsellingVisibility) -> Unit
|
||||
) {
|
||||
|
||||
@@ -261,10 +256,6 @@ object Sidebar {
|
||||
onReportBug()
|
||||
close()
|
||||
},
|
||||
onExportlogs = {
|
||||
onExportLogs()
|
||||
close()
|
||||
},
|
||||
onUpselling = { entryPoint, type ->
|
||||
onUpselling(entryPoint, type)
|
||||
close()
|
||||
@@ -280,7 +271,6 @@ object Sidebar {
|
||||
onSubscription = {},
|
||||
onContacts = {},
|
||||
onReportBug = {},
|
||||
onExportLogs = {},
|
||||
onUpselling = { _, _ -> }
|
||||
)
|
||||
}
|
||||
|
||||
-16
@@ -128,22 +128,6 @@ fun ProtonSidebarReportBugItem(
|
||||
)
|
||||
}
|
||||
|
||||
@Composable
|
||||
fun ProtonSidebarShareLogs(
|
||||
modifier: Modifier = Modifier,
|
||||
isClickable: Boolean = true,
|
||||
onClick: () -> Unit = {}
|
||||
) {
|
||||
ProtonSidebarItem(
|
||||
text = R.string.drawer_title_share_logs,
|
||||
icon = R.drawable.ic_proton_bug,
|
||||
modifier = modifier,
|
||||
onClick = onClick,
|
||||
isClickable = isClickable,
|
||||
isSelected = false
|
||||
)
|
||||
}
|
||||
|
||||
@Composable
|
||||
fun ProtonSidebarItem(
|
||||
@DrawableRes icon: Int,
|
||||
|
||||
@@ -22,6 +22,5 @@
|
||||
<string name="drawer_title_bug_report">Report a problem</string>
|
||||
<string name="drawer_item_create_label">Create label</string>
|
||||
<string name="drawer_item_create_folder">Create folder</string>
|
||||
<string name="drawer_title_share_logs" translatable="false">Share logs</string>
|
||||
<string name="drawer_upgrade_plus">Upgrade to Mail Plus</string>
|
||||
</resources>
|
||||
|
||||
Reference in New Issue
Block a user