Commit Graph
3215 Commits
Author SHA1 Message Date
Cyrus Najmabadi f459951431 Merge branch 'diagnostics' into sourceFileUpdate
Conflicts:
	src/compiler/parser.ts
2014-12-16 23:48:00 -08:00
Cyrus Najmabadi 2748a5b163 Remove 'grammarDiagnostics' from SourceFile. 2014-12-16 23:00:14 -08:00
Cyrus Najmabadi cd308e78ba Merge branch 'master' into sourceFileUpdate
Conflicts:
	src/compiler/checker.ts
	src/compiler/diagnosticInformationMap.generated.ts
	src/compiler/parser.ts
	tests/baselines/reference/FunctionDeclaration5_es6.errors.txt
	tests/baselines/reference/VariableDeclaration2_es6.errors.txt
	tests/baselines/reference/VariableDeclaration4_es6.errors.txt
	tests/baselines/reference/anonymousModules.errors.txt
	tests/baselines/reference/callSignaturesWithParameterInitializers2.errors.txt
	tests/baselines/reference/conflictMarkerTrivia1.errors.txt
	tests/baselines/reference/dottedModuleName.errors.txt
	tests/baselines/reference/innerModExport1.errors.txt
	tests/baselines/reference/innerModExport2.errors.txt
	tests/baselines/reference/parserAccessors10.errors.txt
	tests/baselines/reference/parserComputedPropertyName5.errors.txt
	tests/baselines/reference/parserErrantEqualsGreaterThanAfterFunction1.errors.txt
	tests/baselines/reference/parserErrantEqualsGreaterThanAfterFunction2.errors.txt
	tests/baselines/reference/parserModifierOnStatementInBlock2.errors.txt
	tests/baselines/reference/parserSkippedTokens16.errors.txt
	tests/baselines/reference/privateIndexer2.errors.txt
2014-12-16 21:50:10 -08:00
CyrusNajmabadi 1776734e66 Merge pull request #1423 from Microsoft/refactorGrammarCheck
Move grammar checking code into the type checker.
2014-12-16 20:59:55 -08:00
Cyrus Najmabadi 99a189936f Remove last vestiges of the grammar checker from the parser now that it has been entirely moved to the TypeChecker. 2014-12-16 19:59:16 -08:00
Yui T c2b03b6384 Address code review 2014-12-16 19:53:42 -08:00
Yui T 9c9bd34352 Address code review 2014-12-16 19:49:40 -08:00
Yui T d7f607234a COMPLETE migrating grammar checking; No more errors 2014-12-16 19:30:08 -08:00
Yui T fdfd8d4863 Cleaning up migrating grammar checking 2014-12-16 19:11:07 -08:00
Cyrus Najmabadi 908d4f61e6 Provide a stronger type for the parent of a variable declaration. 2014-12-16 18:54:21 -08:00
Cyrus Najmabadi 7f893f9b9a Rename method to be clearer. 2014-12-16 18:50:34 -08:00
Cyrus Najmabadi 9df59c39ee Change TextChangeRange to be a record type as well. 2014-12-16 18:40:15 -08:00
Cyrus Najmabadi 7f3a73b7c8 Change 'TextSpan' to be a simple record type with free floating functions. 2014-12-16 18:31:06 -08:00
Yui T 9ab59a4964 Merge branch 'master' into refactorGrammarCheck
Conflicts:
	src/compiler/diagnosticInformationMap.generated.ts
	src/compiler/diagnosticMessages.json
	src/compiler/parser.ts
	src/compiler/types.ts
	tests/baselines/reference/YieldExpression8_es6.errors.txt
	tests/baselines/reference/ambientErrors.errors.txt
	tests/baselines/reference/giant.errors.txt
2014-12-16 17:38:40 -08:00
Yui T 8dc9f751a3 Complete grammar checking migration; there are still errors which will be fixed once pull master into the branch 2014-12-16 17:32:15 -08:00
Cyrus Najmabadi dfb1ac0f00 Use constant in another place. 2014-12-16 17:14:45 -08:00
Cyrus Najmabadi fab4955ef7 Add explanatory comments. 2014-12-16 17:10:21 -08:00
Mohamed Hegazy cd7fc0c3fe Merge pull request #1495 from Microsoft/crashWhileReportingError
Do not use the file name in errors unless it exists
2014-12-16 16:56:01 -08:00
Mohamed Hegazy ab93b7d35d Merge pull request #1517 from Arnavion/exec-call-fail
Fail the surrounding Jake task if exec'd tool has non-zero exit code.
2014-12-16 16:54:15 -08:00
Cyrus Najmabadi 535f9d8972 Rename method to be clearer, and add comments to explain the semantics. 2014-12-16 16:36:49 -08:00
Cyrus Najmabadi 7fc343eb43 Fix broken enum value alignment. 2014-12-16 16:27:26 -08:00
Cyrus Najmabadi f3ce5d763c CR feedback. 2014-12-16 16:27:14 -08:00
Cyrus Najmabadi b73128c50f CR feedback. 2014-12-16 16:17:48 -08:00
Cyrus Najmabadi 97a6abcc07 CR feedback. 2014-12-16 16:12:14 -08:00
CyrusNajmabadi ffe5aa972c Merge pull request #1518 from Microsoft/sortCompilerBaselineDiagnostics
Sort diagnostics in our baseline output.
2014-12-16 16:11:58 -08:00
Cyrus Najmabadi f1a2e41a8a Sort diagnostics in our baseline output.
This was we don't get noisy baselines just because a different phase of the compiler reported
the diagnostic.

This helps with Yui's refactoring work to move grammar checks into the type checker.
2014-12-16 15:56:56 -08:00
Arnavion 8c76a4ebd3 Fail the surrounding Jake task if exec'd tool has non-zero exit code. 2014-12-16 15:28:36 -08:00
Yui T a3e8b6c6d7 Move grammar checking: interfaceDeclaration-remove it from checkModifiers in parser; there are still errors from incomplete grammar migration 2014-12-16 13:47:57 -08:00
Yui T 406576f1fc Move grammar checking: propertyDeclaration, propertySignature; there are still errors from incomplete grammar migration 2014-12-16 13:36:00 -08:00
Yui T c525877aaa Move grammar checking: moduleDeclaration; there are still errors from incomplete grammar migration 2014-12-16 13:35:31 -08:00
Yui T 003515655e Move grammar checking: methodDeclaration; there are still erros from incomplete grammar migration 2014-12-16 12:51:42 -08:00
Mohamed Hegazy adb0393458 Add internal definitions to a diffrent .d.ts files 2014-12-16 12:26:56 -08:00
Yui T 7a4d8cd8ee Move grammar checking: setAccessor, getAccessor; there are still erros from incomplete grammar migration 2014-12-16 12:25:05 -08:00
Cyrus Najmabadi 32729b1379 Merge branch 'master' into sourceFileUpdate 2014-12-16 12:03:21 -08:00
Cyrus Najmabadi c9ee88e5c4 Adding incremental test. 2014-12-16 11:58:47 -08:00
Mohamed Hegazy 5c4c08a667 Merge pull request #1500 from Arnavion/exec-process-stderr-number
Fixed "TypeError: invalid data" when executables run by exec exited with non-zero code.
2014-12-16 10:09:43 -08:00
Cyrus Najmabadi 0a8744e841 Add helper method to reduce so many double negatives in the code. 2014-12-16 03:19:13 -08:00
Cyrus Najmabadi 8917e96663 Merge branch 'funcDeclsInBlocks' into sourceFileUpdate
Conflicts:
	src/compiler/parser.ts
	src/compiler/utilities.ts
2014-12-16 03:12:31 -08:00
Cyrus Najmabadi 935ba82efd Don't check container invariants. They don't hold true in incremental scenarios. 2014-12-16 03:08:29 -08:00
Cyrus Najmabadi 6326b9d51f Merge branch 'master' into sourceFileUpdate 2014-12-16 02:59:05 -08:00
Cyrus Najmabadi 592ad476a8 Reduce unnecessary arrow function allocations. 2014-12-16 02:53:58 -08:00
Cyrus Najmabadi c7bb0a5ae6 Don't store variable statement flags on its variable declaration children. 2014-12-16 02:50:38 -08:00
Arnavion f042044fce Fixed "TypeError: invalid data" when executables run by exec exited with non-zero code.
The original error was because process.stderr only allows writing Strings or Buffers, but status is a Number.

Also, the message parameter of the "error" handler is just the amalgam of all output written to stderr. This is already logged by the "stderr" handler, so there's no need to write it to process.stderr again.
2014-12-16 02:45:17 -08:00
Vladimir Matveev 59c73c5f34 Merge pull request #1466 from Microsoft/linked_imports
defer decision whether import used on the right side of import declarati...
2014-12-16 00:46:26 -08:00
Vladimir Matveev 5b38cb9a69 harden 'get import declaration' logic 2014-12-16 00:34:51 -08:00
Yui T 694771b2d7 Move grammar checking: functionDeclaration; there are still errors from incomplet grammar migration 2014-12-15 23:05:29 -08:00
Cyrus Najmabadi fbcf9c89c6 Merge branch 'master' into funcDeclsInBlocks 2014-12-15 22:00:47 -08:00
CyrusNajmabadi 1eba8db465 Merge pull request #1498 from Microsoft/bindingElementContxt
Do not pass context flags downward while parsing binding elements.
2014-12-15 22:00:26 -08:00
Cyrus Najmabadi e8a1056a38 Merge branch 'bindingElementContxt' into funcDeclsInBlocks 2014-12-15 21:48:35 -08:00
Cyrus Najmabadi 30f9a5ca2a Do not pass context flags downward while parsing binding elements.
This prevents an unnecessary allocation, simplifies parsing code, and prevents
an issue where parsing depends on context flags not stored in the final tree.
This is an issue for incremental parsing that can lead to nodes being reused
inappropriately.
2014-12-15 21:41:02 -08:00