Commit Graph

3534 Commits

Author SHA1 Message Date
uniqueiniquity e5c43cddb7 Remove extra OutliningSpan and simplify regex 2017-09-15 16:47:59 -07:00
uniqueiniquity 484bd2082e Refactored out RegionRange 2017-09-15 16:15:32 -07:00
uniqueiniquity 3dfeb2d0f4 Combine and simplify regex 2017-09-15 15:52:08 -07:00
uniqueiniquity 7781245f1e Move RegionRange to private scope 2017-09-15 10:38:05 -07:00
uniqueiniquity c3f2648ba4 Edits from aozgaa review and simplify regex 2017-08-22 13:59:02 -07:00
uniqueiniquity 509d347ab9 Region now starts at beginning of comment, and reviewer edits 2017-08-22 12:59:47 -07:00
uniqueiniquity fb462c91a4 Ensure returned spans are ordered by start 2017-08-21 15:43:35 -07:00
uniqueiniquity 562d988614 Exclude region delimiters in multiline comments 2017-08-21 15:43:35 -07:00
uniqueiniquity 4971e3152c Ensure region boundaries are entire line 2017-08-21 15:43:35 -07:00
uniqueiniquity 0ef5498de3 Clean up unused functions 2017-08-21 15:43:35 -07:00
uniqueiniquity 0b3ec247bc Fix name capture logic 2017-08-21 15:43:35 -07:00
uniqueiniquity f91c23b25f Add regex sweep implementation 2017-08-21 15:43:35 -07:00
uniqueiniquity 9726ba1198 Add support for custom outlining regions 2017-08-21 15:43:35 -07:00
Andy 5e8e735db5 quickInfo: Don't check for type === undefined, check for any (#17815)
* quickInfo: Don't check for `type === undefined`, check for `any`

* Fixes:
* We still want to do some work even if type is `any`
* Second test for `if (type)` is necessary because it might not have been assigned.
2017-08-18 17:21:25 -07:00
Benjamin Lichtman 45c62ac0a6 Merge pull request #17709 from uniqueiniquity/objectsInArray
Correct outlining spans for object and array literals in array
2017-08-18 16:25:08 -07:00
uniqueiniquity e6c1afb4a0 Style changes and cleanup 2017-08-18 15:59:22 -07:00
Arthur Ozga a3d113bed3 Merge pull request #16385 from aozgaa/isInMultiLineComment
multi-line comment formatting fix and handler
2017-08-18 12:43:37 -07:00
Arthur Ozga e4e969a210 respond to comments 2017-08-17 20:06:46 -07:00
Andy babb88a0aa Remove duplicate function (#17807) 2017-08-17 06:52:15 -07:00
Daniel Rosenwasser a38da8af70 Merge pull request #17838 from Microsoft/rev2.6.0
Bump version to 2.6.0.
2017-08-16 23:50:50 -07:00
Arthur Ozga bc0c9a440e Merge branch 'master' into formattingAfterParseError 2017-08-16 20:27:06 -07:00
Arthur Ozga 6029b5cce8 cleanup 2017-08-16 18:12:28 -07:00
Arthur Ozga 19e2fa6fc5 Merge branch 'master' into isInMultiLineComment 2017-08-16 17:57:04 -07:00
Arthur Ozga b7bc7d889e clarify JsxText handling 2017-08-16 17:56:20 -07:00
Arthur Ozga 23ca368020 Use simpler indentation for comments
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.

Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Daniel Rosenwasser 3f50f20d0a Updated version in 'src' as well. 2017-08-16 14:49:44 -07:00
Arthur Ozga a08d18af57 consolidate isInComment and getRangeOfEnclosingComment 2017-08-15 12:09:43 -07:00
Arthur Ozga a209db7bb6 dont compute preceding token twice 2017-08-15 12:09:02 -07:00
Arthur Ozga f3e0cbbd52 findPrecedingToken handles EOF child more gracefully 2017-08-15 12:09:02 -07:00
Arthur Ozga 472ad9d313 findPrevious changes 2017-08-15 12:08:00 -07:00
Arthur Ozga b2188ad66c cleanup 2017-08-15 12:08:00 -07:00
Ryan Cavanaugh eb8f7bddc2 Merge pull request #17796 from basarat/patch-1
Fix build 🌹
2017-08-15 11:06:33 -07:00
Andy 10c8d5effa In services, show the aliasSymbol for a type even if it's not accessible in the current scope (#17433)
* In services, show the aliasSymbol for a type even if it's not accessible in the current scope

* Rename flag
2017-08-15 10:23:45 -07:00
Basarat Ali Syed c4dd820564 export interfaces used by exported functions 🌹 2017-08-15 15:19:40 +10:00
Basarat Ali Syed e7ddaa7d49 export ScopeUsages 🌹 2017-08-15 15:17:19 +10:00
uniqueiniquity 760812f714 Add explanatory comments, consolidate main body 2017-08-14 09:27:45 -07:00
Ron Buckton 09487b8a1d Added tests, pr feedback 2017-08-11 15:31:09 -07:00
Ron Buckton e3b6df64b3 Add support to infer the quote style for import quick fixes 2017-08-11 14:26:25 -07:00
Yui d352e3b03f [Master] fix 16407 - LS in binding element of object binding pattern (#16534)
* wip-try get symbol of bindingelement in objectBindingPattern first

* Add fourslash tests

* Update .types baselines

* Update .symbols baselines

* Revert checker changes

* Actually lookup type for binding property name definition

* More succinct check, clarify yui's comment
2017-08-11 11:14:59 -07:00
Ryan Cavanaugh c27ee81341 Merge branch 'master' into extract-method-2 2017-08-10 17:02:14 -07:00
Ryan Cavanaugh 24de14a9be Use isReadonlyArray 2017-08-10 16:40:08 -07:00
Ryan Cavanaugh db37cea0b6 Use the function stack! 2017-08-10 16:38:24 -07:00
Ryan Cavanaugh a04633c22c Style fixes 2017-08-10 16:35:32 -07:00
Ryan Cavanaugh f957429efd Style fixups 2017-08-10 16:23:17 -07:00
uniqueiniquity c7d691dc15 Generalize to nested arrays and refactor 2017-08-10 13:27:24 -07:00
Ryan Cavanaugh 12403d9f70 Various fixes 2017-08-10 13:07:42 -07:00
Arthur Ozga de92e98770 fix end-of-file assert failure 2017-08-10 10:01:42 -07:00
uniqueiniquity 1663d01844 Fix outlining of objects in array 2017-08-09 15:11:05 -07:00
Andy 17a6f7b56a Remove unused internal utilities (#17380)
* Remove unused internal utilities

* Handle undefined input to `mapDefined`
2017-08-09 14:37:59 -07:00
Wesley Wigham 6221d7089e Fix import addition location (#17327)
* Add test with bug

* Fix for import placement

* Consolidate comment recognition functions into utilities

* Add another test with all 3 kinds

* Recognize path directives as part of triple slash directives

* Also handle no-default-lib triple-slash comments

* Test for all the triple-slash kinds

* Keep import-placement logic in the quickfix, since its not really a node start; accept new baselines

* Work in not-ES6, use a real no-lib comment

* Remove no default lib triple slash comment, it disables checking and thereby quick fixes

* Copy regex rather than have a regex copy
2017-08-09 14:03:37 -07:00