Commit Graph

18963 Commits

Author SHA1 Message Date
uniqueiniquity e5c43cddb7 Remove extra OutliningSpan and simplify regex 2017-09-15 16:47:59 -07:00
uniqueiniquity 484bd2082e Refactored out RegionRange 2017-09-15 16:15:32 -07:00
uniqueiniquity 3dfeb2d0f4 Combine and simplify regex 2017-09-15 15:52:08 -07:00
uniqueiniquity 7781245f1e Move RegionRange to private scope 2017-09-15 10:38:05 -07:00
uniqueiniquity c3f2648ba4 Edits from aozgaa review and simplify regex 2017-08-22 13:59:02 -07:00
uniqueiniquity 509d347ab9 Region now starts at beginning of comment, and reviewer edits 2017-08-22 12:59:47 -07:00
uniqueiniquity 442bc56fc2 Add test for region spans 2017-08-21 15:43:35 -07:00
uniqueiniquity fb462c91a4 Ensure returned spans are ordered by start 2017-08-21 15:43:35 -07:00
uniqueiniquity 562d988614 Exclude region delimiters in multiline comments 2017-08-21 15:43:35 -07:00
uniqueiniquity 4971e3152c Ensure region boundaries are entire line 2017-08-21 15:43:35 -07:00
uniqueiniquity 0ef5498de3 Clean up unused functions 2017-08-21 15:43:35 -07:00
uniqueiniquity 0b3ec247bc Fix name capture logic 2017-08-21 15:43:35 -07:00
uniqueiniquity f91c23b25f Add regex sweep implementation 2017-08-21 15:43:35 -07:00
uniqueiniquity 9726ba1198 Add support for custom outlining regions 2017-08-21 15:43:35 -07:00
Andy 2b28916e5e Simplify resolveBaseTypesOfClass (#17918) 2017-08-21 11:34:53 -07:00
Mohamed Hegazy 07e1d3b13d Ensure string enums are generated in protocol.d.ts (#17914) 2017-08-21 09:44:03 -07:00
Andy 5e8e735db5 quickInfo: Don't check for type === undefined, check for any (#17815)
* quickInfo: Don't check for `type === undefined`, check for `any`

* Fixes:
* We still want to do some work even if type is `any`
* Second test for `if (type)` is necessary because it might not have been assigned.
2017-08-18 17:21:25 -07:00
Wesley Wigham a136f554a7 Fix stack overflow when resolving default construct signatures (#17878)
* Fix stack overflow when resolving default construct signatures

* No need for || emptyArray
2017-08-18 17:20:57 -07:00
Benjamin Lichtman 45c62ac0a6 Merge pull request #17709 from uniqueiniquity/objectsInArray
Correct outlining spans for object and array literals in array
2017-08-18 16:25:08 -07:00
uniqueiniquity e6c1afb4a0 Style changes and cleanup 2017-08-18 15:59:22 -07:00
Mohamed Hegazy a14aaf4772 Add release-2.5 to covered branches 2017-08-18 15:58:21 -07:00
Mohamed Hegazy 8e5e6c626b Update .npmignore (#17905) 2017-08-18 13:00:29 -07:00
Arthur Ozga a3d113bed3 Merge pull request #16385 from aozgaa/isInMultiLineComment
multi-line comment formatting fix and handler
2017-08-18 12:43:37 -07:00
Wesley Wigham ecd2ae8dac Deduplicate inputfiles before running RWC tests (#17877)
* Deduplicate inputfiles before running RWC tests

We deduplicate in the compiler, but we don't in the harness - this causes tests where the same file is listed multiple times in the arguments to not have the expected errors written, because we write out the same file multiple times when we should not.

* Don't completely omit both copied of duplicates

* Remove trailing whitespace

* Maintain list order while filtering duplicates

* Merge adjacent loops
2017-08-18 11:44:36 -07:00
Arthur Ozga 487ba21c14 Merge pull request #17903 from Microsoft/revert-17870-fix-getConstraintOfIndexedAccess
Revert "Fix getConstraintOfIndexedAccess"
2017-08-18 11:33:27 -07:00
Arthur Ozga 6b68da1185 Revert "Fix getConstraintOfIndexedAccess" 2017-08-18 11:32:53 -07:00
Arthur Ozga 439cdca52f Merge pull request #17870 from Microsoft/fix-getConstraintOfIndexedAccess
Fix getConstraintOfIndexedAccess
2017-08-18 11:32:48 -07:00
Andy ade3b565ae Revert public API changes to logger (#17899) 2017-08-18 11:20:07 -07:00
Arthur Ozga e4e969a210 respond to comments 2017-08-17 20:06:46 -07:00
Arthur Ozga e7d2af0d72 remove duplicate verify 2017-08-17 20:06:34 -07:00
Andy eef7d8bd3d Treat explicit imports from node_modules as external library imports (#16364)
* Treat explicit imports from `node_modules` as external library imports

* Update baselines
2017-08-17 13:26:38 -07:00
Nathan Shively-Sanders a187b17e97 Simplify mapped-type handling in computeBaseConstraint 2017-08-17 13:09:21 -07:00
Nathan Shively-Sanders 1b4f90705f Test getConstraintOfIndexedAccess fixes and update baselines 2017-08-17 12:45:20 -07:00
Nathan Shively-Sanders b8e0dedac0 Fix #17069 and #15371
1. `T[K]` now correctly produces `number` when
   `K extends string, T extends Record<K, number>`.
2. `T[K]` no longer allows any type to be assigned to it when
   `T extends object, K extends keyof T`.

Previously both of these cases failed in
getConstraintOfIndexedAccessType because both bases followed `K`'s base
constraint to `string` and then incorrectly produced `any` for types
(like `object`) with no string index signature. In (1), this produced an
error in checkBinaryLikeExpression`. In (2), this failed to produce an
error in `checkTypeRelatedTo`.
2017-08-17 12:40:10 -07:00
Andy babb88a0aa Remove duplicate function (#17807) 2017-08-17 06:52:15 -07:00
Daniel Rosenwasser 2729281a14 Merge pull request #17631 from Microsoft/synthesizedNamespaces
Always emit leading 'var' declarations for synthesized namespaces
2017-08-16 23:56:07 -07:00
Daniel Rosenwasser a38da8af70 Merge pull request #17838 from Microsoft/rev2.6.0
Bump version to 2.6.0.
2017-08-16 23:50:50 -07:00
Arthur Ozga 0d94d497df Merge pull request #16621 from aozgaa/formattingAfterParseError
Formatting after parse error
2017-08-16 20:49:29 -07:00
Arthur Ozga bc0c9a440e Merge branch 'master' into formattingAfterParseError 2017-08-16 20:27:06 -07:00
Arthur Ozga 760ef44c36 test if onlyMultiLine flag changes answer 2017-08-16 18:48:27 -07:00
Arthur Ozga 6029b5cce8 cleanup 2017-08-16 18:12:28 -07:00
Arthur Ozga 19e2fa6fc5 Merge branch 'master' into isInMultiLineComment 2017-08-16 17:57:04 -07:00
Arthur Ozga b7bc7d889e clarify JsxText handling 2017-08-16 17:56:20 -07:00
Arthur Ozga 23ca368020 Use simpler indentation for comments
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.

Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Arthur Ozga 62f16bee55 add tests 2017-08-16 17:36:50 -07:00
Arthur Ozga 4b9f5a0f8f rename tests 2017-08-16 17:36:39 -07:00
Arthur Ozga 70e4f346bb update test 2017-08-16 17:35:14 -07:00
Arthur Ozga 153b94aeb4 JsxText has no leading comments 2017-08-16 15:28:47 -07:00
Daniel Rosenwasser b7020628c1 Addressed code review feedback. 2017-08-16 15:06:51 -07:00
Daniel Rosenwasser 3f50f20d0a Updated version in 'src' as well. 2017-08-16 14:49:44 -07:00