Commit Graph

5428 Commits

Author SHA1 Message Date
Cyrus Najmabadi cf00a2bec8 Clean up comment. 2015-04-21 00:05:08 -07:00
Cyrus Najmabadi a93bf1048d Clean up comment. 2015-04-21 00:01:06 -07:00
Cyrus Najmabadi fac9ab2508 Clean up comment more. 2015-04-20 23:56:38 -07:00
Cyrus Najmabadi 93b7c33347 Remove unnecessary returns. 2015-04-20 23:54:05 -07:00
Cyrus Najmabadi b81a2c00ba Clean up comment. 2015-04-20 23:52:46 -07:00
Cyrus Najmabadi b1417d408d Clean up comment. 2015-04-20 23:47:42 -07:00
Cyrus Najmabadi 0a144e1806 Add explicit return to indicate the end of flow of a method.' 2015-04-20 23:44:33 -07:00
Cyrus Najmabadi d220b7ebb4 Add explanatory comments. 2015-04-20 23:43:54 -07:00
Cyrus Najmabadi 60d0b1444d CR feedback. 2015-04-20 23:34:19 -07:00
Cyrus Najmabadi 602c5c8fa9 Add explanatory comments. 2015-04-20 23:33:13 -07:00
Cyrus Najmabadi 33a74101b8 Split out the concerns of the binder even more.
Don't use SymbolFlags to direct how we handle containers in the binder.  Instead,
Just determine what we should do based on the .kind of the node itself, and nothing
more.
2015-04-20 23:28:16 -07:00
Cyrus Najmabadi 2e8e4a1f5c Add clarifying comments to the binder. 2015-04-20 02:24:47 -07:00
Cyrus Najmabadi aaf9371357 Add clarifying comments to binder. 2015-04-19 23:30:06 -07:00
Cyrus Najmabadi ee6c7dc0e4 Remove unnecessary check. Classes always have exports. 2015-04-19 23:23:44 -07:00
Cyrus Najmabadi e9a73e0cf8 Move code for creating a prototype out of the common declareSymbol codepath. 2015-04-19 23:20:04 -07:00
Cyrus Najmabadi 38bae98728 CR feedback. 2015-04-19 23:06:42 -07:00
Cyrus Najmabadi 4f8d68bb23 Use SymbolFlags.None in the binder. 2015-04-19 17:31:52 -07:00
Cyrus Najmabadi 221262314c Inline binder method. 2015-04-19 17:14:31 -07:00
Cyrus Najmabadi 4455995477 Move all symbol table initialization into the same method. 2015-04-19 17:09:17 -07:00
Cyrus Najmabadi 941128ba79 Clean up comments. 2015-04-19 17:02:49 -07:00
Cyrus Najmabadi db128252b0 Simplify code in the binder. 2015-04-19 16:57:44 -07:00
Cyrus Najmabadi ea7bafa9fb Remove unncessary postbind for function/constructor types. 2015-04-19 16:54:09 -07:00
Cyrus Najmabadi fab6fca5b4 Remove post bind step for modules. 2015-04-19 16:48:28 -07:00
Cyrus Najmabadi eb29eb9acd Remove code to post bind parameters. 2015-04-19 16:43:42 -07:00
Cyrus Najmabadi fb925ee4d1 Rename methods. 2015-04-19 16:39:09 -07:00
Cyrus Najmabadi 02640a397f Extract any complicated code in top level bind function to individual helpers. 2015-04-19 16:37:24 -07:00
Cyrus Najmabadi c5d920e912 Simplify recursion in the binder.
We now only recurse in a single place in the binder.  The rest of the binding
code is only concerned with how to bind a single node to a symbol and add that
symbol to a symbol table.  Recursion is handled as a separate concern, greatly
simplifying binder flow.
2015-04-19 16:23:56 -07:00
Cyrus Najmabadi 9043121188 Add a 'None' member to SymbolFlags enum. 2015-04-19 16:02:07 -07:00
Cyrus Najmabadi b75fda1052 Explicitly type 'bind' as being a void function. 2015-04-19 15:55:21 -07:00
Cyrus Najmabadi e7ddba508a Merge block container logic in the binder to use the same mechanism as SymbolFlags 2015-04-19 15:50:02 -07:00
Cyrus Najmabadi 9e64b45001 Add explanatory comments to the binder. 2015-04-19 14:57:35 -07:00
Cyrus Najmabadi 71d0f7affe Simplify concerns in the binder. 2015-04-19 14:46:01 -07:00
Cyrus Najmabadi 6478155aac Rename locals to more clearly indicate they are flags and not kinds. 2015-04-19 14:30:35 -07:00
Cyrus Najmabadi 14e925beb9 ConstructorType's name should be __call not __constructor. 2015-04-19 14:21:52 -07:00
Cyrus Najmabadi e5910af2c8 Always recurse into children in the binder in a uniform manner. 2015-04-19 14:15:49 -07:00
Dirk Bäumer 62b15de666 Merge pull request #2687 from dbaeumer/feature/fix2507
fixes #2507 - bad formatting for formatonkey if convertTabsToSpaces === false
2015-04-19 21:43:51 +02:00
Zhengbo Li fcc5ac02ad Merge pull request #2827 from zhengbli/master
Fix dom type "ArrayBufferView"
2015-04-18 12:47:24 -07:00
Daniel Rosenwasser 79dc0f96d3 Merge pull request #1546 from Arnavion/fix-emithost-this-binding
Don't lose the this reference for compilerHost methods.
2015-04-18 11:29:44 -07:00
Zhengbo Li 609be7628b Fix dom type "ArrayBufferView"
The dom type "ArrayBufferView" was emitteed as "any" because of a script
bug.
2015-04-18 00:12:27 -07:00
Mohamed Hegazy b8ebf561f9 Update LKG 2015-04-17 17:21:02 -07:00
Daniel Rosenwasser 62036758a8 Merge pull request #2809 from Microsoft/noReservedWordsInBindingPatterns
Disallow reserved words for object binding pattern names
2015-04-17 17:06:50 -07:00
Daniel Rosenwasser 4134d79999 numberic. 2015-04-17 16:50:38 -07:00
Daniel Rosenwasser dd9481996c word -> Word 2015-04-17 16:50:33 -07:00
Daniel Rosenwasser 23c76c3abb Removed unnecessary check since ShorthandPropertyAssignment's name is always an Identifier. 2015-04-17 16:50:00 -07:00
Mohamed Hegazy bf51a3410f Merge branch 'Smarp-amd-es3' 2015-04-17 15:59:08 -07:00
Mohamed Hegazy 7ad98770e1 Accept baselines 2015-04-17 15:53:36 -07:00
Mohamed Hegazy c68f837052 Merge branch 'amd-es3' of https://github.com/Smarp/TypeScript into Smarp-amd-es3 2015-04-17 15:39:23 -07:00
Jason Freeman f3c073e72d Merge pull request #2813 from Microsoft/lazyBaseTypes
Lazy base types
2015-04-17 14:31:17 -07:00
Jason Freeman c9d8c67ab6 Merge branch 'master' of https://github.com/Microsoft/TypeScript into lazyBaseTypes 2015-04-17 14:27:43 -07:00
Jason Freeman 47ccf77cea Address PR feedback 2015-04-17 14:27:31 -07:00