Commit Graph

25176 Commits

Author SHA1 Message Date
Andy bfc00935df Fix bug: Get mapped location of definition for findAllReferencesFull (#27113) 2018-09-17 14:14:55 -07:00
Nathan Shively-Sanders c9f190283e Fix non-toplevel prototype assignment (#27096)
* Fix non-toplevel prototype assignment

binder was using the wrong node to lookup the containing class type for
prototype assignment, so it incorrectly put the prototype declaration on
the class' symbol.

This correction to the binder in turn required a change in
getJSClassType in the checker. It now has to look at the "prototype"
property for the prototype instead of looking on the class symbol's exports
(which makes no sense).

* Refactor per PR suggestion
2018-09-17 13:07:05 -07:00
Nathan Shively-Sanders 989a717b04 Definite assignment checking for expando properties (#27128) 2018-09-17 12:56:39 -07:00
Andy e710645bf9 Never escape string literals from textChanges (#26971)
* Never escape string literals from textChanges

* Use `boolean | undefined`
2018-09-17 11:06:39 -07:00
Andy a57467a317 Fix bugs: Replace SourceFile if '--noUnusedLabels' changed (#27060)
* Fix bugs: Replace SourceFile if '--noUnusedLabels' changed

* Use properties on CommandLineOptionBase

* Handle "alwaysStrict" and better categorize options

* Properly handle "strict"

* Code review

* fix test
2018-09-17 10:53:48 -07:00
csigs c615718c3d LEGO: Merge pull request 27145
LEGO: Merge pull request 27145
2018-09-17 09:10:51 -07:00
csigs 7cc7710503 LEGO: check in for master to temporary branch. 2018-09-17 16:10:23 +00:00
Nathan Shively-Sanders 394ee31a56 Fix cross-file merge of assignment decl valueDeclaration (#26918)
* Fix cross-file merge of assignment decl valueDeclaration

Previously mergeSymbol in the checker always updated valueDeclaration if
target.valueDeclaration was an assignment declaration. The binder only
updates target.valueDeclaration if it is an assignment declaration and
source.valueDeclaration is *not* an assignment declaration. Now the
checker behaves the same way as the binder.

* Update baselines

* Add a fix for #27099

Makes commonjs merge with globals when appropriate.

* Add a separate jsGlobalAugmentations table

Instead of trying to filter these augmentations out of the normal symbol
table of commonjs modules.
2018-09-16 07:46:03 -07:00
Benjamin Lichtman 70ce7abe12 Merge pull request #27109 from uniqueiniquity/diagnosticLocation
Report async code fix diagnostic on name whenever it exists
2018-09-15 18:36:42 -07:00
Wesley Wigham 921863eb31 Use head message at top level of elaboration if elaborating via possible call (#27107)
* Use head message at top level of elaboration if elaborating via possible call

* Accept updated baseline
2018-09-15 13:24:22 -07:00
Sheetal Nandi e4718564e5 Merge pull request #27082 from Microsoft/watchAPIAndProjectReferences
Fix tsc watch and watch API for a project that has project references
2018-09-14 17:58:42 -07:00
Sheetal Nandi 1d22e03db0 Merge pull request #27100 from Microsoft/revertResolveProjectReferencePathAPIChange
Revert the API change to resolveProjectReferencePath introduced in #27062
2018-09-14 17:58:09 -07:00
Benjamin Lichtman 32cb9ece8b Add test 2018-09-14 17:20:46 -07:00
Benjamin Lichtman 9e1a05c9ec Handle function assigned to binding pattern 2018-09-14 17:20:41 -07:00
Benjamin Lichtman 853afd9d56 Add test 2018-09-14 16:34:17 -07:00
Benjamin Lichtman 2c881fd90a Report diagnostic on expression name if it exists 2018-09-14 16:34:16 -07:00
Wesley Wigham 359930a677 Use qutemarks around new instead of ticks around new in diagnostic (#27106)
* Use qutemarks around new instead of ticks

* Accept baselines
2018-09-14 15:57:24 -07:00
Wesley Wigham 20eafb5b74 Introduce boolean literal freshness (#27042) 2018-09-14 15:00:09 -07:00
Wesley Wigham 4eb59a2d77 Fixing react defaultize+generic default props interaction (#27088)
* Add repro for fixed issue

* Fix JSX propagating flags and contextual types

* Accept slightly changed baselines

* Add modern react.d.ts and regression test
2018-09-14 14:18:47 -07:00
Sheetal Nandi d6ffdde059 Revert the API change to resolveProjectReferencePath introduced in #27062 2018-09-14 13:32:23 -07:00
Sheetal Nandi c63d58148a Fix the usage of createProgram in tsc 2018-09-14 12:44:02 -07:00
Benjamin Lichtman bce34ada8f Merge pull request #27031 from uniqueiniquity/asyncCatchUniqueNames
Ensure async code fix renaming can do more than one rename
2018-09-14 11:13:00 -07:00
Sheetal Nandi 20f671ede2 PR feedback 2018-09-14 11:07:22 -07:00
Sheetal Nandi 40d33c809a Merge branch 'master' into watchAPIAndProjectReferences 2018-09-14 10:54:07 -07:00
Sheetal Nandi e547cdf8e3 Merge pull request #27078 from Microsoft/commonCompilerOptionsWithBuild
Parse selected command line options with build and use them as base for solution building
2018-09-14 10:10:06 -07:00
Sheetal Nandi ebb89ba50c Merge branch 'master' into commonCompilerOptionsWithBuild 2018-09-14 10:08:34 -07:00
Sheetal Nandi 513a16264b Make parseCommandLineWorker non generic 2018-09-14 10:05:14 -07:00
Sheetal Nandi 47f311ac03 Merge pull request #27062 from Microsoft/tsbuildWatchImprovements
Multiple improvements to watching with --build option
2018-09-14 09:54:17 -07:00
Benjamin Lichtman 0e985eb342 Merge branch 'master' into asyncCatchUniqueNames 2018-09-14 09:50:27 -07:00
Sheetal Nandi b5639786bd Merge pull request #26135 from Microsoft/watchDirectoryOfNodeModulesScriptInfo
Instead of watching individual script infos, watch the node modules folder for script infos in node modules
2018-09-14 09:49:41 -07:00
Benjamin Lichtman 98055ad540 Use separate map with smaller scope to track renames 2018-09-14 09:46:58 -07:00
Benjamin Lichtman 13deedf841 Merge pull request #26930 from uniqueiniquity/onlyReportExpectedPromiseArgs
Only perform async code fix if it can successfully refactor all parts
2018-09-14 09:41:34 -07:00
Andy 95c1570c4b Fix bug: VariableDeclaration may have SemanticMeaning.All if an @enum in JS (#27085) 2018-09-14 09:20:54 -07:00
Andy 009dc0f1b9 For completion in string literal union, don't include strings already in the union (#26755) 2018-09-14 09:20:11 -07:00
Benjamin Lichtman 57a6dbd6fa Add clarifying comments 2018-09-14 08:50:18 -07:00
Andy ee7d0e21da getEditsForFileRename: Don't resolve to a.js when a.ts is moved (#27081) 2018-09-13 15:49:42 -07:00
Andy f71d6005a2 Use nextToken() after parsing a tag name so we can parse type keywords (#26915)
* Use nextToken() after parsing a tag name so we can parse type keywords

* Make callback to skipWhitespaceOrAsterisk non-optional
2018-09-13 15:49:06 -07:00
Sheetal Nandi ea67e3ac56 Fix watch of project with project references 2018-09-13 15:41:07 -07:00
Andy ebfcc1b52d Fix bug: Ignore @enum tag in TS (#27076) 2018-09-13 15:24:49 -07:00
Nathan Shively-Sanders 64d0e0d448 Shorten more internal names to JS or TS (#27080) 2018-09-13 15:05:57 -07:00
Dan Rollo 2b0e9e686b typo: missing word: "to" (#27079)
Change:
...a resolve callback used resolve the promise...
to: 
...a resolve callback used to resolve the promise...

This PR suggested from: https://github.com/Microsoft/TypeScript/pull/27075
2018-09-13 14:23:56 -07:00
Sheetal Nandi e2edb69638 Instead of watching individual script infos, watch the node modules folder for script infos in node modules 2018-09-13 13:48:48 -07:00
Sheetal Nandi 4ed63e52ef Add test for preserveWatchOutput on command line
#26873
2018-09-13 13:04:38 -07:00
Andy 1a69f78fba Fix bug: Ensure export = symbol always has a valueDeclaration (#26973) 2018-09-13 12:53:46 -07:00
Sheetal Nandi 4cf746cdc4 Enable listFiles and listEmittedFiles as build option 2018-09-13 11:17:03 -07:00
Sheetal Nandi 0d60348e45 Unify the commandline parsing worker 2018-09-13 10:30:45 -07:00
Sheetal Nandi 37c3c5d8bb Refactoring 2018-09-13 10:04:52 -07:00
Benjamin Lichtman e700022cef Remove unnecessary case 2018-09-13 09:46:40 -07:00
Benjamin Lichtman d12110d3e5 Respond to CR 2018-09-13 09:32:38 -07:00
Benjamin Lichtman 504b5f2985 Add and update tests 2018-09-13 09:04:52 -07:00