Commit Graph
24450 Commits
Author SHA1 Message Date
Anders HejlsbergandMohamed Hegazy bac5f90af1 Properly handle all generic kinds of types in rest positions 2018-07-20 15:38:30 -07:00
Daniel RosenwasserandGitHub 5ed76973ed Merge pull request #25781 from Microsoft/objectsAgainstArrays-3.0
[release 3.0] Avoid elaborating object literals against array-likes
2018-07-19 08:07:26 -07:00
Daniel Rosenwasser 11284e7a98 Accepted baselines. 2018-07-18 15:33:00 -07:00
Daniel Rosenwasser f49679fff1 Elaborate on the first non-array type when object literals are compared against 'T | T[]'. 2018-07-18 15:31:32 -07:00
Daniel Rosenwasser 9d23080b58 Added test. 2018-07-18 15:31:16 -07:00
AndyandGitHub 33df18de0c Consistently use ScriptInfo for converting positions to Locations (#25623) (#25777)
* Consistently use ScriptInfo for converting positions to Locations

* Code review
2018-07-18 14:49:06 -07:00
AndyandGitHub 53d240015c Don't bother trying to get the name of a default export (#25773) (#25776)
* Don't bother trying to get the name of a default export

* Fix lint
2018-07-18 12:23:57 -07:00
AndyandGitHub 83b29eddd7 Fix formatting at trailing comma (#25706) (#25743) 2018-07-17 17:05:49 -07:00
Mohamed Hegazy a3c6c717cd Update LKG 2018-07-16 14:19:45 -07:00
Mohamed HegazyandGitHub d71415a5e0 Merge pull request #25702 from Microsoft/mergeMaster-7-16
Merge master into release-3.0
2018-07-16 13:43:52 -07:00
Mohamed Hegazy 39a7891dc8 Merge branch 'master' into release-3.0 2018-07-16 13:18:08 -07:00
Mohamed HegazyandGitHub 75930f87fe Merge pull request #25699 from Microsoft/revert-explicitly-typed-special-assignments
Revert explicitly typed special assignments
2018-07-16 13:15:06 -07:00
Mohamed HegazyandGitHub d690835cb9 Merge pull request #25698 from Microsoft/navigationBarUnrelatedGrandchildren
navigationBar: Don't merge unrelated grandchildren
2018-07-16 13:02:35 -07:00
Nathan Shively-Sanders 16676f2707 Revert "Explicitly typed special assignments are context sensitive (#25619)"
This reverts commit 32e60a9647.
2018-07-16 12:39:08 -07:00
Andy Hanson 1038c76f88 navigationBar: Don't merge unrelated grandchildren 2018-07-16 12:38:38 -07:00
Nathan Shively-Sanders ff8c30d636 Revert "Explicitly typed prototype assignments are context sensitive (#25688)"
This reverts commit 5b21cbc0c9.
2018-07-16 12:38:27 -07:00
Daniel RosenwasserandGitHub 93ab352189 Merge pull request #25565 from Microsoft/popFirst
Make 'pop' the first method that uses 'T' in 'Array'
2018-07-16 11:41:44 -07:00
AndyandGitHub afdd47c9ce Simplify rules for isControlFlowEndingStatement (#25693) 2018-07-16 11:17:46 -07:00
Mohamed HegazyandGitHub 8ef146e658 Merge pull request #25656 from j-oliveras/Fix_25653
Change jsDocTagNames to lower case.
2018-07-16 10:18:12 -07:00
Nathan Shively-SandersandGitHub 5b21cbc0c9 Explicitly typed prototype assignments are context sensitive (#25688)
* Explicitly typed prototype assignments:ctx sensitive

Follow up to #25619: Add the necessary code to type `prototype`
correctly in prototype assignments so that code like
`F.prototype = { ... }` properly makes the object literal context
sensitive.

* Fix lint
2018-07-16 10:03:39 -07:00
Daniel RosenwasserandGitHub 60986adee5 Merge pull request #25507 from ajafff/leftmost-expr-tagged-template
getLeftmostExpression: handle TaggedTemplateExpression
2018-07-13 23:56:32 -07:00
AndyandGitHub e25a23bb3c Fix Buffer.from uses to handle node 5.4.1 bug (#25659) 2018-07-13 17:08:25 -07:00
Sheetal NandiandGitHub 7ad4fcf121 Merge pull request #25649 from Microsoft/jsonFilesOnCommandLine
Support resolveJsonModule option when files contain the json file
2018-07-13 16:24:42 -07:00
Jordi Oliveras Rovira 4f411a8cce Change jsDocTagNames to lower case. 2018-07-14 01:02:20 +02:00
Sheetal Nandi 49ac60f286 Support resolveJsonModule option when files contain the json file
Fixes #25636
2018-07-13 12:21:51 -07:00
Sheetal NandiandGitHub 47e513e151 Merge pull request #25627 from Microsoft/preserveOutputInConfig
Fix incorrect handling of preserveWatchOutput flag is in config file
2018-07-13 10:56:53 -07:00
AndyandGitHub 3f4412b173 getContainingList: Handle TypeAliasDeclaration (#25614)
* getContainingList: Handle TypeAliasDeclaration

* Handle ClassExpression and InterfaceDeclaration
2018-07-13 10:30:22 -07:00
AndyandGitHub 27da9eab8d fixUnreachableCode: Don't delete whole block when non-first line is unreachable (#25625) 2018-07-13 09:57:04 -07:00
AndyandGitHub 88c6ced3c6 indentMultilineCommentOrJsxText: Fix bug when 'parts' is empty (#25645) 2018-07-13 09:56:21 -07:00
Sheetal Nandi ca083809a4 Fix incorrect handling of preserveWatchOutput flag is in config file
Fixes #25620
2018-07-12 18:29:02 -07:00
AndyandGitHub 1fb050bcca Don't report unused diagnostics when the unused node has a parse error (#25598)
* Don't report unused diagnostics when the unused node has a parse error

* Update test
2018-07-12 17:24:59 -07:00
Nathan Shively-SandersandGitHub 32e60a9647 Explicitly typed special assignments are context sensitive (#25619)
* Explicitly typed js assignments: context sensitive

Explicitly typed special assignments should be context sensitive if they
have an explicit type tag. Previously no special assignments were
context sensitive because they are declarations, and in the common,
untyped, case we inspect the right side of the assignment to get the
type of the left side, and inspect the right side of the assignment to
get the type of the left side, etc etc.

Note that some special assignments still return `any` from
checkExpression, so still don't get the right type.

Fixes #25571

* Change prototype property handling+update bselines

* Fix indentation in test

* Update baselines
2018-07-12 15:28:53 -07:00
AndyandGitHub f500289a44 Stricter test that JSDoc @type tag matches function signature (#25615) 2018-07-12 14:02:02 -07:00
Ryan CavanaughandGitHub 6a2ffec53d Merge pull request #25610 from RyanCavanaugh/buildOnWatchStartup
When running with -w, do an initial compilation
2018-07-12 12:51:16 -07:00
Mohamed Hegazy 07174788a9 Update LKG 2018-07-12 12:29:45 -07:00
Mohamed Hegazy 979327f23d Merge branch 'master' into release-3.0 2018-07-12 12:26:43 -07:00
Mohamed HegazyandGitHub 9e604f7d36 Merge pull request #25611 from Microsoft/mergeMaster7-12
Merge master into release-3.0
2018-07-12 12:25:51 -07:00
Anders HejlsbergandGitHub 0f8b6fcd27 Merge pull request #25608 from Microsoft/genericRestArityCheck
Fix generic rest parameter arity checks
2018-07-12 09:09:31 -10:00
AndyandGitHub af412e39cf mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change (#25586)
*  mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change

* Can't use `program.getSourceFile()` to determine file existence when multiple projects exist

* Use direct union instead of discriminated union
2018-07-12 12:09:04 -07:00
Mohamed Hegazy f4e74d15f5 Update version to 3.0.1 2018-07-12 11:39:46 -07:00
Mohamed Hegazy a6b02f2631 Merge branch 'master' into mergeMaster7-12 2018-07-12 11:31:45 -07:00
Mohamed HegazyandGitHub d5f4da6ebb Merge pull request #25572 from Microsoft/mergeMaster7-10
Merge master into release-3.0
2018-07-12 11:30:41 -07:00
AndyandGitHub f9764d17f0 fixUnusedIdentifier: Support deleting @template tag (#25597)
* fixUnusedIdentifier: Support deleting @template tag

* Just return createTextRangeFromNode instead of adjusting range
2018-07-12 11:26:17 -07:00
Anders Hejlsberg 5822a8c923 Merge branch 'master' into genericRestArityCheck
# Conflicts:
#	src/compiler/checker.ts
2018-07-12 08:20:48 -10:00
Nathan Shively-SandersandGitHub bd7b97ce61 Get return type from @type tag (#25580)
* Get return type from `@type` tag

This only happens in the checker, where the type is easily accessible.
The syntax-based check in getEffectiveReturnTypeNode as a fast path, and
for other uses that don't want to make a call to getTypeFromTypeNode.

Fixes #25525

* Implement PR suggestions

* Error when type tag isn't callable

* Fix lint
2018-07-12 10:49:41 -07:00
Ryan Cavanaugh 08d7b8fd10 When running with -w, do an initial compilation 2018-07-12 10:36:58 -07:00
Anders Hejlsberg e88f63295b Accept new baselines 2018-07-12 07:07:23 -10:00
Anders Hejlsberg 55180f7725 Add tests 2018-07-12 07:07:13 -10:00
Anders Hejlsberg 87ad612e70 Additional arity check following instantiation of generic rest parameter 2018-07-11 17:26:35 -10:00
rflorianandNathan Shively-Sanders 66e9aaac18 Issue 19220 function parameter arity (#24031)
* Added reference test case and diagnostics message

* Adjusted arity checks to account for non-contiguous overloads

* Code cleanup, baseline not yet commited

* Accepted test baselines and minor implementation changes

* Cleaned up baseline tracking the now renamed arity check test

* Add range response when range contains only 2 values

* Added recent baseline

* Refined arity error messages when available overloads can be grouped

* Rolled back code formatting

* WIP cleanup needed in a few edge cases

* Finished adding new more descriptive error messages

* Code cleanup

* Added simplified version of bugfix for #19220

* Rebased onto master

* Removed whitespace after type assertion

* Code review simplifications

* Use correct diagnostic name

* Code review changes and simplification of diagnostic message

* Revert formatting changes
2018-07-11 17:19:56 -07:00