Nathan Shively-Sanders
b185784708
Only functions can be constructor functions ( #27369 )
...
`@constructor` put on anything incorrectly makes it a JS constructor. This
is a problem for actual constructors, because getJSClassType doesn't
work on actual classes. The fix is to make isJSConstructor require that
its declaration is a function.
2018-10-08 10:14:31 -07:00
Nathan Shively-Sanders
a4a5b3806e
Report circular JSDoc type references ( #27404 )
...
JSDoc types references can often be to values, which can often be
circular in ways that types tied to declarations cannot. I decided to
create a separate property on SymbolLinks rather than reusing
declaredType, although I'm not sure that's strictly required.
2018-10-08 08:56:29 -07:00
Ron Buckton
85a3475df8
Merge pull request #26707 from mprobst/async-super-rename-safe
...
Per-property super accessors in async functions.
2018-10-05 17:20:21 -07:00
Wesley Wigham
6175e60fec
Formatting a union should not create a 1-element union type node ( #27582 )
2018-10-05 16:11:47 -07:00
Wesley Wigham
07dbd8be21
Discriminate jsx contextual types same as object contextual types ( #27408 )
...
* Discriminate jsx contextual types same as object contextual types
* Extract core discrimination algorithm to getDiscriminationResultForProperty
* Merge all discrimination implementations
* Fix lints
2018-10-05 15:11:12 -07:00
Wesley Wigham
a7b4635446
Add object check to justify cast ( #27576 )
2018-10-05 14:40:23 -07:00
Wesley Wigham
4ad6541646
Store and check deferred nodes by containing file ( #27378 )
2018-10-05 14:40:09 -07:00
Nathan Shively-Sanders
c080324974
Elt access assignment uses declared, not narrowed type ( #27574 )
...
I forgot to do this in #26424 .
Fixes #27557
Fixes #27412
2018-10-05 11:30:10 -07:00
Wesley Wigham
e1d346ea53
Infer tuples for jsx children if contextually typed by a tuple ( #27409 )
2018-10-04 17:56:38 -07:00
Andy
deeb40129d
Remove duplicate case in parseJsDocCommentWorker ( #27164 )
2018-10-04 15:44:01 -07:00
Wesley Wigham
10edf6fa58
Widen export assignment types so they arent accidentally fresh ( #27397 )
2018-10-04 14:27:19 -07:00
Nathan Shively-Sanders
04266aa617
narrowTypeByInstanceof understands ctor funcs ( #27551 )
...
* narrowTypeByInstanceof understands ctor funcs
* Rename test filename
* Fix whitespace lint
2018-10-04 13:52:38 -07:00
Wesley Wigham
f07404938f
Replace subtype check in derivedness check with flags and structure checks ( #27403 )
...
* Replace subtype check in derivedness check with flags and structure checks
* Remove now extraneous clause
2018-10-04 12:55:39 -07:00
Ron Buckton
a36e6e3976
Merge pull request #27410 from Microsoft/freeUpTransformFlags
...
Free up space in the TransformFlags enum
2018-10-03 12:39:09 -07:00
Andy
9bdd6a3b55
Support loading "index.d.ts" using "typesVersions" without "types", "typings", or "main" ( #27514 )
...
* Support loading "index.d.ts" using "typesVersions" without "types", "typings", or "main"
* Update baseline
2018-10-03 11:44:16 -07:00
Anders Hejlsberg
81f8b47e5f
Merge pull request #27370 from Microsoft/fixInstanceOfFunction
...
Fix instanceof with type Function for right argument
2018-10-03 10:59:50 -07:00
Anders Hejlsberg
9851d6f457
Merge pull request #27490 from Microsoft/indexedAccessConstraint
...
Limit unsound indexed access type relations
2018-10-03 10:58:45 -07:00
Martin Probst
e58ffcf509
fix comments
2018-10-03 15:46:04 +02:00
Martin Probst
e618d752b6
Fixes for review comments.
...
* rename _super to _superIndex and _superProps to _super.
* reinstate early exit for transformers by marking super accesses as
esnext/es2017 in `binder.ts`.
* adjust comment in `checker.ts` to new emit.
2018-10-03 15:46:04 +02:00
Martin Probst
f0826cfeaa
Per-property super accessors in async functions.
...
TypeScript must hoist accessors for super properties when converting
async method bodies to the `__awaiter` pattern for targets before
ES2016.
Previously, TypeScript would reify all property accesses into element
accesses, i.e. convert the property name into a string parameter and
pass it to `super[...]`. That breaks optimizers like Closure Compiler or
Uglify in advanced mode, when property renaming is enabled, as it mixes
quoted and un-quoted property access (`super['x']` vs just `x` at the
declaration site).
This change creates a variable `_superProps` that contains accessors for
each property accessed on super within the async method. This allows
accessing the properties by name (instead of quoted string), which fixes
the quoted/unquoted confusion. The change keeps the generic accessor for
element access statements to match quoting behaviour.
Fixes #21088 .
2018-10-03 15:46:04 +02:00
Brandon Banks
804a2fd66a
fix typo in performance mark name
2018-10-02 22:52:17 -04:00
Ryan Cavanaugh
5f96fb13b2
Merge pull request #27313 from spratmannc/spratmannc/fixing-extends-helper
...
adding missing semi-colon to extendsHelper
2018-10-02 12:06:04 -07:00
Wesley Wigham
1e55d650f3
Exclude the overlap between Type and Value when checking for parameter visibility ( #27444 )
2018-10-02 09:41:06 -07:00
Anders Hejlsberg
c0c215fb66
No unsound assignments to T[K] when T and K are both generic
2018-10-01 16:20:15 -07:00
Ryan Cavanaugh
70e26fc701
Merge pull request #27447 from mattmccutchen/issue-27117
...
Don't complain about `modules` and `outFile` options when `emitDeclarationOnly` is set.
2018-10-01 15:50:08 -07:00
Sheetal Nandi
6e8027e95e
Merge pull request #27395 from Microsoft/noFilesError
...
Refactoring to unify updating no input files error
2018-10-01 15:03:44 -07:00
Ryan Cavanaugh
3331d073c4
Merge pull request #26070 from ajafff/tuple-rest
...
Infer array rest as tuple if possible
2018-10-01 13:56:28 -07:00
Sheetal Nandi
d2647a1dda
Merge pull request #27483 from Microsoft/redirects
...
Fix issue of program not being reused when host implements getSourceFileByPath
2018-10-01 12:46:59 -07:00
Andy
8feddcd16d
Clean up amalgamatedDuplicates ( #27285 )
...
* Clean up amalgamatedDuplicates
* Code review
2018-10-01 12:16:49 -07:00
Andy
115636bb93
Minor cleanup in bindNamespaceExportDeclaration ( #27367 )
...
* Minor cleanup in bindNamespaceExportDeclaration
* Change formatting
2018-10-01 12:15:10 -07:00
Sheetal Nandi
bc23037e14
Merge pull request #27438 from Microsoft/failedLookupNotMatchingPath
...
Handle the case of failed lookup location being not normalized in resolutionCache to watch the path
2018-10-01 11:57:34 -07:00
Sheetal Nandi
1c2f2555ec
Add resolvedPath and originalFileName to redirected file
...
Fixes #27207
2018-10-01 11:51:45 -07:00
Matt McCutchen
32e75e7ae7
Don't complain about modules and outFile options when
...
`emitDeclarationOnly` is set.
Fixes #27117 .
2018-09-28 21:07:48 -04:00
Sheetal Nandi
ee04b8c7f3
Handle the case of failed lookup location being not normalized.
...
Also fixed issue where type defs with relative name didnt resolve when directoryExists is present on the host
Fixes #27405
2018-09-28 14:40:34 -07:00
Sheetal Nandi
0245c2d35e
Only copy non error values in array when converting the json
...
Fixes #27432
2018-09-28 13:49:00 -07:00
Nathan Shively-Sanders
21148b3b0a
Fix typo in PseudoPragma* types ( #27437 )
2018-09-28 10:39:30 -07:00
Nathan Shively-Sanders
6d92a2942f
Fix parent points in unreachable code ( #27400 ) ( #27406 )
...
In the binder, unreachable code mistakenly skips the `bindJSDoc` call in
`bindChildrenWorker`, which sets parent pointers. The fix is to call
`bindJSDoc` in the case of unreachable code as well.
2018-09-28 08:31:56 -07:00
Andy
19af881f94
ExpressionWithTypeArguments parent may be a JSDocAugmentsTag ( #27229 )
2018-09-27 18:26:57 -07:00
Ron Buckton
d224ee02d7
Free up space in the TransformFlags enum
2018-09-27 17:55:07 -07:00
Wesley Wigham
26eb6ab6f4
Primitives should not be instanceof... anything ( #27402 )
2018-09-27 15:49:51 -07:00
Ron Buckton
9cf201c512
Merge pull request #27204 from Microsoft/fixPerIteration
...
Fix per-iteration bindings in for-loop head
2018-09-27 13:23:03 -07:00
Wesley Wigham
7bf382e73f
Allow empty files lists in tsconfigs with an extends member ( #27383 )
2018-09-27 12:40:29 -07:00
Sheetal Nandi
aed876dfb4
Refactoring to unify updating no input files error
2018-09-27 11:58:15 -07:00
Anders Hejlsberg
d7219b21c2
Merge pull request #27357 from Microsoft/fixBivariantInferences
...
Make contravariant inferences only from pure contravariant positions
2018-09-26 14:03:59 -07:00
Nathan Shively-Sanders
98ec1e8730
Fix commonjs export= merging ( #27368 ) ( #27371 )
...
I'm surprised we haven't seen more of this; I suspect it's because the
mixed `module.exports=` + `export.foo=` pattern isn't that common.
However, it'll happen any time that the exported symbol is unknown;
getCommonJsExportEquals blithely clones unknownSymbol and proceeds to
stick the `exports.foo=` properties onto it.
This causes problems later, because the compiler checks for
unknownSymbol with `===`. The fix is to not stick properties onto a
clone of unknownSymbol. This makes the correct errors appear and removes
the crash.
2018-09-26 12:40:30 -07:00
Sheetal Nandi
1a63c67e8a
Merge pull request #27260 from valera-rozuvan/fix-27086
...
Fix 27086. Ignore directories starting with a dot.
2018-09-26 11:11:37 -07:00
Anders Hejlsberg
34b35df086
Merge branch 'master' into fixInstanceOfFunction
2018-09-26 10:51:58 -07:00
Nathan Shively-Sanders
4fac5f26dc
Fix crash in use-before-def checking of enum tag ( #27350 ) ( #27354 )
2018-09-26 09:05:18 -07:00
Anders Hejlsberg
f59229bf22
Only add unique inferences to candidate arrays
2018-09-26 06:54:37 -07:00
Anders Hejlsberg
5e55118076
Only make contravariant inferences from pure contravariant positions
2018-09-25 18:07:51 -07:00