Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Exclude the overlap between Type and Value when checking for parameter visibility (#27444)

Browse Source
This commit is contained in:
Wesley Wigham
2018-10-02 09:41:06 -07:00
committed by GitHub
parent b15d6a48cb
commit 1e55d650f3
5 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/checker.ts
+1 -1
View File
@@ -1238,7 +1238,7 @@ namespace ts {
// local types not visible outside the function body
: false;
}
if (meaning & SymbolFlags.Value && result.flags & SymbolFlags.FunctionScopedVariable) {
if (meaning & result.flags & SymbolFlags.FunctionScopedVariable) {
// parameters are visible only inside function body, parameter list and return type
// technically for parameter list case here we might mix parameters and variables declared in function,
// however it is detected separately when checking initializers of parameters
tests/baselines/reference/typeParameterDoesntBlockParameterLookup.js
+4
View File
@@ -0,0 +1,4 @@
//// [typeParameterDoesntBlockParameterLookup.ts]
declare function f<Foo extends Bar, Bar>(Bar: any): void
//// [typeParameterDoesntBlockParameterLookup.js]
tests/baselines/reference/typeParameterDoesntBlockParameterLookup.symbols
+8
View File
@@ -0,0 +1,8 @@
=== tests/cases/compiler/typeParameterDoesntBlockParameterLookup.ts ===
declare function f<Foo extends Bar, Bar>(Bar: any): void
>f : Symbol(f, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 0))
>Foo : Symbol(Foo, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 19))
>Bar : Symbol(Bar, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 35), Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 41))
>Bar : Symbol(Bar, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 35), Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 41))
>Bar : Symbol(Bar, Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 35), Decl(typeParameterDoesntBlockParameterLookup.ts, 0, 41))
tests/baselines/reference/typeParameterDoesntBlockParameterLookup.types
+5
View File
@@ -0,0 +1,5 @@
=== tests/cases/compiler/typeParameterDoesntBlockParameterLookup.ts ===
declare function f<Foo extends Bar, Bar>(Bar: any): void
>f : <Foo extends Bar, Bar>(Bar: any) => void
>Bar : any
tests/cases/compiler/typeParameterDoesntBlockParameterLookup.ts
+1
View File
@@ -0,0 +1 @@
declare function f<Foo extends Bar, Bar>(Bar: any): void