Commit Graph
8385 Commits
Author SHA1 Message Date
Nathan Shively-Sanders 5cd0ca19af Add test case, correct existing test case
Existing: String assignment to a numeric indexer should succeed, not fail.
  (The baseline was already correct but the inline comment was wrong.)
New: Boolean assignment to a numeric indexer should fail.
2015-10-15 11:04:36 -07:00
Nathan Shively-Sanders 8eacd41ab0 Add tests and accept baselines 2015-10-15 09:52:31 -07:00
Nathan Shively-Sanders 6798bd576b Primitives are not assignable to any-type indexers
`string/numberIndexTypesRelatedTo` needs to prevent primitives from being
assignable to an indexer of type 'any'. However, these two functions take
an apparent type, which no longer has the primitive flag set. I thought of
three ways to provide this information:

1. Pass the original type into `string/numberIndexTypesRelatedTo` and
check its flag.
2. Record a boolean `isPrimitive` before converting to the apparent type,
and pass it to `string/numberIndexTypesRelatedTo`.
3. Create a helper function `isPrimitive` that takes the apparent type and
compares it to globalString/Number/Boolean/ESSymbolType.

I decided on (1) because it seems like the simplest and safest. But none
of the options are elegant. Please suggest improvements.
2015-10-15 09:45:38 -07:00
Mohamed Hegazy 21e30e0f59 Merge pull request #5235 from Microsoft/fixDecoratorDiagostics
Fix exception in compiler when type checking decorators with generics.
2015-10-14 12:29:08 -07:00
Mohamed Hegazy 5234bf698c Merge pull request #5033 from Microsoft/dirkb/fix_5032
Fixed #5032: tsserver: Format on type broken
2015-10-14 09:49:50 -07:00
Vladimir Matveev 124447763b Merge pull request #5233 from Microsoft/relaxedUseBeforeDef
allow forward references to block scoped variables from functions
2015-10-13 14:19:01 -07:00
Mohamed Hegazy 99d448a167 Merge pull request #5231 from Microsoft/removeExperimentalAsyncFunctions
Remove experimental async functions
2015-10-13 14:17:36 -07:00
Ryan Cavanaugh b2d666c489 Merge pull request #5184 from RyanCavanaugh/fix5096
Don't issue completion in JSX text
2015-10-13 13:27:39 -07:00
Vladimir Matveev 0465f1b0bb revert enum related changes 2015-10-13 13:18:58 -07:00
Ryan Cavanaugh 6bbfe56dca Use memberListCount 2015-10-13 13:16:44 -07:00
Vladimir Matveev 48b24343b1 use isBlockScopedNameDeclaredBeforeUse for block scoped variables and enums 2015-10-13 00:07:36 -07:00
Ron Buckton 0fa89ad99c Fixes #5104. 2015-10-12 17:38:55 -07:00
Vladimir Matveev eb3b91cf1b addressed PR feedback 2015-10-12 17:24:39 -07:00
Wesley Wigham c4a15d9a3b Merge pull request #5067 from Microsoft/travis-node-4
CI Against Node 4
2015-10-12 16:58:36 -07:00
Yui 77eaf04386 Merge pull request #4914 from Microsoft/exponentiation
[ES7] Exponentiation
2015-10-12 16:37:45 -07:00
Vladimir Matveev f952873ef1 allow forward references to block scoped variables from functions 2015-10-12 16:18:37 -07:00
Vladimir Matveev c8ba16644b Merge pull request #4911 from Microsoft/liftDtsOnlyRestriction
extend the list of extensions for module file names in node_modules f…
2015-10-12 14:48:47 -07:00
Yui T 90258794a6 Address PR feedback 2015-10-12 14:32:48 -07:00
Mohamed Hegazy e9bed76baa Remove --experimentalAsyncFunctions from tests 2015-10-12 14:27:58 -07:00
Mohamed Hegazy 92f1b48cc8 Remove --experimentalAsyncFunctions 2015-10-12 14:27:33 -07:00
Nathan Shively-Sanders 8a051343ff Merge pull request #5169 from Microsoft/fix-simple-uses-of-polymorphic-this-in-services
Fix simple uses of polymorphic this in services
2015-10-12 13:54:50 -07:00
Vladimir Matveev 4ccf630f63 merge with master 2015-10-12 13:45:06 -07:00
Ryan Cavanaugh c05297cfea Merge pull request #5178 from RyanCavanaugh/fix5132
Escape quotes when emitting React
2015-10-12 11:56:46 -07:00
Yui T e405ccebec fix linter failure 2015-10-12 11:48:38 -07:00
Zhengbo Li 5605c8a639 Merge pull request #5177 from zhengbli/i4684
Change the definition of NodeFilter in lib.d.ts
2015-10-12 11:44:26 -07:00
zhengbli de52865243 Remove prototype from NodeFilter static type 2015-10-12 11:35:36 -07:00
Vladimir Matveev 22e68de7ec Merge pull request #5216 from Microsoft/checkFunctionsInClassExpressions
check functions in class expressions
2015-10-12 11:09:21 -07:00
Yui T 6a62c01aab Merge branch 'exponentiation' of https://github.com/Microsoft/TypeScript into exponentiation 2015-10-12 10:55:17 -07:00
Yui T 2918f9d7a2 Update baseline after merge conflict 2015-10-12 10:55:10 -07:00
Yui T d3e10b3d3f Merge remote-tracking branch 'origin/master' into exponentiation
Conflicts:
	src/compiler/diagnosticInformationMap.generated.ts
	src/compiler/program.ts
2015-10-12 10:54:46 -07:00
Vladimir Matveev d757e5e7a2 Merge pull request #5226 from Microsoft/blockScopedExports
check initialization of exported block scoped variables
2015-10-12 10:32:57 -07:00
Vladimir Matveev 61c5b95f8a Merge pull request #5217 from Microsoft/formatAsyncOpenParen
add rule to insert space between async keyword and open paren
2015-10-12 10:23:32 -07:00
Vladimir Matveev ca98831674 addressed PR feedback: added tests for let declarations 2015-10-12 10:22:18 -07:00
Vladimir Matveev adf9f9b8df check initialization of exported block scoped variables 2015-10-12 09:59:41 -07:00
Vladimir Matveev c35419e12e add rule to insert space between async keyword and open paren 2015-10-11 22:19:51 -07:00
Vladimir Matveev a0683276d1 check functions in class expressions 2015-10-11 21:57:17 -07:00
Vladimir Matveev 1b5dc0d7d1 Merge pull request #5121 from Microsoft/shorthandPropsInDestructuring
parse/check/emit shorthand property assignment in destructuring
2015-10-10 22:39:05 -07:00
Paul van Brenk 573652160c Merge pull request #5197 from Microsoft/supportIndentStyle
Support different indentation styles
2015-10-09 16:51:39 -07:00
Daniel Rosenwasser 12b436bb2c Merge pull request #5084 from MartyIX/patch-4
Compiler gives unhelpful error messages in the presence of multiple default exports
2015-10-09 14:18:18 -07:00
Martin Vseticka 69ff6f5090 Add "A module cannot have multiple default exports." message for multiple "default" exports 2015-10-09 21:37:54 +02:00
Vladimir Matveev a556209b7e addressed PR feedback 2015-10-09 09:55:25 -07:00
Daniel Rosenwasser 543cce5e43 Merge pull request #5191 from jbondc/typo-1
Typo
2015-10-09 09:32:18 -07:00
Nathan Shively-Sanders f19a2f54ed Fixup comments 2015-10-09 09:02:42 -07:00
jbondc 3d6398162e Typo 2015-10-09 11:16:36 -04:00
Yui T d57ee1db79 Merge branch 'master' into errorsuperbeforethis
Conflicts:
	src/compiler/checker.ts
	src/compiler/diagnosticInformationMap.generated.ts
	src/compiler/types.ts
2015-10-08 23:57:26 -07:00
Yui T 1fc11aa18f Address PR feedback, add comment 2015-10-08 23:25:05 -07:00
Yui T 5e921c1d8d Address PR feedback, remove scriptTarget ES7 2015-10-08 17:12:22 -07:00
Yui T af5dc3e3b3 Address PR feedback. Always emit parentheses around emit capturing 2015-10-08 16:59:49 -07:00
Mohamed Hegazy 350bb1f315 Merge pull request #5167 from jbondc/const-indexed-access
Const enum indexed access
2015-10-08 15:39:14 -07:00
Ryan Cavanaugh 24334b506c Only show the opening tag name when completing a close tag
Fixes #5096
2015-10-08 15:32:36 -07:00