Commit Graph
20617 Commits
Author SHA1 Message Date
Nathan Shively-Sanders 40c32136f1 Merge pull request #20106 from Microsoft/jsdoc-errors-become-semantic-errors
Report JSDoc errors as semantic errors in checkJS mode
2017-11-20 10:02:04 -08:00
Nathan Shively-Sanders edf9f02bdd Merge branch 'master' into jsdoc-errors-become-semantic-errors 2017-11-20 08:34:26 -08:00
Nathan Shively-Sanders 744760df91 Cache result of isCheckJsEnabledForFile in getSemanticDiagnosticsForFile 2017-11-20 08:34:01 -08:00
Bill Ticehurst 6c4c10c7cf Merge pull request #20115 from Microsoft/dev/billti/port20109toMaster
Port #20109 to master
2017-11-17 21:03:17 -08:00
Arthur Ozga 65908ef8ba Merge pull request #19864 from Microsoft/dev/aozgaa/eventPortTelemetry
Send events through a single stream
2017-11-17 20:22:57 -08:00
Arthur Ozga d2cc4f15be test overriding Session.event 2017-11-17 19:48:57 -08:00
Ryan Cavanaugh 574ceccf0a Update editorServices.ts
Fix lint
2017-11-17 16:12:42 -08:00
Andy 82502ea086 Fix semantic merge conflict (#20119) 2017-11-17 15:29:09 -08:00
csigs a62e65328a LEGO: Merge pull request 20120
LEGO: Merge pull request 20120
2017-11-17 15:11:25 -08:00
csigs 4037b5c55a LEGO: check in for master to temporary branch. 2017-11-17 23:11:05 +00:00
Bill Ticehurst 805f191a57 Moved minified file exclusion 2017-11-17 14:39:33 -08:00
Bill Ticehurst b244907074 Fixed internal safelist 2017-11-17 14:39:26 -08:00
Andy 97bb471e48 For import completion, if multiple re-exports exist, choose the one with the shortest path (#20049)
* For import completion, if multiple re-exports exist, choose the one with the shortest path

* Code review
2017-11-17 14:35:32 -08:00
Andy e7adb1ce79 Bundle fileName with CodeActionCommand (#19881)
* Bundle fileName with CodeActionCommand

* Update test

* Fix API tests

* Add new overloads in services

* Fix overload

* Update API baselines
2017-11-17 14:16:38 -08:00
Nathan Shively-Sanders 31451fa7d1 Update chrome devtools baselines
Add almost 37,000 semantic errors in addition to the 250 syntactic
errors
2017-11-17 10:40:30 -08:00
Nathan Shively-Sanders c01f0c0b9f Test:ts-ignore works on jsdoc syntax errors 2017-11-17 10:40:16 -08:00
Nathan Shively-Sanders eeeefcc10e Report jsdoc errors as semantic errors
This allows reporting of semantic errors as well. Semantic errors are
likely to outnumber syntactic errors, so it's valuable not to block
semantic errors on a few syntactic errors.
2017-11-17 10:38:30 -08:00
Andy 0c0f4b81ae Simplify documentHighlights (#20091) 2017-11-17 10:19:35 -08:00
csigs cc0f923ef3 LEGO: Merge pull request 20103
LEGO: Merge pull request 20103
2017-11-17 09:10:27 -08:00
csigs 294ebaa85f LEGO: check in for master to temporary branch. 2017-11-17 17:10:08 +00:00
Andy 74a44e09a7 Support semantic classification of alias (#20012) 2017-11-17 08:04:51 -08:00
Andy 46c0edcebd In getContextualTypeForBinaryOperand, only need to look for = assignment operator, not e.g. += (#20037)
* In `getContextualTypeForBinaryOperand`, only need to look for `=` assignment operator, not e.g. `+=`

* isNonContextualBinaryExpression -> isContextSensitiveAssignment
2017-11-17 07:29:32 -08:00
Andy 36f7f307f5 lineAction: Use an enum instead of true | false | undefined (#20086) 2017-11-17 06:13:56 -08:00
csigs 12989456d1 LEGO: Merge pull request 20092
LEGO: Merge pull request 20092
2017-11-16 21:10:29 -08:00
csigs ad7149be75 LEGO: check in for master to temporary branch. 2017-11-17 05:10:10 +00:00
Arthur Ozga 890820b528 cleanup NodeTypingsInstaller 2017-11-16 19:19:05 -08:00
Arthur Ozga 8b0d3ab318 remove comments 2017-11-16 19:10:38 -08:00
Arthur Ozga c098a5cf83 type event callback correctly 2017-11-16 19:06:08 -08:00
Arthur Ozga cda486ad85 update baselines 2017-11-16 18:27:30 -08:00
Arthur Ozga 49d92d844b defer callback and remove handler object 2017-11-16 18:15:39 -08:00
Armando Aguirre 464ae31776 Merge pull request #20082 from armanio123/KendoOptionalMin
Modified Kendo regex to include -ui folders and files without min
2017-11-16 17:37:24 -08:00
Andy 9992395f42 Support arbitrary prototype property assignments in navigation bar (#19923) 2017-11-16 16:51:02 -08:00
Armando Aguirre 49c169a523 Fixed unbalanced parenthesis 2017-11-16 16:16:10 -08:00
Armando Aguirre 48aa83e13a Modified Kendo regex to include -ui folders and files without min 2017-11-16 15:59:27 -08:00
csigs 2f7ff67646 LEGO: Merge pull request 20081
LEGO: Merge pull request 20081
2017-11-16 15:11:47 -08:00
csigs 25e4dc990a LEGO: check in for master to temporary branch. 2017-11-16 23:11:19 +00:00
Nathan Shively-Sanders c698a2b8e5 Merge pull request #19227 from Microsoft/infer-object-type-from-string-literal-to-keyof-T
Infer object type from string literal to keyof T
2017-11-16 15:07:12 -08:00
Ryan Cavanaugh 1ea1ad4a37 Merge pull request #20048 from RyanCavanaugh/fixSafeList
Apply the safe list to projects which didn't specify an upfront include
2017-11-16 14:18:11 -08:00
Ryan Cavanaugh a416826b64 Apply safelist exclusions even when include is not specified; recompute project contexts when installer reqs finish 2017-11-16 12:52:30 -08:00
Charles Pierce 1da35d9dca Treat exhaustive switch as last statement in function #18882 (#20063) 2017-11-16 12:17:26 -08:00
Andy 478b404f42 Detect re-exports from "export *" in completions (#20043) 2017-11-16 11:15:14 -08:00
Andy 94581c1946 Strip "/index" from import fix module specifiers (#19962)
* Strip "/index" from import fix module specifiers

* Require "node" module resolution

* More tests
2017-11-16 11:12:34 -08:00
Wesley Wigham 98112d4964 Add very error-ful test for chrome devtools js (#19992) 2017-11-16 11:02:00 -08:00
Nathan Shively-Sanders 2263a1e73b Merge pull request #20071 from Microsoft/error-on-excess-spread-arguments
Error on excess spread arguments
2017-11-16 11:00:24 -08:00
Nathan Shively-Sanders 6a08820fe7 Improve spread arity mismatch error messages
Thanks @weswigham for the improved wording.
2017-11-16 10:28:17 -08:00
Anders Hejlsberg b6f96052d8 Merge pull request #19976 from Microsoft/optimizeParser
Optimize parsing
2017-11-16 10:19:10 -08:00
Nathan Shively-Sanders 865f3281bc Update spread tests w/new excess arguments error 2017-11-16 09:39:31 -08:00
Nathan Shively-Sanders 8657dc10a7 Error on excess spread arguments
Make the *technically* correct construction illegal:

```ts
declare function f(n: number): void;
declare var ns: number[];
f(1, ...ns);
```

This call only makes sense if `ns = []`, but in that case, why pass
`ns` at all? Allowing this call masks other errors when functions are
refactored to have fewer parameters, or to stop using rest parameters:

```ts
declare function old(...ns: number[]): void;
declare function new(ns: number | number[]): void;
old(1, ...ns); // Fine!
new(1, ...ns); // Should error!
```

This change the error for excess spread arguments to be more
understandable:

"Expected 3 arguments, but got least 4".

Previously the error would have been
"Expected 3 argument, but got at least 3", which is, again, technically
correct, but not understandable.
2017-11-16 09:31:50 -08:00
Andy f352e46892 Revert "Change "isThisless" predicates to "mayReferenceThis" predicates (#20036)" (#20054)
This reverts commit 3d05952719.
2017-11-16 06:47:12 -08:00
Arthur Ozga 5c2fea4d4e make eventSender required for TypingsInstaller 2017-11-15 19:49:34 -08:00