Commit Graph

21993 Commits

Author SHA1 Message Date
Andy 2fb7e643f4 Simplify suppressLeadingAndTrailingTrivia (#22356) 2018-03-06 11:34:33 -08:00
Andy a138985448 isValidMethodAccess: Instantiate signature this type if necessary (#21722) 2018-03-06 10:18:06 -08:00
Andy e5f91f5948 Convert annotateWithTypeFromJSDoc refactor to a codefix (#22336)
* Convert annotateWithTypeFromJSDoc refactor to a codefix

* Compute isJsFile once at top
2018-03-06 07:49:21 -08:00
Josh Goldberg 7826b38426 Apply 'no-unnecessary-initializer' lint rule (#22014)
* Apply 'no-unnecessary-initializer' lint rule

Forbids `let`/`const` statements to be initialized to `undefined`, since that's the initial value by default anyway.
The auto-fixer also happened to remove two unnecessary `as number` casts in `src/harness/parallel/worker.ts`.

For historical data: to run with `--fix`, I modified the line in `Jakefile.js` that declared the `cmd` for running TSLint.

* Moved worker.ts type assertions to parameters
2018-03-06 07:30:40 -08:00
Andy 5e593acad9 Avoid cast by providing type predicate to isExternalModuleAugmentation (#22119)
* Avoid cast by providing type predicate to isExternalModuleAugmentation

* Break into isExternalModuleAugmentation and isModuleAugmentationExternal
2018-03-06 07:27:36 -08:00
csigs bb6bd4512d LEGO: Merge pull request 22351
LEGO: Merge pull request 22351
2018-03-05 21:10:39 -08:00
csigs 449e2aaaf7 LEGO: check in for master to temporary branch. 2018-03-06 05:10:16 +00:00
Priyantha Lankapura ed1c5d9688 update test for #20577 (#22310) 2018-03-05 16:15:08 -08:00
Wesley Wigham 48b63187c6 Remove TypeFacts.Discriminatable (#22346) 2018-03-05 15:51:47 -08:00
Wesley Wigham 2f0a13c7c3 Use global NonNullable type for nonnull types (#22096)
* Use NonNullable type for nonnull types

* Add noLib test

* Remove conditional type fallback for when lib is not present
2018-03-05 14:52:06 -08:00
Andy 4ddf045d6a For <div a= >, after =, do not try to parse an expression (#21373) 2018-03-05 14:38:55 -08:00
Wesley Wigham f41555ce89 Make test timeout on travis huge (#22344)
* Make test timeout on travis huge

Specifically, 10 minutes, which is the duration it can go before travis itself will time out (if there is not output). This is needed because we set `workerCount=3` to improve our runtime, however travis doesn't _always_ have that much compute available; so when travis is resource-starved and we're running on one real thread, two test runners sit idle (due to resource starvation) and get timed-out by the watchdog process during test running. This timeout should be long enough that such that timeouts no longer occur on travis.

* Update .travis.yml
2018-03-05 14:34:46 -08:00
Wesley Wigham 16bf02991d Allow indexing generics with unique symbols (#22339)
* Allow indexing generics with unique symbols

* Move condition to assert
2018-03-05 13:58:19 -08:00
Wesley Wigham 53ae507545 Add inference priority for mapped type keys (#22246)
* Add inference priority for mapped type keys

The new priority causes union inference, similarly to return type

* Rename priority

* Fix comment typo
2018-03-05 13:19:00 -08:00
Andy 2ac2291b84 Convert use-default-import refactor to a codefix (#22334) 2018-03-05 12:43:01 -08:00
Klaus Meinhardt 3bcfed61b6 Update .npmignore (#22318)
* Update .npmignore

* add yarn.lock
2018-03-05 12:19:56 -08:00
Anders Hejlsberg 1192a1808b Merge pull request #22323 from Microsoft/checkInferredConstraints
Check inferred constraints for 'infer X' type variables
2018-03-05 10:18:13 -08:00
Anders Hejlsberg 07ed899b46 Merge branch 'master' into checkInferredConstraints 2018-03-05 06:32:11 -08:00
Anders Hejlsberg 70818ae716 Merge pull request #22313 from Microsoft/fixDistributiveConditionalTypes
Fix distributive conditional types
2018-03-05 06:23:45 -08:00
Anders Hejlsberg f97ab4d3ef Accept new baselines 2018-03-04 16:49:13 -08:00
Anders Hejlsberg 19e07eaea6 Add tests 2018-03-04 16:49:06 -08:00
Anders Hejlsberg 6fcc99e800 Properly check inferred constraints for 'infer X' type variables 2018-03-04 16:28:22 -08:00
Anders Hejlsberg 6569f45812 Accept new baselines 2018-03-03 18:08:42 -08:00
Anders Hejlsberg 081a394927 Add regression test 2018-03-03 18:08:36 -08:00
Anders Hejlsberg c1aa0bdb84 Accept new baselines 2018-03-03 18:04:27 -08:00
Anders Hejlsberg 8dfcc364bb Defer distributive conditional type when check type is generic 2018-03-03 09:26:40 -08:00
Sheetal Nandi cbef5c29b5 Merge pull request #22151 from Microsoft/svcOfPendingReloadFile
Reload the text from file if there is pending reload of the script info before determining to use SVC
2018-03-02 19:11:11 -08:00
Sheetal Nandi 6e756b5907 Merge pull request #22308 from Microsoft/declarationEmitOfIndirectAlias
Fix incorrect error reported when using type from indirect module alias and current module is exported with "export default"
2018-03-02 19:10:36 -08:00
Wesley Wigham 1c93744a9c Much better comment preservation (#22141)
* Retain comments on (and produce sourcemaps on) the equals token in initializers

* Improved comments/sourcemaps for await, yield, while, and for

* Retain comments on block curly-braces

* Emit comments for if statements

* Improved switch case comment emit

* Improve comment and sourcemap emit for try/catch, throw, and continue statements

* Improve sourcemap emit and comments for with statements

* More accurate sourcemaps+comments emit for new, typeof, void, and delete

* Improve comment emit for element access expressions

* Preserve more comments on imports and exports

* Make function a bit more defensive like other usages of emitTrailingCommentsOfPosition

* Support preserving comments within empty lists

* Handle leading comments of tokens, conditionally indent leading comments

* Stop heuristically sourcemapping tokens

When the transform was trivial it worked, but was unneeded, but when it was complex, it was brittle - best leave source mapping up to the transformers

* Fix unneeded +1

* Tighten up element access comments

* Handle comments on parenthesized expression tokens

* Fix nit
2018-03-02 17:23:59 -08:00
Yuichi Nukiyama 25525bc9d6 Change esnext.promise to es2018.promise (#22292)
* change esnest.promise to es2018.promise

* modify unit tests

* resolve conflict

* resolve conflict
2018-03-02 17:08:36 -08:00
Sheetal Nandi 9f10790023 Do not try to resolve alias for default symbol
Fixes #22257
2018-03-02 16:34:11 -08:00
Sheetal Nandi dc7ee381d5 Add tests when declaration emit for indirect alias usuage results in wrong error reporting
Test for #22257
2018-03-02 16:10:34 -08:00
Anders Hejlsberg 2d5be24669 Merge pull request #22300 from Microsoft/distributeKeyofIntersection
Distribute 'keyof' intersection types
2018-03-02 16:08:20 -08:00
Andy 87c3cca3f0 Make convertFunctionToEs6Class a codefix (#22241)
* Make convertFunctionToEs6Class a codefix

* Change diagnostic message
2018-03-02 12:57:29 -08:00
Mohamed Hegazy 81c313ef19 Update baselines for user tests (#22276) 2018-03-02 10:56:04 -08:00
Andy ba8879d005 Prefer 'return Debug.fail()' over 'throw Debug.fail()' (#22092) 2018-03-02 10:44:06 -08:00
Wenlu Wang b15157356a add spelling suggestion support for module import (#22283) 2018-03-02 10:24:55 -08:00
Andy dd27288e5a Don't rename static 'this' when renaming class (#22235) 2018-03-02 10:23:08 -08:00
Andy b90cdb2221 Reduce duplicate code for TextChange overlaps (#22278) 2018-03-02 10:22:52 -08:00
Anders Hejlsberg 886191390e Accept new baselines 2018-03-02 09:27:07 -08:00
Anders Hejlsberg 95bb156a3e Add tests 2018-03-02 09:26:52 -08:00
Anders Hejlsberg 4256be1591 Accept new baselines 2018-03-02 09:24:59 -08:00
Anders Hejlsberg fe075f26a2 Transform 'keyof (A & B)' to 'keyof A | keyof B' 2018-03-02 09:11:33 -08:00
Benjamin Lichtman dfa1a90b25 Merge pull request #22135 from uniqueiniquity/jsxFragmentHash
Allow characters in JsxText inside JsxFragment that usually don't scan
2018-03-01 16:50:09 -08:00
Wesley Wigham 36bebe9487 Parenthesize computed names if not an assignment expression (#22280) 2018-03-01 16:49:56 -08:00
Wesley Wigham 10e3b73330 Debug assert on parent rebind, mitigate circularity in symbol access checking (#22282)
* Assert that symbol parents are never rebound to different parents

* mitigate circularities in symbol accessibility checking
2018-03-01 16:49:42 -08:00
Anders Hejlsberg f6418c0d30 Merge pull request #22281 from Microsoft/noNeverTypePropagation
Don't propagate 'never' types in type inference
2018-03-01 16:38:32 -08:00
Anders Hejlsberg 7a19b66cc0 Don't propagate 'never' types in type inference 2018-03-01 16:01:32 -08:00
csigs 7f010500ba LEGO: Merge pull request 22279
LEGO: Merge pull request 22279
2018-03-01 15:12:52 -08:00
csigs 2a8af806c9 LEGO: check in for master to temporary branch. 2018-03-01 23:12:32 +00:00