Commit Graph
14 Commits
Author SHA1 Message Date
Oleg Mihailik b60f936b14 Enquote undefineds. 2017-06-20 22:54:50 +01:00
mihailik d7461c874b Promise is a duplicate here - fails to build 2017-02-27 08:39:01 +00:00
Oleg Mihailik baef2aa2c1 Baseline accept 2017-02-27 01:05:56 +00:00
Oleg Mihailik 6a88cf0edf Better check for right.text, more comments in test 2017-02-26 23:13:50 +00:00
Oleg Mihailik 27675fc96e Avoid failing TS2695 for eval. 2017-02-25 23:35:24 +00:00
mihailik d541d434ea Extra test for #8364 - non-breaking of one-liners 2016-05-17 09:09:46 +01:00
mihailik aa2708f510 Prefer ChakraHost when available to node and WScript 2016-04-10 12:07:47 +01:00
mihailik 8aaf923260 Firefox has Object.prototype.watch 2016-02-18 21:43:10 +00:00
mihailik f4929e7b18 Encoding bug 2015-11-12 12:28:37 +00:00
mihailik 4ca24bf131 Use ts.indexOf instead of Array.prototype.indexOf
(keep consistent with the rest of codebase, and thus enable ES3-compatibility of tsc and services)
2015-11-09 09:52:13 +00:00
mihailik efbacb97c9 Use ts.indexOf instead of Array.prototype.indexOf
(keep consistent with the rest of codebase, and thus enable ES3-compatibility of tsc and services)
2015-11-09 09:45:57 +00:00
mihailik e7e020e958 PR feedback - comments and whitespace adjustments 2015-06-26 14:38:25 +01:00
mihailik 133a86a377 Conflict with Object.prototype.watch in FireFox/Gecko
In Gecko engine `commandLine.options.watch` evaluates to a truthy value (a function). Adding an extra check to work around.

[Definition of CompilerOptions.watch in compiler/types](https://github.com/Microsoft/TypeScript/blob/master/src/compiler/types.ts#L1860)
``` typescript
    export interface CompilerOptions {
        // .  .  .
        watch?: boolean;
```

[Object.prototype.watch on MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/watch)
> Warning: Generally you should avoid using watch() and unwatch() when possible. These two methods are
> implemented only in Gecko, and they're intended primarily for debugging use. In addition, using watchpoints
> has a serious negative impact on performance, which is especially true when used on global objects, such
> as window. You can usually use setters and getters or proxies instead. See Browser compatibility for details.
> Also, do not confuse Object.watch with Object.observe.
2015-06-26 09:22:55 +01:00
mihailik dc451b0f69 Fix for #2268 createDiagnosticCollection should be @internal
DiagnosticsCollection interface is marked @internal in [src/compiler/types.ts](https://github.com/Microsoft/TypeScript/blob/c6cd57d18c85e59b2fbe9d316725748a0af8ac2b/src/compiler/types.ts#L1761), so this should be @internal too.

Otherwise it causes compilation errors whenever the generated type definitions for LS is used.

See #2268 for more details.
2015-03-09 14:05:53 +00:00