Commit Graph

19046 Commits

Author SHA1 Message Date
Nathan Shively-Sanders 8680768478 Improve excess property check for spread property
Fall back to the assignment's declaration; don't use the property's
valueDeclaration because that is not useful when the property comes from
a spread. The fallback now happens when the property's valueDeclaration
does not have the object literal's valueDeclaration as an ancestor.
2017-06-14 11:26:15 -07:00
Nathan Shively-Sanders eaa8f48672 Merge pull request #16525 from Microsoft/remove-undefined-from-optional-spread-properties
Remove undefined from optional spread properties
2017-06-14 10:58:37 -07:00
Nathan Shively-Sanders 657c469d4f Remove undefined from optional spread properties
Fixes #16509 by making the change from #15938 less strict. This is
technically a hole, but it's not as big a hole as before #15938.
2017-06-14 10:31:11 -07:00
Ron Buckton fbe002a595 Merge pull request #16502 from Microsoft/fix16211
Fix 'extends' with type parameter default returned from superclass construct signature
2017-06-13 19:30:27 -07:00
Ron Buckton 73d63ec98c Switch to sameMap 2017-06-13 18:02:39 -07:00
Mohamed Hegazy 68008915d6 Merge branch 'completionWithMeaning' 2017-06-13 17:41:34 -07:00
Mohamed Hegazy 3532875af7 Merge branch 'master' into completionWithMeaning 2017-06-13 17:41:24 -07:00
TravCav 9611e58670 combined logic in parseParameterOrPropertyTag (#16481) 2017-06-13 16:30:36 -07:00
Kanchalai Tanglertsampan 9df2931aa3 Add tests and update baselines 2017-06-13 15:24:05 -07:00
Kanchalai Tanglertsampan 3062d36463 Add "undefined" as return type 2017-06-13 15:20:52 -07:00
Yui 27184ed535 Merge pull request #16493 from Microsoft/master-housekeeping
just update issue template
2017-06-13 14:24:32 -07:00
Nathan Shively-Sanders 57f8648b0f Merge pull request #16505 from Microsoft/decl-emit-parenthesize-keyof
Add parentheses around keyof in declaration emit when needed
2017-06-13 14:17:49 -07:00
Kanchalai Tanglertsampan d392f1edab Remove unnecessary get type from JSDoc comment 2017-06-13 14:09:16 -07:00
Nathan Shively-Sanders 2d2ac6794f Test:correct parens around keyof in decl emit 2017-06-13 14:00:26 -07:00
Nathan Shively-Sanders 43d47de74d Add parentheses around keyof in declaration emit
When needed. Use InElementType flag to determine this.
2017-06-13 13:59:38 -07:00
Ron Buckton 6370fc8b85 Fix class extends+decorator with new class emit 2017-06-13 13:35:53 -07:00
Nathan Shively-Sanders 9f69cd5a62 Merge pull request #16497 from Microsoft/use-checker-for-decl-emit-of-optional-param-props
Use checker for declaration emit of optional, uninitialised parameter properties
2017-06-13 13:21:35 -07:00
Ron Buckton 696643998a Fix constructor instantiation with defaults 2017-06-13 13:19:54 -07:00
Ron Buckton 742836938b Fix grammar check for empty type argument list and compiler crash 2017-06-13 12:19:49 -07:00
Nathan Shively-Sanders 5780494ddb Test:declaration emit of optional parameter props 2017-06-13 11:50:46 -07:00
Nathan Shively-Sanders 433a06d599 Add isOptionalUninitializedParameterProperty
Improves declaration emit and code readability
2017-06-13 11:49:58 -07:00
Anders Hejlsberg 31f0814d4a Simplify generic function call error reporting (#16439)
* Simplify error reporting for generic functions

* Accept new baselines

* Fix fourslash tests
2017-06-13 11:43:13 -07:00
Kanchalai Tanglertsampan 7dae8f73dd Merge branch 'master' into master-fix13306 2017-06-13 11:41:48 -07:00
Kanchalai Tanglertsampan 9ecaa3d74a just update issue template 2017-06-13 11:34:53 -07:00
Nathan Shively-Sanders 2a921d4b33 Use checker for decl emit:optional parameter props
Optional parameter properties create a property with a type that unions
with undefined when strictNullChecks is on. This needs to be reflected
in the generated declaration.
2017-06-13 11:31:51 -07:00
Arthur Ozga 9cd04e06fd Merge pull request #16309 from aozgaa/codeFixPrefixUnused2
Code fix prefix unused2
2017-06-13 11:16:33 -07:00
Sheetal Nandi 1f167786ad Merge branch 'master' into completionWithMeaning 2017-06-13 11:16:32 -07:00
Nathan Shively-Sanders 2495e6780b Merge pull request #16488 from Microsoft/add-jsdoc-to-eof-token
Add jsdoc to EOF token to catch missed `@typedef`s
2017-06-13 11:14:52 -07:00
Arthur Ozga 2a05bb1441 Merge pull request #16433 from Microsoft/suppressBraceCompletionOfQuotesinComments
Suppress brace completion of Quotes in Comments
2017-06-13 11:07:52 -07:00
Nathan Shively-Sanders b967bbb722 Test @typedef in @typedef-only JS files
Previously there was nothing for the @typedef to attach to, so the
comment was never parsed. Now these comments attach to the EOF token.
2017-06-13 10:37:04 -07:00
Nathan Shively-Sanders 6d3e15f0ee Add JSDoc to EOF token to catch missed @typedefs 2017-06-13 10:32:25 -07:00
Yui 23f618b6bc Merge pull request #16406 from Microsoft/master-fix16402
[Master] Language Service on Dynamic import
2017-06-13 10:22:45 -07:00
Kanchalai Tanglertsampan da52bad4b8 Address PR 2017-06-13 10:03:43 -07:00
Mohamed Hegazy 1d0087dd2d Update version 2017-06-12 18:28:10 -07:00
Sheetal Nandi 1bf1209f7e Cleanup script infos that are not part of any project when the project is closed or inferred projects are refreshed
Also dispose some pointers so that the closures get disposed with project and script infos
2017-06-12 16:52:36 -07:00
Nathan Shively-Sanders 3d8cf62846 Merge pull request #16463 from Microsoft/jsdoc-@template-in-scope-as-type-parameter
Jsdoc @template in scope as type parameter
2017-06-12 16:07:49 -07:00
Arthur Ozga 70bace78a0 respond to comments 2017-06-12 15:36:34 -07:00
Nathan Shively-Sanders ecc211345a Merge pull request #16465 from Microsoft/skip-non-null-assertion-for-reference-expr
Skip non-null assertion for references
2017-06-12 15:33:36 -07:00
Andy 6a8a6c34b4 getPossibleSymbolReferencePositions: Always use full start (#16420) 2017-06-12 15:24:31 -07:00
Andy 8b55675cb4 Simplify isDeclarationNameOrImportPropertyName (#16421) 2017-06-12 15:23:45 -07:00
Nathan Shively-Sanders 3b97c683e3 Merge pull request #16466 from Microsoft/fix-build-break
Fix reference to isTypeParameterDeclaration in services
2017-06-12 15:21:05 -07:00
Nathan Shively-Sanders 93bdd3cb39 Fix reference to isTypeParameterDeclaration in services
Fixes build break
2017-06-12 15:07:04 -07:00
Nathan Shively-Sanders 497d627a02 Test: Allow ++ after non-null assertion 2017-06-12 14:41:10 -07:00
Nathan Shively-Sanders 55beb14bca Checking references skips assertions+parentheses 2017-06-12 14:40:01 -07:00
Andy fbcddb61e2 Don't bind JSDoc namespace in a TS file (#16416) 2017-06-12 14:35:35 -07:00
Andy 050126c1b6 Rename isTypeParameter to isTypeParameterDeclaration (#16422) 2017-06-12 14:31:01 -07:00
Nathan Shively-Sanders 024ab094b3 Update jsdoc of new function 2017-06-12 14:27:43 -07:00
Nathan Shively-Sanders abc9e687ac Consolidate getting type parameter declarations
Create getEffectiveTypeParameterDeclarations in utilities.ts
2017-06-12 14:23:47 -07:00
Nathan Shively-Sanders eda7978dd1 Cleanup getTypeParametersFromDeclaration et al 2017-06-12 14:06:46 -07:00
Anders Hejlsberg dde60bb624 Merge pull request #16368 from Microsoft/stricterGenericChecks
Stricter generic signature checks
2017-06-12 13:56:21 -07:00