Commit Graph

19046 Commits

Author SHA1 Message Date
Nathan Shively-Sanders f45df8fb69 Spelling code fix:suggestions from apparent type
The code fix for spelling correction needs to provide suggestions based
on the apparent type since sometimes the type at a location will be a type
parameter. One such example is `this`.

Fixes #16744
2017-06-29 16:21:00 -07:00
Ryan Cavanaugh ec00bb9b72 Merge pull request #16697 from RyanCavanaugh/preserveMethodComments
Preserve method comments in JS->ES6 conversion.
2017-06-29 15:40:16 -07:00
Ryan Cavanaugh 277f4592c1 Add tests 2017-06-29 15:14:09 -07:00
Andrew Casey ac72803bb2 Merge pull request #16684 from amcasey/Vsts434619
Watch for the creation of missing files
2017-06-29 13:41:18 -07:00
Andrew Casey 569ecabb0a Address PR feedback
Make Program.getMissingFilePaths required

Assume getMissingFilePaths always returns a defined value

Make getMissingFilePaths internal

Replace nullable-bool with enum

Update type to reflect possibility of undefined

Use deepEqual to simplify tests

Make condition const

Don't bother cleaning up map before freeing it

Switch from foreach to for-of to simplify debugging

Use a Map, rather than a FileMap, to track open FileWatchers

Fix compilation errors

Introduce and consume arrayToSet

Fix lint warnings about misplaced braces

Delete incorrect comment

Delete from map during iteration

Eliminate unnecessary type annotations
2017-06-29 11:29:19 -07:00
Arthur Ozga 60b78c618f only format open curly up to the open curly 2017-06-29 11:13:44 -07:00
Andy 179a3e10b5 Handle depth in all readDirectory implementations (#16646) 2017-06-29 11:04:33 -07:00
Ryan Cavanaugh 8b7402f9f8 Merge pull request #16833 from ltearno/master
Comments incorrectly read 'TypeFlags' instead of 'ObjectFlags' at some places
2017-06-29 10:40:50 -07:00
Andrew Casey 0f683ac2ad Add missing file unit tests
1. Test `Program.getMissingFilePaths`
2. Test program structure reuse (i.e. that the appearance of a missing
file prevents complete reuse)
2017-06-29 10:39:32 -07:00
Andrew Casey 6d200bffbd Watch files through the host
Call `this.projectService.host.watchFile`, rather than
`ts.sys.watchFile` so that it gets mocked correctly in the unit tests.
Repair two failing tests.
2017-06-29 10:39:32 -07:00
Andrew Casey 4652fc491f Confirm method is defined before calling 2017-06-29 10:39:32 -07:00
Andrew Casey a39e969338 Clean up file watchers on project close 2017-06-29 10:39:31 -07:00
Andrew Casey 4863ada22c Track missing files
1. Expose missing files from the `Program`.
2. In `tsc --watch` and `tsserver`, add file watchers to missing files.
3. When missing files are created, schedule compilation (tsc) or refresh
the containing projects (tsserver).
2017-06-29 10:39:31 -07:00
Andrew Casey 587309d029 Update error case check
`getTouchingWord` indicates failure by returning the sourceFile node,
rather than `undefined`.
2017-06-29 10:39:30 -07:00
Andy 977525b37e getSymbolOfEntityNameOrPropertyAccessExpression: combine common code from PropertyAccessExpression and QualifiedName cases (#16827) 2017-06-29 10:07:08 -07:00
Andy d73b05cc63 Fix typo (#16826) 2017-06-29 10:06:35 -07:00
Arnaud Tournier 9ccf8ca6b0 Comments incorrectly read 'TypeFlags' instead of 'ObjectFlags' at some places 2017-06-29 17:54:34 +02:00
t_ 51fb7e9a81 Add alwaysStrict option (#16562)
* Add alwaysStrict option

* Enable alwaysStrict

* Fix for strict mode

* keep whitespace
2017-06-28 19:44:15 -07:00
Daniel Rosenwasser 22f38b720c Merge pull request #16704 from charlespierce/namespace_export_default
Diagnostics for default class / function export in namespace
2017-06-28 17:10:45 -07:00
Andy c4319e3b94 Clean up uses of ensureScriptKind (#16714)
* Clean up uses of ensureScriptKind

* Remove unneeded parentheses
2017-06-28 14:29:16 -07:00
Arthur Ozga 39b7965c0d respond to comment 2017-06-28 13:41:52 -07:00
Andy 2ccfe502f7 Fix scope of @typedef references (#16718)
* Fix scope of @typedef references

* Remove unused variables
2017-06-28 13:30:23 -07:00
Andy 9013665e22 Replace FileMap with Map where there is no keyMapper (#16724)
* Replace FileMap with Map where there is no keyMapper

* Remove `toKey` and use `keyMapper` directly
2017-06-28 13:15:34 -07:00
Arthur Ozga eae234cab2 disable spaceBeforeOpenCurly if newline rule is enabled 2017-06-28 13:13:53 -07:00
Andy 9260a399a3 Remove duplicate switch cases (#16721) 2017-06-28 12:53:43 -07:00
Andy 42e08f5578 findAllRefs: Find string references inside of template strings (#16723) 2017-06-28 12:53:12 -07:00
Arthur Ozga a5c8a29fa4 only format opencurly if no intervening tokens 2017-06-28 12:48:14 -07:00
Nathan Shively-Sanders c51c2aecca Merge pull request #16736 from DickvdBrink/issue/15208
Also check TypeAlias for unused type parameters
2017-06-28 12:37:04 -07:00
Nathan Shively-Sanders cf0fe925fa Merge pull request #16734 from HerringtonDarkholme/error
fix #16702: polish type predicate error message
2017-06-28 12:33:45 -07:00
Daniel Rosenwasser faf2e2ab5c Merge pull request #16719 from mbrickn/patch-1
Updated links to use https and avoid redirects
2017-06-28 11:45:15 -07:00
Nathan Shively-Sanders 2f5ecf00a1 Merge pull request #16698 from Microsoft/master-16017
[Master]  Fix 16017 - ordering of promise all method
2017-06-28 10:46:53 -07:00
Wesley Wigham e52b996484 Fix gulp & types for gulp to 3 (#16771) 2017-06-27 13:45:41 -07:00
Andy 18357543c6 Provide better services for incomplete generic calls (#16535)
* Provide better services for incomplete generic calls

* Use clearer name

* Remove `inferredAnyDefaultTypeArgument` and `getBestGuessSignature`; have `resolveSignature` always get the best signature if !produceDiagnostics

* Update names and comments
2017-06-27 09:14:23 -07:00
Arthur Ozga 45a77c0a2c visit question token 2017-06-26 12:33:29 -07:00
Arthur Ozga c5f6c4fac0 remove unecessary check 2017-06-26 11:21:21 -07:00
Andy aeb5264b74 Consistently use variable mangledScopedPackageSeparator instead of magic "__" string (#16713) 2017-06-26 11:10:57 -07:00
Arthur Ozga 61af315778 respond to comments 2017-06-26 10:55:04 -07:00
Ryan Cavanaugh b52747e12c Add property comments as well 2017-06-26 10:54:18 -07:00
Herrington Darkholme 962aee93cd fix #16702: polish type predicate error message 2017-06-26 13:32:29 +08:00
Maxwell Paul Brickner 4f1ae1a406 Updated links to use https and avoid redirects
Howdy!

I updated some links to use https instead of http.

www.typescriptlang.org/playground/ now redirects to www.typescriptlang.org/play/

Thank you for your time! ^ _ ^
2017-06-23 15:51:12 -04:00
Anders Hejlsberg 24a6a087f5 Add early bail out for token nodes 2017-06-23 08:31:48 -10:00
Andy fd22a88abc Code cleanup in jsTyping.ts (#16632) 2017-06-23 10:03:01 -07:00
Charles Pierce 8418d67ebb Fix missed lint error 2017-06-22 21:01:05 -07:00
Charles Pierce 386454a255 #16300 #16301 Diagnostics for default export in namespace 2017-06-22 20:20:41 -07:00
Nathan Shively-Sanders 6a111928b4 Merge pull request #16375 from Microsoft/skip-block-scope-for-global-symbol
Skip block scope check for global symbol
2017-06-22 15:29:35 -07:00
Kanchalai Tanglertsampan d0bb6e1e8a Update symbols baselines from re-ordering of the signatures 2017-06-22 13:45:14 -07:00
Kanchalai Tanglertsampan 77d69c8c1d Add tests and update baselines 2017-06-22 11:56:49 -07:00
Anders Hejlsberg fd1e5ab6ed Simplify forEachChild 2017-06-22 08:55:18 -10:00
Kanchalai Tanglertsampan feefd520b6 Reorder promise.all signatures 2017-06-22 11:51:00 -07:00
Ryan Cavanaugh 04d750f9f8 Preserve method comments in JS->ES6 conversion. Fixes #16622 2017-06-22 11:45:34 -07:00