97de830744
Fix contextual typing sensitivity to binding pattern structure without hardcoded values
...
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-29 05:34:38 +00:00
65ba292f29
Remove debug file
...
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-29 04:35:15 +00:00
869eb505d5
Fix contextual typing sensitivity to binding pattern structure
...
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-29 04:32:36 +00:00
649c90af15
Fix contextual typing sensitivity to binding pattern structure
...
Modified getTypeFromArrayBindingPattern to make contextual type construction
agnostic to whether tuple destructuring elements have binding names. When
includePatternInType is true, cap minLength at 2 to ensure consistent
contextual types regardless of binding pattern variations.
This fixes an issue where [, , t] and [, s, ] produced different contextual
types, causing inconsistent generic type inference and spurious excess
property errors.
Addresses feedback in #41548 about making contextual types position-agnostic.
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-29 00:01:39 +00:00
4235412daa
Detailed investigation of tuple destructuring excess property issue
...
Reverted all previous changes and conducted thorough analysis of the root cause.
Found that the issue is related to contextual typing and generic type inference,
not specifically the "last element position" but rather the pattern of
first element omitted + last element named.
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-28 22:47:22 +00:00
31a298b0a2
Final fix: restrict heuristic to simple string literal unions only
...
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-28 22:02:28 +00:00
dd30988866
Refine excess property check heuristic for constraint types
...
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-28 21:57:21 +00:00
7adcf162bf
Add support for type parameters in isKnownProperty and create test case
...
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-07-28 21:49:10 +00:00
07bdeb7f86
Initial plan
2025-07-28 21:17:47 +00:00
be86783155
Give more specific errors for verbatimModuleSyntax ( #62113 )
2025-07-23 15:38:01 -07:00
22ef57786f
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250714192406710 to main ( #62068 )
2025-07-22 13:23:03 -07:00
d5a414cd1d
Don't use noErrorTruncation when printing types with maximumLength set ( #62091 )
2025-07-22 08:56:52 -07:00
f14b5c8a2f
Remove unused and confusing dom.iterable.d.ts file ( #62037 )
2025-07-21 14:30:30 -07:00
2778e84ed8
Restore AbortSignal.abort ( #62086 )
2025-07-17 11:27:15 -07:00
65cb4bd2d5
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250710202354753 to main ( #62038 )
2025-07-10 13:45:15 -07:00
9e20e032ef
Clear out checker-level stacks on pop ( #62016 )
2025-07-08 07:54:20 -07:00
87740bc7fe
Fix for Issue 61081 ( #61221 )
2025-07-07 13:30:01 -07:00
833a8d492c
Fix Symbol completion priority and cursor positioning ( #61945 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com >
Co-authored-by: Ryan Cavanaugh <RyanCavanaugh@users.noreply.github.com >
2025-07-02 14:46:24 -07:00
0018c9ff12
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250702194908541 to main ( #61992 )
2025-07-02 14:35:28 -07:00
fe698aef28
Just add a trailing call to visitNode instead of creating a new array when collecting outlining spans ( #61987 )
2025-07-02 10:18:12 -07:00
441655c270
DOM Update 2025-06-18 ( #61986 )
2025-07-01 18:49:19 -07:00
8518a8764e
fix Intl.Segments#containing return value type ( #61236 )
2025-07-01 17:10:50 -07:00
6d684e34e4
Restore repo dispatch for twoslash-repros workflow ( #60682 )
2025-07-01 09:33:39 -07:00
3ba257ffac
fix: diagnostic message for class name 'Object' when targeting different ECMAScript versions ( #61850 )
2025-06-30 15:46:33 -07:00
666ef27201
Fix Copilot instructions to emphasize mandatory lint, test, and format steps ( #61950 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-06-30 15:22:28 -07:00
e58dde511c
perf: improve regexp performance by using non-capturing groups ( #58551 )
2025-06-30 15:12:49 -07:00
5fd65f3189
Bump the github-actions group across 1 directory with 3 updates ( #61804 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-30 14:53:13 -07:00
1ea1809e16
Properly disallow yield in bodyless arrows ( #61976 )
2025-06-30 14:52:49 -07:00
b70d4d7e4b
Revert change to type print in an error message ( #61977 )
2025-06-30 14:30:04 -07:00
91cdbd518c
Fixed nullish coalesce operator's precedence ( #61372 )
2025-06-30 13:49:03 -07:00
58665cf3ae
Don't return tags when returning quick info for JSDoc nodes ( #59816 )
2025-06-30 13:20:08 -07:00
c35b14335a
Keep accessors as accessors in emitted anonymous class declarations ( #60853 )
2025-06-30 13:19:53 -07:00
3267e426e3
Handle silentNeverType in iteration-related functions ( #61317 )
2025-06-30 12:52:51 -07:00
5519be3ae1
Fixed crash when getting a definition for a class member with a computed name and an override modifier ( #60631 )
2025-06-30 12:48:39 -07:00
2ea2ecfdc1
Fixed crash in hasVisibleDeclarations related to binding elements ( #61352 )
2025-06-30 11:57:47 -07:00
c33f83ac9b
Fixed a printer crash caused by empty parameter modifiers ( #60537 )
2025-06-30 11:14:10 -07:00
b46556e7b7
Fixed JSDoc display on JsxNamespacedName attributes ( #61825 )
2025-06-30 11:07:48 -07:00
88b3bea6df
Fix typo in nightly yaml ( #61906 )
2025-06-30 10:42:59 -07:00
8665f920c9
Fixed crash on ComputedPropertyName when computing interactive inlay hints ( #61857 )
2025-06-30 10:28:27 -07:00
36f7fbaded
Improve release publisher pipeline ( #61551 )
2025-06-30 10:26:51 -07:00
d297037a83
Fixed crash on ConstructSignature when computing interactive inlay hints ( #61973 )
2025-06-30 10:21:50 -07:00
dfb7488978
Fix capitalisation for checkJs ( #61795 )
2025-06-29 09:24:21 -07:00
efeb135c6f
Revert #54442 and add a testcase ( #61955 )
2025-06-27 08:52:58 -07:00
02672d281c
Use jsx language variant for jsx file scanning in getChildren ( #61928 )
2025-06-25 15:37:21 -07:00
f3a6d3165f
Update copilot-setup-steps.yml ( #61948 )
2025-06-25 14:35:09 -07:00
6e519c59c1
Fix BigInt literal error in ambient contexts when targeting < ES2020 ( #61935 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-06-25 14:29:50 -07:00
1ed8674bba
Allow accessor properties in ambient contexts when targeting ES5 ( #61927 )
...
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com >
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com >
2025-06-25 14:29:02 -07:00
d6c3ac3684
Add line endings and printf debugging section ( #61947 )
2025-06-25 10:31:27 -07:00
e6a50a7861
Use strict subtype relation in getCommonSupertype ( #61903 )
2025-06-24 15:38:59 -07:00
dca71700ba
Fix bad JSON syntax in tests, use JSON.parse first for perf ( #61901 )
2025-06-24 14:51:46 -07:00
copilot-swe-agent[bot]
Daniel Rosenwasser
CSIGS@microsoft.com
Mateusz Burzyński
Jake Bailey
Nathan Shively-Sanders
Julian Taub
Kenta Moriuchi
Idan Goshen
Anthony Fu
dependabot[bot]
Duncan Steele
Roman A
Ryan Cavanaugh
Gabriela Araujo Britto
Anders Hejlsberg