Commit Graph
45 Commits
Author SHA1 Message Date
Jesse TrinityandNathan Shively-Sanders 111ca92646 Fix parser regression for bad related diagnostic on missing matching brackets (#44158)
* Revert "Revert #43460 and #40884 (#44175)"

This reverts commit 5770434891.

* fix missing opening brace match error

* refactor parseExpectedMatchingBrackets

* use getNodePos

* accept baselines

* delete mistakenly added files

* Revert getNodePos addition

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2022-03-15 17:29:41 -07:00
Jesse TrinityandAndrew Branch 753feb8707 importModuleSpecifierEnding changes .ts string completions to .js (#44602)
* don't add .ts extensions to imports

* Update src/services/stringCompletions.ts

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

* add other supported extension types

* add final newlines

* adress PR comment

* add unsupported extension test

Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>
2021-06-21 14:43:33 -07:00
Jesse Trinity 5770434891 Revert #43460 and #40884 (#44175)
* Revert "Only issue matching token errors on non-dupe locations (#43460)"

This reverts commit 76a2ae3d69.

* Revert "Adding Diagnostic message for missing ']' and ')' in Array literal and conditional statements (#40884)"

This reverts commit 555ef73da8.

* re-add clobbered merge lines
2021-05-19 16:54:07 -07:00
Jesse Trinity d640313ff2 Expand extractSymbol ranges (#42770)
* allow partial selections of node ranges

* separate tests for better failure investigation

* gate span expansion behind invoked command

* add invoked test

* comment wording

* for test
2021-02-17 12:55:12 -08:00
1b19af0f14 Refactor params for interface (#42652)
* apply refactor to interface methods

* handle calls

* no available refactors for union type

* add tests

* Update src/services/refactors/convertParamsToDestructuredObject.ts

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* address comments

* Update src/services/refactors/convertParamsToDestructuredObject.ts

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Update src/services/refactors/convertParamsToDestructuredObject.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2021-02-09 13:30:31 -08:00
Jesse Trinity 8bbef818ed Hierarchical refactorings (#41975)
* add hierarchical refactoring strings

* fourslash tests

* extractSymbol filters returned actions

* move refactorKind check to utilities

* rename parameters

* messaging for addOrRemoveBracesToArrowFunction

* fix up inferFunctionReturnType

* fix up convertArrowFunctionOrFunctionExpression

* add preferences to fourslash method

* fix up convert string

* fix up moveToNewFile

* fix lint errors

* remove extra arrow braces diagnostics

* break out tests

* add refactor helpers

* refactor refactors

* keep list of actions

* address PR comments

* response protocol

* address more comments
2020-12-23 12:50:03 -08:00
Jesse Trinity d88ea4e1f8 address PR comments 2020-06-02 19:06:12 -07:00
Jesse Trinity fb3a84c4f1 fix line endings 2020-06-01 14:15:02 -07:00
Jesse Trinity ca58c0e03c fix merge conflicts 2020-05-29 14:04:07 -07:00
Jesse Trinity a86a2fa703 polish tests 2020-05-29 13:03:14 -07:00
Jesse Trinity 2db0054444 remove outdated tests 2020-05-29 13:03:11 -07:00
Jesse Trinity f479279217 convert import trigger reason test 2020-05-29 13:03:08 -07:00
Jesse Trinity 06d2461cd0 convert import trigger reason only 2020-05-29 13:03:05 -07:00
Jesse Trinity c20908a3e7 convert export trigger reason test 2020-05-29 13:03:01 -07:00
Jesse Trinity a7c07d67d8 convert export cursor only changes 2020-05-29 13:02:57 -07:00
Jesse Trinity 4971c7d546 remove declaration 2020-05-29 13:02:55 -07:00
Jesse Trinity 3e1e61470b Revert "update refactorConvertImport_partialSelection"
This reverts commit e28d8a0895f118321c37016a6dad4751a7c13673.
2020-05-29 13:02:52 -07:00
Jesse Trinity a07a79b772 remove unused test method 2020-05-29 13:02:49 -07:00
Jesse Trinity e565931392 fix up some bools 2020-05-29 13:01:33 -07:00
Jesse Trinity d37f4c33cc accept new baseline 2020-05-29 12:55:56 -07:00
Jesse Trinity 86122c412f convert get set test 2020-05-29 12:55:52 -07:00
Jesse Trinity 673a86833a update test names 2020-05-29 12:55:48 -07:00
Jesse Trinity 3825d193f6 extract symbol test 2020-05-29 12:55:43 -07:00
Jesse Trinity df8ff659c5 extract type test 2020-05-29 12:55:39 -07:00
Jesse Trinity 85e0d8b14a add refactorNotAvailableForTriggerReason 2020-05-29 12:55:35 -07:00
Jesse Trinity dc363f10fc fix some indices 2020-05-29 12:55:32 -07:00
Jesse Trinity fbf6737ae2 use verify trigger reason for import export 2020-05-29 12:55:28 -07:00
Jesse Trinity 96f210c1c8 arrow function refactor test 2020-05-29 12:55:24 -07:00
Jesse Trinity f3751fbdf3 change type of RefactorTriggerReason 2020-05-29 12:54:59 -07:00
Jesse Trinity 23e00644f4 accept new baseline 2020-05-29 12:50:23 -07:00
Jesse Trinity 665e434832 convert import tests 2020-05-29 12:50:18 -07:00
Jesse Trinity 57e856b0b4 convert export tests 2020-05-29 12:50:14 -07:00
Jesse Trinity 23f4dc9bd9 use enum for RefactorTriggerReason 2020-05-29 12:49:41 -07:00
Jesse Trinity 53e8ed0089 accept new baseline 2020-05-29 12:46:07 -07:00
Jesse Trinity c5343f1d4e update refactorConvertImport_partialSelection 2020-05-29 12:46:03 -07:00
Jesse Trinity f1127e6e94 extract symbol 2020-05-29 12:45:57 -07:00
Jesse Trinity 602ee995d0 fix lint errors 2020-05-29 12:45:54 -07:00
Jesse Trinity 55880ee5e0 extractType explicitCursorRequest 2020-05-29 12:41:28 -07:00
Jesse Trinity 0296254a60 extractType 2020-05-29 12:41:22 -07:00
Jesse Trinity 1efcffc915 convertImport 2020-05-29 12:41:18 -07:00
Jesse Trinity c3828ed086 loosen convertExport conditions 2020-05-29 12:41:14 -07:00
Jesse Trinity 02fa39a6a9 enable explicit requests for addOrRemoveBracesToArrowFunction 2020-05-29 12:41:10 -07:00
Jesse Trinity bac046573f add trigger reason to protocol 2020-05-29 12:41:06 -07:00
Jesse Trinity 7fd1e62a63 accepted new baselines 2019-02-06 14:37:26 -08:00
Jesse Trinity f0a6154e9b Added auto setting to quotePreference 2019-02-06 14:37:26 -08:00