Commit Graph
100 Commits
Author SHA1 Message Date
Ryan Cavanaugh 4978b3ebeb Properly detect explicitly-set targets (#51834) 2022-12-09 10:31:51 -08:00
Ryan Cavanaugh a3dbe7dc70 Update default target from ES3 to ES5 (#51731)
* Change the default emit target to ES5

* Add baseline update

* Remove tests with a hardcoded sourcemap in it

* Update hardcoded tests

* Merge with main

* Restore tests
2022-12-08 16:43:47 -08:00
Ryan Cavanaugh 9089d5390a Unconditionally call checkExpression from checkSatisfiesExpression (#51704)
* Unconditionally call `checkExpression` in `checkSatisfiesExpression`

* A testcase
2022-12-01 09:11:37 -08:00
Ryan Cavanaugh 3557092b14 Rephrase error message to be 100% technically correct (#50471) 2022-08-26 14:22:49 -07:00
Ryan Cavanaugh adf26ffa4b Revert "Fixed an issue with contextual type for intersection properties (#48668)" (#50279)
This reverts commit 9236e39374.
2022-08-12 10:24:50 -07:00
Ryan Cavanaugh 1a4643bdce Flag resolution mode assertions in non-nightly builds (#49002)
* Flag resolution mode assertions in non-nightly builds

* Add checker check
2022-05-06 16:31:40 -07:00
Ryan Cavanaugh 9153eaaee0 Reserve a core in runtests-parallel on non-CI machines (#48502) 2022-03-31 21:27:58 -07:00
Ryan Cavanaugh 7addca63ae Update issue templates (#48261) 2022-03-15 14:43:46 -07:00
Ryan Cavanaugh a4f5555e09 Move hasOwn from Object instance to Object constructor (#48207)
Fixes #48206
2022-03-10 15:28:47 -08:00
Ryan Cavanaugh af027f34fa Bail on 0- and 1-length lists in removeSubtypes to avoid spurious circularity problems (#46981)
* Creates a reasonable workaround for #46939

* Remove unrelated newline

* Do the cheap length check ahead of the cache check

* Actually do it.
2022-03-08 08:50:07 -08:00
Ryan Cavanaugh 2172e1964f Correctly check computed property names in type-space get/set accessors (#47156)
* Add test that should fail

* Make it fail

Fixes #47146

* Baselines
2022-02-01 12:49:05 -08:00
Ryan Cavanaugh ab043f99db Create SECURITY.md (#45474)
Fixes #45452
2021-08-16 13:54:30 -07:00
Ryan Cavanaugh e00b5ecd40 Enable max-statements-per-line lint rule (#45475)
* Enable the rule

* Fix all the violations
2021-08-16 13:53:51 -07:00
Ryan Cavanaugh 5afe42e14e Rename strictOptionalProperties -> exactOptionalPropertyTypes and remove from strict family (#44626) 2021-06-17 15:12:19 -07:00
Ryan Cavanaugh 4c018818c1 Add a testcase that fails when someone tried to make an Object.keys PR (#44368) 2021-06-01 10:58:59 -07:00
Ryan Cavanaugh b1ab2b98be Wire up 'writing' parameter through protected derived class detection (#43455)
Fixes #43443
2021-04-19 09:20:21 -07:00
Ryan Cavanaugh 294a5a7d78 Remote duplicated assignment (#43399) 2021-03-29 21:30:45 -07:00
Ryan Cavanaugh 451089e8ef Rename isWrite -> writing (#43405) 2021-03-27 21:56:50 -07:00
Ryan Cavanaugh ff233a9ac2 Variant accessors (#42425)
Allows accessors to have different access modifiers and types

Fixes #2845, #2521
2021-03-26 20:11:02 -07:00
Ryan Cavanaugh 79d3058b83 Don't crash when renaming a JS property declared via module.exports (#40297)
Fixes #38070

When the originating definition was of the form
```js
module.exports.foo = expr
```
we were incorrectly trying to call `resolveName` on just the `foo` portion to get the "local" symbol, which simply failed to resolve (or would have resolved to the wrong thing), but for this form, the local symbol is just the containing property access expression
2021-03-11 07:23:19 -08:00
Ryan Cavanaugh f5618562ab Check for missing type parameter names in JSDoc template tags (#42017)
* Check for missing type parameter names in JSDoc template tags

Fixes #36692

* Update baselines
2021-02-17 16:54:56 -08:00
Ryan CavanaughandDaniel Rosenwasser 22f452c5cd Update issue templates (#42049)
* Update issue templates

* Update .github/ISSUE_TEMPLATE/Bug_report.md

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/lib_change.md

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/lib_change.md

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/lib_change.md

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Update .github/ISSUE_TEMPLATE/lib_change.md

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Swap some orderings

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2020-12-22 09:04:56 -08:00
Ryan Cavanaugh 9a957e7b9c Remove incorrect assert that triggers crash on completions of globalThis (#40278)
Fixes #39338
2020-12-02 11:47:32 -08:00
Ryan Cavanaugh 21d781fa54 Fix incorrect name of index signature flag in implementation (#40541) 2020-09-14 09:32:22 -07:00
Ryan Cavanaugh ea51fabb7c Don't crash when observing invalid 'export' in object literal (#40295)
Fixes #32870
2020-09-11 17:18:23 -07:00
Ryan CavanaughandAndrew Branch 3d235b42a0 --noUncheckedIndexedAccess (#39560)
* Initial implementation + tests

* linty

* Support destructuring declarations and assignments

* lint

* Fix destructuring assignment and element access into known properties

* Update baselines

* Rename flag to unUncheckedIndexedAccess

* Add test for unique symbol indexing

* Fix flag order in baselines

Co-authored-by: Andrew Branch <andrew@wheream.io>
2020-09-11 14:43:10 -07:00
Ryan CavanaughandDaniel Rosenwasser b969b58399 Use a correct Object.entries polyfill (#40268)
* Use a correct Object.entries polyfill

Fixes #40243

* Update src/compiler/core.ts

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

* Added parentheses, DANIEL.

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
2020-08-28 09:09:55 -07:00
Ryan CavanaughandNathan Shively-Sanders 823f5fba86 Update README.md (#39074)
* Update README.md

Updates 404 link per #38974. Not sure if this is the best destination.

* Update README.md

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
2020-06-16 10:26:28 -07:00
Ryan Cavanaugh 84c83da3a9 Revert #37106 (#38172) 2020-04-24 16:04:33 -07:00
Ryan Cavanaugh 0426e48828 Fix crash when host.getSourceFile returns undefined (#37373)
Another day, another incorrect non-null assertion

Fixes #37368
2020-03-12 15:45:56 -07:00
Ryan Cavanaugh d727d5a5eb Remove 'path' from assert call (#37372)
Fixes #37369
2020-03-12 15:11:05 -07:00
Ryan Cavanaugh 67930fc163 Don't crash when there's no class type to derive a 'this' type from (#37164)
Fixes #37161
2020-03-04 09:34:28 -08:00
Ryan Cavanaugh 0c5878dfb1 symbol.parent really is possibly sometimes undefined here. (#37159)
Fixes #37158
2020-03-03 10:47:07 -08:00
Ryan Cavanaugh f4e371c731 Harden findAllReferences.ts against symbol.declarations = undefined cases (#37088)
Fixes #37086
2020-02-27 14:55:49 -08:00
Ryan Cavanaugh 35aea8bbfa Remove crashing diagnostic code that wasn't helping us (#36913) 2020-02-27 12:45:28 -08:00
Ryan Cavanaugh c4e96856ac Detect circularities when removing 'undefined' from defaulted params (#37023)
Fixes #37008

Note that referencing a variable in its initializer is a TDZ error;
the OP report had OOB logic that prevented this in practice (?)
2020-02-26 14:59:04 -08:00
Ryan Cavanaugh 43863cafe2 Check for undefined source.symbol (#37021)
Fixes #37014
2020-02-25 13:46:24 -08:00
Ryan Cavanaugh c22cdb446a Harden telemetryOnOpenFile (#36993) 2020-02-25 11:32:32 -08:00
Ryan Cavanaugh 2b69b2281a Properly handle both special export forms when renaming (#36914)
* Properly handle both special export forms when renaming

Fixes #36713

* Lint
2020-02-24 13:17:02 -08:00
Ryan Cavanaugh fcd55c21a1 Update CONTRIBUTING.md (#36553) 2020-02-24 09:00:24 -08:00
Ryan Cavanaugh 05cbe5ac8e Update issue reports agian (#34768)
* Update issue templates

* Add config.yml

* Updates

* Updates
2019-10-28 11:15:31 -07:00
Ryan Cavanaugh a28fcebff2 Update issue templates (#34767)
* Update issue templates

* Add config.yml
2019-10-28 11:12:20 -07:00
Ryan Cavanaugh 5e4cd0594e Update CONTRIBUTING.md 2019-10-24 16:49:51 -07:00
Ryan Cavanaugh 6b63c1bc5c Rename this function so it stops shadowing a local we use elsewhere (#33692) 2019-10-01 10:37:53 -07:00
Ryan Cavanaugh 016884d48c Add assert comments in CodeFixes and Refactors (#33016)
* Add comments to assert calls

* Add comments to assert calls in codefixes

* So linty
2019-08-21 14:22:17 -07:00
Ryan Cavanaugh 0bc3468733 small refactor to cut back on type assertions (#32920) 2019-08-15 15:18:27 -07:00
Ryan Cavanaugh 11c28d6dd0 Update versions to 3.7 (#32879)
* Update versions to 3.7

* Update API baselines
2019-08-14 13:00:26 -07:00
Ryan Cavanaugh a86fa20b02 Don't pass a candidates array to getResolvedSignature (#31203)
Found when investigating #30505
2019-05-01 13:59:55 -07:00
Ryan Cavanaugh d102ec0194 Better typings for promise.race based on conditional types (#31117)
Following the feature - Mapped tuple types #25947 - it is now possible to have better typings for Promise.race
2019-04-30 09:23:27 -07:00
Ryan Cavanaugh 867c992021 Update pull_request_template.md 2019-04-25 14:45:44 -07:00
Ryan Cavanaugh 885d4d63c8 Remove "generate types" code (#31075) 2019-04-23 13:51:47 -07:00
Ryan Cavanaugh d60c6a02f8 Fix missing baseline diff (#30770)
Fixes an odd build break in master
2019-04-05 09:06:00 -07:00
Ryan Cavanaugh b15e64feba Merge pull request #30336 from Microsoft/update-pr-template
Update pull_request_template.md
2019-03-12 12:54:48 -07:00
Ryan Cavanaugh 4fb370d944 Update pull_request_template.md 2019-03-12 08:45:59 -07:00
Ryan Cavanaugh c9fd1c3728 Merge pull request #30278 from Microsoft/fasterhash
Improve performance of fallback hash function
2019-03-09 06:36:04 -08:00
Ryan Cavanaugh 156566311b Rewrite fallback hash to be faster 2019-03-08 16:38:02 -08:00
Ryan Cavanaugh 5ec5e0466d Merge pull request #30136 from RyanCavanaugh/no-mkdir-race
Don't crash if someone created a folder while we were checking to see if it exists
2019-02-27 15:43:14 -08:00
Ryan Cavanaugh 93fa734162 Don't crash if someone created a folder while we were checking to see if it exists 2019-02-27 14:33:25 -08:00
Ryan Cavanaugh 9d9cfaff16 Merge pull request #29948 from tomholub/patch-1
update docs: dated build cmd
2019-02-19 10:23:56 -08:00
Ryan Cavanaugh d517713f50 Merge pull request #29935 from RyanCavanaugh/md5_2_sha
Use sha256 to hash file contents
2019-02-15 10:28:23 -08:00
Ryan Cavanaugh 7983813be0 Use sha256 to hash file contents 2019-02-15 09:03:15 -08:00
Ryan Cavanaugh cc987a1921 Merge pull request #29896 from dragomirtitian/GH-29778
Improve error message for using value as type
2019-02-14 13:14:20 -08:00
Ryan Cavanaugh 75101d4b72 Merge pull request #29860 from RyanCavanaugh/noEval
Enable no-eval rule
2019-02-11 11:47:05 -08:00
Ryan Cavanaugh 02a5ef6a17 Add setInterval/setTimeout 2019-02-11 11:26:19 -08:00
Ryan Cavanaugh 1f10e74abc Enable no-eval rule 2019-02-11 11:18:29 -08:00
Ryan Cavanaugh 2dfb6202ed Merge pull request #27697 from mattmccutchen/issue-27118
Make the assignability rule for conditional types require the check types and distributivity to be identical.
2019-02-10 19:51:02 -08:00
Ryan Cavanaugh eed9db5ec5 Merge pull request #28465 from alangpierce/enforce-const-enum-access-for-isolatedmodules
Change isolatedModules to allow const enum declaration and disallow access
2019-02-05 16:36:58 -08:00
Ryan Cavanaugh 1ec8a71949 Merge pull request #29711 from jack-williams/switch-on-unknown
Fix #29710: Narrow unknown in switch
2019-02-05 09:08:52 -08:00
Ryan Cavanaugh 4ff71ecb98 Merge pull request #29696 from Microsoft/filter-unknown
Use unknown for array predicates' return types
2019-02-04 13:26:29 -08:00
Ryan Cavanaugh 0a041ee536 Merge pull request #28270 from AnyhowStep/json-parse-reviver-stringify-replacer-better-declaration
JSON.parse(), JSON.stringify() more specific declarations for #6955
2019-02-02 12:10:56 -08:00
Ryan Cavanaugh efbe630a13 Use unknown for array predicates' return types 2019-02-01 17:05:04 -08:00
Ryan Cavanaugh 5bcf251f8a Merge pull request #28125 from fullheightcoding/typos
Fixed some typos.
2019-02-01 16:48:13 -08:00
Ryan Cavanaugh a856a64a5c Merge pull request #29446 from fuafa/infer-js-doc
fix quick fix infer parameter types from usage in js file
2019-02-01 13:55:31 -08:00
Ryan Cavanaugh f81ea89564 Merge pull request #29136 from ajafff/usedbeforedeclaration-objectspread
property is used before its initialization: check more nodes
2019-02-01 13:46:37 -08:00
Ryan Cavanaugh 02b1f71612 Merge branch 'master' into typos 2019-02-01 13:43:44 -08:00
Ryan Cavanaugh 9d3707d671 Merge pull request #29665 from ajafff/readonly-error-message
clarify error message for 'readonly' type operator
2019-02-01 11:24:38 -08:00
Ryan Cavanaugh 5d3685d041 Merge pull request #28240 from ajafff/add-to-types2
Only suggest adding to types if present in compilerOptions
2019-01-31 09:34:59 -08:00
Ryan Cavanaugh aad609c74f Merge pull request #29298 from ajafff/this-reference-in-parameter
Allow referencing 'this' in parameters of functions in the constructor
2019-01-30 19:13:18 -08:00
Ryan Cavanaugh caa8dc25a8 Merge pull request #29115 from KromDaniel/patch-1
Duplicate `wait` instead of `wait` and `notify` at `es2017.sharedmemory.d.ts`
2019-01-30 19:12:46 -08:00
Ryan Cavanaugh 2f7627b363 Merge pull request #28190 from ispedals/bug/24709
Support synthesized SourceFile parent in getOrCreateEmitNode (#24709)
2019-01-30 19:12:11 -08:00
Ryan Cavanaugh ec9652d9d6 Merge pull request #27934 from mayn/spelling
fix spelling errors
2019-01-30 19:09:22 -08:00
Ryan Cavanaugh 0df89cc96f Merge pull request #26941 from jack-williams/narrow-unknown-with-triple-equals
Fix #25172: Add narrowing for `unknown` with triple equals
2019-01-29 16:43:50 -08:00
Ryan Cavanaugh ebf90871c6 Merge pull request #29584 from yacaovsnc/master
Remove extra http str in badge url
2019-01-25 13:28:14 -08:00
Ryan Cavanaugh c779fc7998 Merge pull request #28034 from disisisid/master
Typo fix in src/lib/README.md
2019-01-24 14:45:31 -08:00
Ryan Cavanaugh 04cb422abf Merge pull request #28124 from sanket0896/patch-1
Fixed typos in spec.md
2019-01-24 14:44:05 -08:00
Ryan Cavanaugh 61b07e7bc5 Merge pull request #28181 from superkd37/patch-1
Update .mailmap
2019-01-24 14:40:55 -08:00
Ryan Cavanaugh 66e44eef71 Merge pull request #27991 from manishbansal8843/gulpfile-correction-for-word2mdconversion
Correcting the order of passing arguments to word2mdJs for the task generating spec.md
2019-01-24 14:38:32 -08:00
Ryan Cavanaugh 1a742e6f27 Merge pull request #27918 from collin5/b27914
Improve error message for duplicate property with computed name
2019-01-24 14:35:51 -08:00
Ryan Cavanaugh 3249e0f4ad Merge pull request #27480 from AjayPoshak/make-contrib-easy
Add points to guideline to make contributions easier
2019-01-24 13:50:16 -08:00
Ryan Cavanaugh d85c4e551e Merge pull request #27121 from xl1/26977-typedarray
Allow non-number source for TypedArray.from
2019-01-24 13:42:43 -08:00
Ryan Cavanaugh 95eec999e8 Tweaks 2019-01-24 13:31:44 -08:00
Ryan Cavanaugh 16b6706ee1 Merge pull request #29463 from jack-williams/check-in-expression-with-union
Fix #29457
2019-01-24 13:07:22 -08:00
Ryan Cavanaugh d782a546a5 Merge pull request #29556 from fuafa/trailing-comma
fix trailing comma should not allowed in dynamic import argument
2019-01-24 10:20:26 -08:00
Ryan Cavanaugh 2f6c65e691 Merge pull request #26653 from Kingwl/improve_type_arguments_parser_1
parse less than token rather than left shift in context of type argum…
2019-01-23 16:21:12 -08:00
Ryan Cavanaugh ebebc9fdb6 Merge pull request #29546 from chrisrpatterson/update-badge-url
Updating badge url
2019-01-23 12:49:42 -08:00
Ryan Cavanaugh b64d08a21b Merge pull request #27522 from jack-williams/trailing-void-args-are-optional
Fix #4260 : Allow trailing arguments that accept void to be omitted
2018-10-19 10:16:56 -07:00
Ryan Cavanaugh fc788393ab Merge pull request #26810 from Kingwl/fix_lookup_regression_again_and_again
fix lookup regression again and again
2018-10-10 09:44:37 -07:00
Ryan Cavanaugh 6e5f477a89 Merge pull request #27608 from flowkraD/isPartOfTypeNode
Added ObjectKeyword check to isPartOfTypeNode
2018-10-08 11:34:19 -07:00
Ryan Cavanaugh f53a27eac0 Merge pull request #27515 from basarat/master
📝 Better description of Pick mapped type
2018-10-03 09:56:20 -07:00
Ryan Cavanaugh 5666be682c Merge pull request #27517 from brandonmbanks/typo-comments
fix typo in performance mark name
2018-10-03 09:41:11 -07:00