Remove older deprecated APIs (#52338)

This commit is contained in:
Sheetal Nandi
2023-01-20 12:55:04 -08:00
committed by GitHub
parent 181cf21b68
commit e5515164eb
14 changed files with 17 additions and 70 deletions
+2 -10
View File
@@ -5023,11 +5023,6 @@ export function parseConfigHostFromCompilerHostLike(host: CompilerHostLike, dire
};
}
// For backward compatibility
/** @deprecated */ export interface ResolveProjectReferencePathHost {
fileExists(fileName: string): boolean;
}
/** @internal */
export function createPrependNodes(
projectReferences: readonly ProjectReference[] | undefined,
@@ -5056,11 +5051,8 @@ export function createPrependNodes(
* Returns the target config filename of a project reference.
* Note: The file might not exist.
*/
export function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName;
/** @deprecated */ export function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName;
export function resolveProjectReferencePath(hostOrRef: ResolveProjectReferencePathHost | ProjectReference, ref?: ProjectReference): ResolvedConfigFileName {
const passedInRef = ref ? ref : hostOrRef as ProjectReference;
return resolveConfigFileProjectName(passedInRef.path);
export function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName {
return resolveConfigFileProjectName(ref.path);
}
/**
-3
View File
@@ -4893,9 +4893,6 @@ export enum ExitStatus {
// When build is skipped because project references form cycle
ProjectReferenceCycle_OutputsSkipped = 4,
/** @deprecated Use ProjectReferenceCycle_OutputsSkipped instead. */
ProjectReferenceCycle_OutputsSkupped = 4,
}
export interface EmitResult {
-10
View File
@@ -588,8 +588,6 @@ export interface ProjectServiceOptions {
pluginProbeLocations?: readonly string[];
allowLocalPluginLoads?: boolean;
typesMapLocation?: string;
/** @deprecated use serverMode instead */
syntaxOnly?: boolean;
serverMode?: LanguageServiceMode;
session: Session<unknown> | undefined;
}
@@ -969,8 +967,6 @@ export class ProjectService {
public readonly typesMapLocation: string | undefined;
/** @deprecated use serverMode instead */
public readonly syntaxOnly: boolean;
public readonly serverMode: LanguageServiceMode;
/** Tracks projects that we have already sent telemetry for. */
@@ -1017,15 +1013,9 @@ export class ProjectService {
if (opts.serverMode !== undefined) {
this.serverMode = opts.serverMode;
this.syntaxOnly = this.serverMode === LanguageServiceMode.Syntactic;
}
else if (opts.syntaxOnly) {
this.serverMode = LanguageServiceMode.Syntactic;
this.syntaxOnly = true;
}
else {
this.serverMode = LanguageServiceMode.Semantic;
this.syntaxOnly = false;
}
if (this.host.realpath) {
-3
View File
@@ -928,8 +928,6 @@ export interface SessionOptions {
eventHandler?: ProjectServiceEventHandler;
/** Has no effect if eventHandler is also specified. */
suppressDiagnosticEvents?: boolean;
/** @deprecated use serverMode instead */
syntaxOnly?: boolean;
serverMode?: LanguageServiceMode;
throttleWaitMilliseconds?: number;
noGetErrOnBackgroundUpdate?: boolean;
@@ -1001,7 +999,6 @@ export class Session<TMessage = string> implements EventSender {
pluginProbeLocations: opts.pluginProbeLocations,
allowLocalPluginLoads: opts.allowLocalPluginLoads,
typesMapLocation: opts.typesMapLocation,
syntaxOnly: opts.syntaxOnly,
serverMode: opts.serverMode,
session: this
};
-4
View File
@@ -39,10 +39,6 @@ export enum Msg {
Info = "Info",
Perf = "Perf",
}
export namespace Msg {
/** @deprecated Only here for backwards-compatibility. Prefer just `Msg`. */
export type Types = Msg;
}
export function createInstallTypingsRequest(project: Project, typeAcquisition: TypeAcquisition, unresolvedImports: SortedReadonlyArray<string>, cachePath?: string): DiscoverTypings {
return {
@@ -85,7 +85,7 @@ describe("unittests:: tsserver:: Inferred projects", () => {
};
const host = createServerHost([file1]);
const projectService = createProjectService(host, { useSingleInferredProject: true, syntaxOnly: true });
const projectService = createProjectService(host, { useSingleInferredProject: true, serverMode: ts.LanguageServiceMode.Syntactic });
projectService.openClientFile(file1.path, file1.content);
@@ -163,7 +163,7 @@ describe("unittests:: tsserver:: Projects", () => {
const externalProjectName = "externalproject";
const host = createServerHost([file1, config1]);
const projectService = createProjectService(host, { useSingleInferredProject: true, syntaxOnly: true });
const projectService = createProjectService(host, { useSingleInferredProject: true, serverMode: ts.LanguageServiceMode.Syntactic });
projectService.openExternalProject({
rootFiles: toExternalFiles([file1.path, config1.path]),
options: {},
@@ -193,7 +193,7 @@ describe("unittests:: tsserver:: Projects", () => {
};
const host = createServerHost([file1, config1]);
const projectService = createProjectService(host, { useSingleInferredProject: true, syntaxOnly: true });
const projectService = createProjectService(host, { useSingleInferredProject: true, serverMode: ts.LanguageServiceMode.Syntactic });
projectService.openClientFile(file1.path, file1.content);
checkNumberOfProjects(projectService, { inferredProjects: 1 });
@@ -219,7 +219,7 @@ describe("unittests:: tsserver:: Projects", () => {
};
const host = createServerHost([file1, config1]);
const projectService = createProjectService(host, { useSingleInferredProject: true, syntaxOnly: true });
const projectService = createProjectService(host, { useSingleInferredProject: true, serverMode: ts.LanguageServiceMode.Syntactic });
projectService.applyChangesInOpenFiles(ts.singleIterator({ fileName: file1.path, content: file1.content }));
checkNumberOfProjects(projectService, { inferredProjects: 1 });
@@ -44,7 +44,7 @@ import { something } from "something";
content: "{}"
};
const host = createServerHost([file1, file2, file3, something, libFile, configFile]);
const session = createSession(host, { syntaxOnly: true, useSingleInferredProject: true, logger: createLoggerWithInMemoryLogs(host) });
const session = createSession(host, { serverMode: ts.LanguageServiceMode.Syntactic, useSingleInferredProject: true, logger: createLoggerWithInMemoryLogs(host) });
return { host, session, file1, file2, file3, something, configFile };
}
@@ -79,7 +79,7 @@ import { something } from "something";
function verifyCompletions() {
verifySessionException<ts.server.protocol.CompletionsRequest>(session, {
command: ts.server.protocol.CommandTypes.Completions,
command: ts.server.protocol.CommandTypes.CompletionInfo,
arguments: protocolFileLocationFromSubstring(file1, "prop", { index: 1 })
});
}
@@ -155,7 +155,7 @@ function fooB() { }`
content: "{}"
};
const host = createServerHost([file1, file2, file3, something, libFile, configFile]);
const session = createSession(host, { syntaxOnly: true, useSingleInferredProject: true });
const session = createSession(host, { serverMode: ts.LanguageServiceMode.Syntactic, useSingleInferredProject: true });
const service = session.getProjectService();
openFilesForSession([file1], session);
checkNumberOfProjects(service, { inferredProjects: 1 });
-1
View File
@@ -28,7 +28,6 @@ export interface StartSessionOptions {
useInferredProjectPerProjectRoot: SessionOptions["useInferredProjectPerProjectRoot"];
suppressDiagnosticEvents: SessionOptions["suppressDiagnosticEvents"];
noGetErrOnBackgroundUpdate: SessionOptions["noGetErrOnBackgroundUpdate"];
syntaxOnly: SessionOptions["syntaxOnly"];
serverMode: SessionOptions["serverMode"];
}
+1 -3
View File
@@ -26,13 +26,12 @@ function findArgumentStringArray(argName: string): readonly string[] {
function start({ args, logger, cancellationToken, serverMode, unknownServerMode, startSession: startServer }: StartInput, platform: string) {
const syntaxOnly = hasArgument("--syntaxOnly");
logger.info(`Starting TS Server`);
logger.info(`Version: ${version}`);
logger.info(`Arguments: ${args.join(" ")}`);
logger.info(`Platform: ${platform} NodeVersion: ${getNodeMajorVersion()} CaseSensitive: ${sys.useCaseSensitiveFileNames}`);
logger.info(`ServerMode: ${serverMode} syntaxOnly: ${syntaxOnly} hasUnknownServerMode: ${unknownServerMode}`);
logger.info(`ServerMode: ${serverMode} hasUnknownServerMode: ${unknownServerMode}`);
setStackTraceLimit();
@@ -61,7 +60,6 @@ function start({ args, logger, cancellationToken, serverMode, unknownServerMode,
useInferredProjectPerProjectRoot: hasArgument("--useInferredProjectPerProjectRoot"),
suppressDiagnosticEvents: hasArgument("--suppressDiagnosticEvents"),
noGetErrOnBackgroundUpdate: hasArgument("--noGetErrOnBackgroundUpdate"),
syntaxOnly,
serverMode
},
logger,
+1 -17
View File
@@ -3054,10 +3054,6 @@ declare namespace ts {
Info = "Info",
Perf = "Perf"
}
namespace Msg {
/** @deprecated Only here for backwards-compatibility. Prefer just `Msg`. */
type Types = Msg;
}
namespace Errors {
function ThrowNoProject(): never;
function ThrowProjectLanguageServiceDisabled(): never;
@@ -3533,8 +3529,6 @@ declare namespace ts {
pluginProbeLocations?: readonly string[];
allowLocalPluginLoads?: boolean;
typesMapLocation?: string;
/** @deprecated use serverMode instead */
syntaxOnly?: boolean;
serverMode?: LanguageServiceMode;
session: Session<unknown> | undefined;
}
@@ -3606,8 +3600,6 @@ declare namespace ts {
readonly allowLocalPluginLoads: boolean;
private currentPluginConfigOverrides;
readonly typesMapLocation: string | undefined;
/** @deprecated use serverMode instead */
readonly syntaxOnly: boolean;
readonly serverMode: LanguageServiceMode;
/** Tracks projects that we have already sent telemetry for. */
private readonly seenProjects;
@@ -3818,8 +3810,6 @@ declare namespace ts {
eventHandler?: ProjectServiceEventHandler;
/** Has no effect if eventHandler is also specified. */
suppressDiagnosticEvents?: boolean;
/** @deprecated use serverMode instead */
syntaxOnly?: boolean;
serverMode?: LanguageServiceMode;
throttleWaitMilliseconds?: number;
noGetErrOnBackgroundUpdate?: boolean;
@@ -6306,9 +6296,7 @@ declare namespace ts {
DiagnosticsPresent_OutputsSkipped = 1,
DiagnosticsPresent_OutputsGenerated = 2,
InvalidProject_OutputsSkipped = 3,
ProjectReferenceCycle_OutputsSkipped = 4,
/** @deprecated Use ProjectReferenceCycle_OutputsSkipped instead. */
ProjectReferenceCycle_OutputsSkupped = 4
ProjectReferenceCycle_OutputsSkipped = 4
}
interface EmitResult {
emitSkipped: boolean;
@@ -9349,15 +9337,11 @@ declare namespace ts {
* Note: The file might not exist.
*/
function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName;
/** @deprecated */ function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName;
interface FormatDiagnosticsHost {
getCurrentDirectory(): string;
getCanonicalFileName(fileName: string): string;
getNewLine(): string;
}
/** @deprecated */ interface ResolveProjectReferencePathHost {
fileExists(fileName: string): boolean;
}
interface EmitOutput {
outputFiles: OutputFile[];
emitSkipped: boolean;
+1 -7
View File
@@ -2314,9 +2314,7 @@ declare namespace ts {
DiagnosticsPresent_OutputsSkipped = 1,
DiagnosticsPresent_OutputsGenerated = 2,
InvalidProject_OutputsSkipped = 3,
ProjectReferenceCycle_OutputsSkipped = 4,
/** @deprecated Use ProjectReferenceCycle_OutputsSkipped instead. */
ProjectReferenceCycle_OutputsSkupped = 4
ProjectReferenceCycle_OutputsSkipped = 4
}
interface EmitResult {
emitSkipped: boolean;
@@ -5357,15 +5355,11 @@ declare namespace ts {
* Note: The file might not exist.
*/
function resolveProjectReferencePath(ref: ProjectReference): ResolvedConfigFileName;
/** @deprecated */ function resolveProjectReferencePath(host: ResolveProjectReferencePathHost, ref: ProjectReference): ResolvedConfigFileName;
interface FormatDiagnosticsHost {
getCurrentDirectory(): string;
getCanonicalFileName(fileName: string): string;
getNewLine(): string;
}
/** @deprecated */ interface ResolveProjectReferencePathHost {
fileExists(fileName: string): boolean;
}
interface EmitOutput {
outputFiles: OutputFile[];
emitSkipped: boolean;
@@ -164,6 +164,6 @@ Output::
Found 1 error.
exitCode:: ExitStatus.ProjectReferenceCycle_OutputsSkupped
exitCode:: ExitStatus.ProjectReferenceCycle_OutputsSkipped
@@ -75,7 +75,7 @@ Info 7 [00:00:44.000] response:
}
Info 8 [00:00:45.000] request:
{
"command": "completions",
"command": "completionInfo",
"arguments": {
"file": "/user/username/projects/myproject/a.ts",
"line": 3,
@@ -92,7 +92,7 @@ FsWatches::
FsWatchesRecursive::
Info 9 [00:00:46.000] Request: completions not allowed in LanguageServiceMode.Syntactic
Info 9 [00:00:46.000] Request: completionInfo not allowed in LanguageServiceMode.Syntactic
Info 10 [00:00:47.000] request:
{
"command": "definitionAndBoundSpan",
@@ -159,7 +159,7 @@ Info 18 [00:01:03.000] response:
}
Info 19 [00:01:04.000] request:
{
"command": "completions",
"command": "completionInfo",
"arguments": {
"file": "/user/username/projects/myproject/a.ts",
"line": 3,
@@ -176,7 +176,7 @@ FsWatches::
FsWatchesRecursive::
Info 20 [00:01:05.000] Request: completions not allowed in LanguageServiceMode.Syntactic
Info 20 [00:01:05.000] Request: completionInfo not allowed in LanguageServiceMode.Syntactic
Info 21 [00:01:06.000] request:
{
"command": "definitionAndBoundSpan",