Microsoft/TypeScript
1
0 Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not offer completions for default module member symbol (#55231)

Browse Source
This commit is contained in:
Mateusz Burzyński authored and GitHub committed 2023-08-01 14:52:40 -07:00
1 parent b87e301822
commit defe33afa1
2 files changed
+17 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/compiler/checker.ts
+1 -1
View File
@@ -45463,7 +45463,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
if (meaning) {
source.forEach(symbol => {
// Similar condition as in `resolveNameHelper`
if (!getDeclarationOfKind(symbol, SyntaxKind.ExportSpecifier) && !getDeclarationOfKind(symbol, SyntaxKind.NamespaceExport)) {
if (!getDeclarationOfKind(symbol, SyntaxKind.ExportSpecifier) && !getDeclarationOfKind(symbol, SyntaxKind.NamespaceExport) && symbol.escapedName !== InternalSymbolName.Default) {
copySymbol(symbol, meaning);
}
});
tests/cases/fourslash/completionsDefaultKeywordWhenDefaultExportAvailable.ts
+16
View File
@@ -0,0 +1,16 @@
/// <reference path="fourslash.ts" />
// https://github.com/microsoft/TypeScript/issues/3229
// @filename: index.ts
//// export default function () {}
//// def/*1*/
verify.completions(
{
marker: "1",
includes: [{ name: "default", kind: "keyword", sortText: completion.SortText.GlobalsOrKeywords }],
},
);