When sending typings request use project's current directory as project root path

This ensures that we arent picking typings from folder different from the current directory for the project
This commit is contained in:
Sheetal Nandi
2018-01-22 14:33:42 -08:00
parent 1922c9a010
commit c57f266187
2 changed files with 5 additions and 15 deletions
@@ -6423,7 +6423,7 @@ namespace ts.projectSystem {
path: `${currentDirectory}/package.json`,
content: JSON.stringify({
devDependencies: {
"pkgcurrentdirectory": ""
pkgcurrentdirectory: ""
},
})
};
@@ -6475,6 +6475,9 @@ namespace ts.projectSystem {
// Ensure that we use result from types cache when getting ls
assert.isDefined(project.getLanguageService());
// Verify that the pkgcurrentdirectory from the current directory isnt picked up
checkProjectActualFiles(project, [file.path]);
});
});
}
+1 -14
View File
@@ -33,19 +33,6 @@ namespace ts.server {
export type Types = Err | Info | Perf;
}
function getProjectRootPath(project: Project): Path {
switch (project.projectKind) {
case ProjectKind.Configured:
return <Path>getDirectoryPath(project.getProjectName());
case ProjectKind.Inferred:
// TODO: fixme
return <Path>"";
case ProjectKind.External:
const projectName = normalizeSlashes(project.getProjectName());
return project.projectService.host.fileExists(projectName) ? <Path>getDirectoryPath(projectName) : <Path>projectName;
}
}
export function createInstallTypingsRequest(project: Project, typeAcquisition: TypeAcquisition, unresolvedImports: SortedReadonlyArray<string>, cachePath?: string): DiscoverTypings {
return {
projectName: project.getProjectName(),
@@ -53,7 +40,7 @@ namespace ts.server {
compilerOptions: project.getCompilationSettings(),
typeAcquisition,
unresolvedImports,
projectRootPath: getProjectRootPath(project),
projectRootPath: project.getCurrentDirectory() as Path,
cachePath,
kind: "discover"
};