mirror of
https://github.com/microsoft/TypeScript.git
synced 2025-11-18 17:21:48 +00:00
Error on excessive relation complexity (#55851)
This commit is contained in:
Anders Hejlsberg authored and 
GitHub committed
1 parent
fbe426e7d3
commit
c052bc7c72
6 files changed
+159
-1
No files matched your search
+32
-1
@@ -20778,6 +20778,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
|
||||
let skipParentCounter = 0; // How many errors should be skipped 'above' in the elaboration pyramid
|
||||
let lastSkippedInfo: [Type, Type] | undefined;
|
||||
let incompatibleStack: DiagnosticAndArguments[] | undefined;
|
||||
// In Node.js, the maximum number of elements in a map is 2^24. We limit the number of entries an invocation
|
||||
// of checkTypeRelatedTo can add to a relation to 1/8th of its remaining capacity.
|
||||
let relationCount = (16_000_000 - relation.size) >> 3;
|
||||
|
||||
Debug.assert(relation !== identityRelation || !errorNode, "no error reporting in identity checking");
|
||||
|
||||
@@ -20786,8 +20789,14 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
|
||||
reportIncompatibleStack();
|
||||
}
|
||||
if (overflow) {
|
||||
// Record this relation as having failed such that we don't attempt the overflowing operation again.
|
||||
const id = getRelationKey(source, target, /*intersectionState*/ IntersectionState.None, relation, /*ignoreConstraints*/ false);
|
||||
relation.set(id, RelationComparisonResult.Reported | RelationComparisonResult.Failed);
|
||||
tracing?.instant(tracing.Phase.CheckTypes, "checkTypeRelatedTo_DepthLimit", { sourceId: source.id, targetId: target.id, depth: sourceDepth, targetDepth });
|
||||
const diag = error(errorNode || currentNode, Diagnostics.Excessive_stack_depth_comparing_types_0_and_1, typeToString(source), typeToString(target));
|
||||
const message = relationCount <= 0 ?
|
||||
Diagnostics.Excessive_complexity_comparing_types_0_and_1 :
|
||||
Diagnostics.Excessive_stack_depth_comparing_types_0_and_1;
|
||||
const diag = error(errorNode || currentNode, message, typeToString(source), typeToString(target));
|
||||
if (errorOutputContainer) {
|
||||
(errorOutputContainer.errors || (errorOutputContainer.errors = [])).push(diag);
|
||||
}
|
||||
@@ -21420,6 +21429,22 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
|
||||
// we need to deconstruct unions before intersections (because unions are always at the top),
|
||||
// and we need to handle "each" relations before "some" relations for the same kind of type.
|
||||
if (source.flags & TypeFlags.Union) {
|
||||
if (target.flags & TypeFlags.Union) {
|
||||
// Intersections of union types are normalized into unions of intersection types, and such normalized
|
||||
// unions can get very large and expensive to relate. The following fast path checks if the source union
|
||||
// originated in an intersection. If so, and if that intersection contains the target type, then we know
|
||||
// the result to be true (for any two types A and B, A & B is related to both A and B).
|
||||
const sourceOrigin = (source as UnionType).origin;
|
||||
if (sourceOrigin && sourceOrigin.flags & TypeFlags.Intersection && target.aliasSymbol && contains((sourceOrigin as IntersectionType).types, target)) {
|
||||
return Ternary.True;
|
||||
}
|
||||
// Similarly, in unions of unions the we preserve the original list of unions. This original list is often
|
||||
// much shorter than the normalized result, so we scan it in the following fast path.
|
||||
const targetOrigin = (target as UnionType).origin;
|
||||
if (targetOrigin && targetOrigin.flags & TypeFlags.Union && source.aliasSymbol && contains((targetOrigin as UnionType).types, source)) {
|
||||
return Ternary.True;
|
||||
}
|
||||
}
|
||||
return relation === comparableRelation ?
|
||||
someTypeRelatedToType(source as UnionType, target, reportErrors && !(source.flags & TypeFlags.Primitive), intersectionState) :
|
||||
eachTypeRelatedToType(source as UnionType, target, reportErrors && !(source.flags & TypeFlags.Primitive), intersectionState);
|
||||
@@ -21671,6 +21696,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
|
||||
return entry & RelationComparisonResult.Succeeded ? Ternary.True : Ternary.False;
|
||||
}
|
||||
}
|
||||
if (relationCount <= 0) {
|
||||
overflow = true;
|
||||
return Ternary.False;
|
||||
}
|
||||
if (!maybeKeys) {
|
||||
maybeKeys = [];
|
||||
maybeKeysSet = new Set();
|
||||
@@ -21768,6 +21797,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
|
||||
// A false result goes straight into global cache (when something is false under
|
||||
// assumptions it will also be false without assumptions)
|
||||
relation.set(id, (reportErrors ? RelationComparisonResult.Reported : 0) | RelationComparisonResult.Failed | propagatingVarianceFlags);
|
||||
relationCount--;
|
||||
resetMaybeStack(/*markAllAsSucceeded*/ false);
|
||||
}
|
||||
return result;
|
||||
@@ -21777,6 +21807,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
|
||||
maybeKeysSet.delete(maybeKeys[i]);
|
||||
if (markAllAsSucceeded) {
|
||||
relation.set(maybeKeys[i], RelationComparisonResult.Succeeded | propagatingVarianceFlags);
|
||||
relationCount--;
|
||||
}
|
||||
}
|
||||
maybeCount = maybeStart;
|
||||
|
||||
@@ -3687,6 +3687,10 @@
|
||||
"category": "Error",
|
||||
"code": 2858
|
||||
},
|
||||
"Excessive complexity comparing types '{0}' and '{1}'.": {
|
||||
"category": "Error",
|
||||
"code": 2859
|
||||
},
|
||||
|
||||
"Import declaration '{0}' is using private name '{1}'.": {
|
||||
"category": "Error",
|
||||
|
||||
@@ -0,0 +1,23 @@
|
||||
relationComplexityError.ts(12,5): error TS2322: Type 'T1 & T2' is not assignable to type 'T1 | null'.
|
||||
relationComplexityError.ts(12,5): error TS2859: Excessive complexity comparing types 'T1 & T2' and 'T1 | null'.
|
||||
|
||||
|
||||
==== relationComplexityError.ts (2 errors) ====
|
||||
// Repro from #55630
|
||||
|
||||
type Digits = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9';
|
||||
type T1 = `${Digits}${Digits}${Digits}${Digits}` | undefined;
|
||||
type T2 = { a: string } | { b: number };
|
||||
|
||||
function f1(x: T1, y: T1 & T2) {
|
||||
x = y;
|
||||
}
|
||||
|
||||
function f2(x: T1 | null, y: T1 & T2) {
|
||||
x = y; // Complexity error
|
||||
~
|
||||
!!! error TS2322: Type 'T1 & T2' is not assignable to type 'T1 | null'.
|
||||
~~~~~
|
||||
!!! error TS2859: Excessive complexity comparing types 'T1 & T2' and 'T1 | null'.
|
||||
}
|
||||
|
||||
@@ -0,0 +1,46 @@
|
||||
//// [tests/cases/compiler/relationComplexityError.ts] ////
|
||||
|
||||
=== relationComplexityError.ts ===
|
||||
// Repro from #55630
|
||||
|
||||
type Digits = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9';
|
||||
>Digits : Symbol(Digits, Decl(relationComplexityError.ts, 0, 0))
|
||||
|
||||
type T1 = `${Digits}${Digits}${Digits}${Digits}` | undefined;
|
||||
>T1 : Symbol(T1, Decl(relationComplexityError.ts, 2, 72))
|
||||
>Digits : Symbol(Digits, Decl(relationComplexityError.ts, 0, 0))
|
||||
>Digits : Symbol(Digits, Decl(relationComplexityError.ts, 0, 0))
|
||||
>Digits : Symbol(Digits, Decl(relationComplexityError.ts, 0, 0))
|
||||
>Digits : Symbol(Digits, Decl(relationComplexityError.ts, 0, 0))
|
||||
|
||||
type T2 = { a: string } | { b: number };
|
||||
>T2 : Symbol(T2, Decl(relationComplexityError.ts, 3, 61))
|
||||
>a : Symbol(a, Decl(relationComplexityError.ts, 4, 11))
|
||||
>b : Symbol(b, Decl(relationComplexityError.ts, 4, 27))
|
||||
|
||||
function f1(x: T1, y: T1 & T2) {
|
||||
>f1 : Symbol(f1, Decl(relationComplexityError.ts, 4, 40))
|
||||
>x : Symbol(x, Decl(relationComplexityError.ts, 6, 12))
|
||||
>T1 : Symbol(T1, Decl(relationComplexityError.ts, 2, 72))
|
||||
>y : Symbol(y, Decl(relationComplexityError.ts, 6, 18))
|
||||
>T1 : Symbol(T1, Decl(relationComplexityError.ts, 2, 72))
|
||||
>T2 : Symbol(T2, Decl(relationComplexityError.ts, 3, 61))
|
||||
|
||||
x = y;
|
||||
>x : Symbol(x, Decl(relationComplexityError.ts, 6, 12))
|
||||
>y : Symbol(y, Decl(relationComplexityError.ts, 6, 18))
|
||||
}
|
||||
|
||||
function f2(x: T1 | null, y: T1 & T2) {
|
||||
>f2 : Symbol(f2, Decl(relationComplexityError.ts, 8, 1))
|
||||
>x : Symbol(x, Decl(relationComplexityError.ts, 10, 12))
|
||||
>T1 : Symbol(T1, Decl(relationComplexityError.ts, 2, 72))
|
||||
>y : Symbol(y, Decl(relationComplexityError.ts, 10, 25))
|
||||
>T1 : Symbol(T1, Decl(relationComplexityError.ts, 2, 72))
|
||||
>T2 : Symbol(T2, Decl(relationComplexityError.ts, 3, 61))
|
||||
|
||||
x = y; // Complexity error
|
||||
>x : Symbol(x, Decl(relationComplexityError.ts, 10, 12))
|
||||
>y : Symbol(y, Decl(relationComplexityError.ts, 10, 25))
|
||||
}
|
||||
|
||||
@@ -0,0 +1,38 @@
|
||||
//// [tests/cases/compiler/relationComplexityError.ts] ////
|
||||
|
||||
=== relationComplexityError.ts ===
|
||||
// Repro from #55630
|
||||
|
||||
type Digits = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9';
|
||||
>Digits : "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9"
|
||||
|
||||
type T1 = `${Digits}${Digits}${Digits}${Digits}` | undefined;
|
||||
>T1 : "0000" | "0001" | "0002" | "0003" | "0004" | "0005" | "0006" | "0007" | "0008" | "0009" | "0010" | "0011" | "0012" | "0013" | "0014" | "0015" | "0016" | "0017" | "0018" | "0019" | "0020" | "0021" | "0022" | "0023" | "0024" | "0025" | "0026" | "0027" | "0028" | "0029" | "0030" | "0031" | "0032" | "0033" | "0034" | "0035" | "0036" | "0037" | "0038" | "0039" | "0040" | "0041" | "0042" | "0043" | "0044" | "0045" | "0046" | "0047" | "0048" | "0049" | "0050" | "0051" | "0052" | "0053" | "0054" | "0055" | "0056" | "0057" | "0058" | "0059" | "0060" | "0061" | "0062" | "0063" | "0064" | "0065" | "0066" | "0067" | "0068" | "0069" | "0070" | "0071" | "0072" | "0073" | "0074" | "0075" | "0076" | "0077" | "0078" | "0079" | "0080" | "0081" | "0082" | "0083" | "0084" | "0085" | "0086" | "0087" | "0088" | "0089" | "0090" | "0091" | "0092" | "0093" | "0094" | "0095" | "0096" | "0097" | "0098" | "0099" | "0100" | "0101" | "0102" | "0103" | "0104" | "0105" | "0106" | "0107" | "0108" | "0109" | "0110" | "0111" | "0112" | "0113" | "0114" | "0115" | "0116" | "0117" | "0118" | "0119" | "0120" | "0121" | "0122" | "0123" | "0124" | "0125" | "0126" | "0127" | "0128" | "0129" | "0130" | "0131" | "0132" | "0133" | "0134" | "0135" | "0136" | "0137" | "0138" | "0139" | "0140" | "0141" | "0142" | "0143" | "0144" | "0145" | "0146" | "0147" | "0148" | "0149" | "0150" | "0151" | "0152" | "0153" | "0154" | "0155" | "0156" | "0157" | "0158" | "0159" | "0160" | "0161" | "0162" | "0163" | "0164" | "0165" | "0166" | "0167" | "0168" | "0169" | "0170" | "0171" | "0172" | "0173" | "0174" | "0175" | "0176" | "0177" | "0178" | "0179" | "0180" | "0181" | "0182" | "0183" | "0184" | "0185" | "0186" | "0187" | "0188" | "0189" | "0190" | "0191" | "0192" | "0193" | "0194" | "0195" | "0196" | "0197" | "0198" | "0199" | "0200" | "0201" | "0202" | "0203" | "0204" | "0205" | "0206" | "0207" | "0208" | "0209" | "0210" | "0211" | "0212" | "0213" | "0214" | "0215" | "0216" | "0217" | "0218" | "0219" | "0220" | "0221" | "0222" | "0223" | "0224" | "0225" | "0226" | "0227" | "0228" | "0229" | "0230" | "0231" | "0232" | "0233" | "0234" | "0235" | "0236" | "0237" | "0238" | "0239" | "0240" | "0241" | "0242" | "0243" | "0244" | "0245" | "0246" | "0247" | "0248" | "0249" | "0250" | "0251" | "0252" | "0253" | "0254" | "0255" | "0256" | "0257" | "0258" | "0259" | "0260" | "0261" | "0262" | "0263" | "0264" | "0265" | "0266" | "0267" | "0268" | "0269" | "0270" | "0271" | "0272" | "0273" | "0274" | "0275" | "0276" | "0277" | "0278" | "0279" | "0280" | "0281" | "0282" | "0283" | "0284" | "0285" | "0286" | "0287" | "0288" | "0289" | "0290" | "0291" | "0292" | "0293" | "0294" | "0295" | "0296" | "0297" | "0298" | "0299" | "0300" | "0301" | "0302" | "0303" | "0304" | "0305" | "0306" | "0307" | "0308" | "0309" | "0310" | "0311" | "0312" | "0313" | "0314" | "0315" | "0316" | "0317" | "0318" | "0319" | "0320" | "0321" | "0322" | "0323" | "0324" | "0325" | "0326" | "0327" | "0328" | "0329" | "0330" | "0331" | "0332" | "0333" | "0334" | "0335" | "0336" | "0337" | "0338" | "0339" | "0340" | "0341" | "0342" | "0343" | "0344" | "0345" | "0346" | "0347" | "0348" | "0349" | "0350" | "0351" | "0352" | "0353" | "0354" | "0355" | "0356" | "0357" | "0358" | "0359" | "0360" | "0361" | "0362" | "0363" | "0364" | "0365" | "0366" | "0367" | "0368" | "0369" | "0370" | "0371" | "0372" | "0373" | "0374" | "0375" | "0376" | "0377" | "0378" | "0379" | "0380" | "0381" | "0382" | "0383" | "0384" | "0385" | "0386" | "0387" | "0388" | "0389" | "0390" | "0391" | "0392" | "0393" | "0394" | "0395" | "0396" | "0397" | "0398" | "0399" | "0400" | "0401" | "0402" | "0403" | "0404" | "0405" | "0406" | "0407" | "0408" | "0409" | "0410" | "0411" | "0412" | "0413" | "0414" | "0415" | "0416" | "0417" | "0418" | "0419" | "0420" | "0421" | "0422" | "0423" | "0424" | "0425" | "0426" | "0427" | "0428" | "0429" | "0430" | "0431" | "0432" | "0433" | "0434" | "0435" | "0436" | "0437" | "0438" | "0439" | "0440" | "0441" | "0442" | "0443" | "0444" | "0445" | "0446" | "0447" | "0448" | "0449" | "0450" | "0451" | "0452" | "0453" | "0454" | "0455" | "0456" | "0457" | "0458" | "0459" | "0460" | "0461" | "0462" | "0463" | "0464" | "0465" | "0466" | "0467" | "0468" | "0469" | "0470" | "0471" | "0472" | "0473" | "0474" | "0475" | "0476" | "0477" | "0478" | "0479" | "0480" | "0481" | "0482" | "0483" | "0484" | "0485" | "0486" | "0487" | "0488" | "0489" | "0490" | "0491" | "0492" | "0493" | "0494" | "0495" | "0496" | "0497" | "0498" | "0499" | "0500" | "0501" | "0502" | "0503" | "0504" | "0505" | "0506" | "0507" | "0508" | "0509" | "0510" | "0511" | "0512" | "0513" | "0514" | "0515" | "0516" | "0517" | "0518" | "0519" | "0520" | "0521" | "0522" | "0523" | "0524" | "0525" | "0526" | "0527" | "0528" | "0529" | "0530" | "0531" | "0532" | "0533" | "0534" | "0535" | "0536" | "0537" | "0538" | "0539" | "0540" | "0541" | "0542" | "0543" | "0544" | "0545" | "0546" | "0547" | "0548" | "0549" | "0550" | "0551" | "0552" | "0553" | "0554" Line truncated
|
||||
|
||||
type T2 = { a: string } | { b: number };
|
||||
>T2 : { a: string; } | { b: number; }
|
||||
>a : string
|
||||
>b : number
|
||||
|
||||
function f1(x: T1, y: T1 & T2) {
|
||||
>f1 : (x: T1, y: T1 & T2) => void
|
||||
>x : T1
|
||||
>y : T1 & T2
|
||||
|
||||
x = y;
|
||||
>x = y : T1 & T2
|
||||
>x : T1
|
||||
>y : T1 & T2
|
||||
}
|
||||
|
||||
function f2(x: T1 | null, y: T1 & T2) {
|
||||
>f2 : (x: T1 | null, y: T1 & T2) => void
|
||||
>x : T1 | null
|
||||
>y : T1 & T2
|
||||
|
||||
x = y; // Complexity error
|
||||
>x = y : T1 & T2
|
||||
>x : T1 | null
|
||||
>y : T1 & T2
|
||||
}
|
||||
|
||||
@@ -0,0 +1,16 @@
|
||||
// @strict: true
|
||||
// @noEmit: true
|
||||
|
||||
// Repro from #55630
|
||||
|
||||
type Digits = '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9';
|
||||
type T1 = `${Digits}${Digits}${Digits}${Digits}` | undefined;
|
||||
type T2 = { a: string } | { b: number };
|
||||
|
||||
function f1(x: T1, y: T1 & T2) {
|
||||
x = y;
|
||||
}
|
||||
|
||||
function f2(x: T1 | null, y: T1 & T2) {
|
||||
x = y; // Complexity error
|
||||
}
|
||||
Reference in new issue
Block a user