Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(45182): allow property access in arrow function (#45193)

Browse Source
This commit is contained in:
Oleksandr T
2021-07-27 09:46:17 -07:00
committed by GitHub
parent 85e0e5ad07
commit b81eb6cfe1
6 changed files with 91 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/checker.ts
+1
View File
@@ -27782,6 +27782,7 @@ namespace ts {
case SyntaxKind.ExpressionWithTypeArguments:
case SyntaxKind.HeritageClause:
return false;
case SyntaxKind.ArrowFunction:
case SyntaxKind.ExpressionStatement:
return isBlock(node.parent) && isClassStaticBlockDeclaration(node.parent.parent) ? true : "quit";
default:
tests/baselines/reference/assignParameterPropertyToPropertyDeclarationESNext.errors.txt
+9
View File
@@ -62,4 +62,13 @@ tests/cases/conformance/classes/propertyMemberDeclarations/assignParameterProper
}
constructor(public p1: number) {}
}
class H {
constructor(public p1: C) {}
public p2 = () => {
return this.p1.foo;
}
public p3 = () => this.p1.foo;
}
tests/baselines/reference/assignParameterPropertyToPropertyDeclarationESNext.js
+19
View File
@@ -40,6 +40,15 @@ class G {
}
constructor(public p1: number) {}
}
class H {
constructor(public p1: C) {}
public p2 = () => {
return this.p1.foo;
}
public p3 = () => this.p1.foo;
}
//// [assignParameterPropertyToPropertyDeclarationESNext.js]
@@ -90,3 +99,13 @@ class G {
this.p1 = p1;
}
}
class H {
p1;
constructor(p1) {
this.p1 = p1;
}
p2 = () => {
return this.p1.foo;
};
p3 = () => this.p1.foo;
}
tests/baselines/reference/assignParameterPropertyToPropertyDeclarationESNext.symbols
+26
View File
@@ -136,4 +136,30 @@ class G {
constructor(public p1: number) {}
>p1 : Symbol(G.p1, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 39, 16))
}
class H {
>H : Symbol(H, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 40, 1))
constructor(public p1: C) {}
>p1 : Symbol(H.p1, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 42, 16))
>C : Symbol(C, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 0, 0))
public p2 = () => {
>p2 : Symbol(H.p2, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 42, 32))
return this.p1.foo;
>this.p1.foo : Symbol(C.foo, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 10, 16))
>this.p1 : Symbol(H.p1, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 42, 16))
>this : Symbol(H, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 40, 1))
>p1 : Symbol(H.p1, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 42, 16))
>foo : Symbol(C.foo, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 10, 16))
}
public p3 = () => this.p1.foo;
>p3 : Symbol(H.p3, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 46, 5))
>this.p1.foo : Symbol(C.foo, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 10, 16))
>this.p1 : Symbol(H.p1, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 42, 16))
>this : Symbol(H, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 40, 1))
>p1 : Symbol(H.p1, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 42, 16))
>foo : Symbol(C.foo, Decl(assignParameterPropertyToPropertyDeclarationESNext.ts, 10, 16))
}
tests/baselines/reference/assignParameterPropertyToPropertyDeclarationESNext.types
+27
View File
@@ -145,4 +145,31 @@ class G {
constructor(public p1: number) {}
>p1 : number
}
class H {
>H : H
constructor(public p1: C) {}
>p1 : C
public p2 = () => {
>p2 : () => string
>() => { return this.p1.foo; } : () => string
return this.p1.foo;
>this.p1.foo : string
>this.p1 : C
>this : this
>p1 : C
>foo : string
}
public p3 = () => this.p1.foo;
>p3 : () => string
>() => this.p1.foo : () => string
>this.p1.foo : string
>this.p1 : C
>this : this
>p1 : C
>foo : string
}
tests/cases/conformance/classes/propertyMemberDeclarations/assignParameterPropertyToPropertyDeclarationESNext.ts
+9
View File
@@ -41,3 +41,12 @@ class G {
}
constructor(public p1: number) {}
}
class H {
constructor(public p1: C) {}
public p2 = () => {
return this.p1.foo;
}
public p3 = () => this.p1.foo;
}