Merge pull request #25335 from Microsoft/codeFixAddMissingEnumMember_all

Combine code-fix-all for missing class member and missing enum member
This commit is contained in:
Mohamed Hegazy
2018-07-02 15:14:19 -07:00
committed by GitHub
4 changed files with 10 additions and 7 deletions
-4
View File
@@ -4470,9 +4470,5 @@
"Add missing enum member '{0}'": {
"category": "Message",
"code": 95063
},
"Add all missing enum members": {
"category": "Message",
"code": 95064
}
}
@@ -15,7 +15,7 @@ namespace ts.codefix {
if (info.kind === InfoKind.enum) {
const { token, enumDeclaration } = info;
const changes = textChanges.ChangeTracker.with(context, t => addEnumMemberDeclaration(t, context.program.getTypeChecker(), token, enumDeclaration));
return singleElementArray(createCodeFixAction(fixName, changes, [Diagnostics.Add_missing_enum_member_0, token.text], fixId, Diagnostics.Add_all_missing_enum_members));
return [createCodeFixAction(fixName, changes, [Diagnostics.Add_missing_enum_member_0, token.text], fixId, Diagnostics.Add_all_missing_members)];
}
const { classDeclaration, classDeclarationSourceFile, inJs, makeStatic, token, call } = info;
const methodCodeAction = call && getActionForMethodDeclaration(context, classDeclarationSourceFile, classDeclaration, token, call, makeStatic, inJs, context.preferences);
-1
View File
@@ -5932,7 +5932,6 @@ declare namespace ts {
Convert_default_export_to_named_export: DiagnosticMessage;
Convert_named_export_to_default_export: DiagnosticMessage;
Add_missing_enum_member_0: DiagnosticMessage;
Add_all_missing_enum_members: DiagnosticMessage;
};
}
declare namespace ts {
@@ -7,6 +7,9 @@
//// this.x = "";
//// }
////}
////
////enum E {}
////E.A;
verify.codeFixAll({
fixId: "addMissingMember",
@@ -22,5 +25,10 @@ verify.codeFixAll({
y(): any {
throw new Error("Method not implemented.");
}
}`,
}
enum E {
A
}
E.A;`,
});