Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Get correct kind for generic symbol completion entries

Browse Source
This commit is contained in:
Mohamed Hegazy
2014-09-15 13:53:46 -07:00
parent 8e0227eba2
commit 885569d4e7
3 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/checker.ts
+1 -1
View File
@@ -7145,7 +7145,7 @@ module ts {
}
function getRootSymbol(symbol: Symbol) {
return (symbol.flags & SymbolFlags.Transient) ? getSymbolLinks(symbol).target : symbol;
return (symbol.flags & SymbolFlags.Transient) && getSymbolLinks(symbol).target || symbol;
}
// Emitter support
src/services/services.ts
+1 -2
View File
@@ -1592,7 +1592,6 @@ module ts {
}
var declarations = symbol.getDeclarations();
var firstDeclaration = [0];
return {
name: displayName,
kind: getSymbolKind(symbol),
@@ -1956,7 +1955,7 @@ module ts {
}
function getSymbolKind(symbol: Symbol): string {
var flags = symbol.getFlags();
var flags = typeInfoResolver.getRootSymbol(symbol).getFlags();
if (flags & SymbolFlags.Module) return ScriptElementKind.moduleElement;
if (flags & SymbolFlags.Class) return ScriptElementKind.classElement;
tests/cases/fourslash/completionListOfGnericSymbol.ts
+11
View File
@@ -0,0 +1,11 @@
/// <reference path="fourslash.ts" />
// Ensure kind is set correctelly on completions of a generic symbol
////var a = [1,2,3];
////a./**/
goTo.marker();
verify.memberListContains('length', "number", /*docComments*/ undefined, /*fullSymbolName*/ undefined,/*kind*/ "property");
verify.memberListContains('toString', "() => string", /*docComments*/ undefined, /*fullSymbolName*/ undefined,/*kind*/ "method");