Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixUnusedIdentifier: Delete trailing comma in array binding pattern (#24800)

Browse Source
This commit is contained in:
Andy
2018-06-08 10:39:01 -07:00
committed by GitHub
parent 7b2e09263c
commit 855c3a6d4f
2 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/codefixes/fixUnusedIdentifier.ts
+6 -9
View File
@@ -228,15 +228,12 @@ namespace ts.codefix {
case SyntaxKind.BindingElement: {
const pattern = (parent as BindingElement).parent;
switch (pattern.kind) {
case SyntaxKind.ArrayBindingPattern:
changes.deleteNode(sourceFile, parent); // Don't delete ','
break;
case SyntaxKind.ObjectBindingPattern:
changes.deleteNodeInList(sourceFile, parent);
break;
default:
return Debug.assertNever(pattern);
const preserveComma = pattern.kind === SyntaxKind.ArrayBindingPattern && parent !== last(pattern.elements);
if (preserveComma) {
changes.deleteNode(sourceFile, parent);
}
else {
changes.deleteNodeInList(sourceFile, parent);
}
break;
}
tests/cases/fourslash/codeFixUnusedIdentifier_destructure_partlyUnused.ts
+2 -2
View File
@@ -57,7 +57,7 @@ verify.codeFixAll({
x; z;
}
{
const [x,] = o;
const [x] = o;
x;
}
{
@@ -65,7 +65,7 @@ verify.codeFixAll({
y;
}
{
const [, y,] = o;
const [, y] = o;
y;
}
{