Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add regression test

Browse Source
This commit is contained in:
Anders Hejlsberg
2017-01-11 11:50:41 -08:00
parent 1f4cbcefb1
commit 5abd3230a4
4 changed files with 123 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/baselines/reference/keyofAndIndexedAccess.js
+19
View File
@@ -464,6 +464,16 @@ function addToMyThingy<S extends KeyTypes>(key: S) {
MyThingy[key].push("a");
}
// Repro from #13102
type Handler<T> = {
onChange: (name: keyof T) => void;
};
function onChangeGenericFunction<T>(handler: Handler<T & {preset: number}>) {
handler.onChange('preset')
}
// Repro from #13285
function updateIds<T extends Record<K, string>, K extends string>(
@@ -801,6 +811,9 @@ var MyThingy;
function addToMyThingy(key) {
MyThingy[key].push("a");
}
function onChangeGenericFunction(handler) {
handler.onChange('preset');
}
// Repro from #13285
function updateIds(obj, idFields, idMapping) {
for (var _i = 0, idFields_1 = idFields; _i < idFields_1.length; _i++) {
@@ -1034,6 +1047,12 @@ declare let MyThingy: {
[key in KeyTypes]: string[];
};
declare function addToMyThingy<S extends KeyTypes>(key: S): void;
declare type Handler<T> = {
onChange: (name: keyof T) => void;
};
declare function onChangeGenericFunction<T>(handler: Handler<T & {
preset: number;
}>): void;
declare function updateIds<T extends Record<K, string>, K extends string>(obj: T, idFields: K[], idMapping: {
[oldId: string]: string;
}): Record<K, string>;
tests/baselines/reference/keyofAndIndexedAccess.symbols
+65 -38
View File
@@ -1699,83 +1699,110 @@ function addToMyThingy<S extends KeyTypes>(key: S) {
>push : Symbol(Array.push, Decl(lib.d.ts, --, --))
}
// Repro from #13102
type Handler<T> = {
>Handler : Symbol(Handler, Decl(keyofAndIndexedAccess.ts, 463, 1))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 467, 13))
onChange: (name: keyof T) => void;
>onChange : Symbol(onChange, Decl(keyofAndIndexedAccess.ts, 467, 19))
>name : Symbol(name, Decl(keyofAndIndexedAccess.ts, 468, 15))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 467, 13))
};
function onChangeGenericFunction<T>(handler: Handler<T & {preset: number}>) {
>onChangeGenericFunction : Symbol(onChangeGenericFunction, Decl(keyofAndIndexedAccess.ts, 469, 2))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 471, 33))
>handler : Symbol(handler, Decl(keyofAndIndexedAccess.ts, 471, 36))
>Handler : Symbol(Handler, Decl(keyofAndIndexedAccess.ts, 463, 1))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 471, 33))
>preset : Symbol(preset, Decl(keyofAndIndexedAccess.ts, 471, 58))
handler.onChange('preset')
>handler.onChange : Symbol(onChange, Decl(keyofAndIndexedAccess.ts, 467, 19))
>handler : Symbol(handler, Decl(keyofAndIndexedAccess.ts, 471, 36))
>onChange : Symbol(onChange, Decl(keyofAndIndexedAccess.ts, 467, 19))
}
// Repro from #13285
function updateIds<T extends Record<K, string>, K extends string>(
>updateIds : Symbol(updateIds, Decl(keyofAndIndexedAccess.ts, 463, 1))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 467, 19))
>updateIds : Symbol(updateIds, Decl(keyofAndIndexedAccess.ts, 473, 1))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 477, 19))
>Record : Symbol(Record, Decl(lib.d.ts, --, --))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 467, 47))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 467, 47))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 477, 47))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 477, 47))
obj: T,
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 467, 66))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 467, 19))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 477, 66))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 477, 19))
idFields: K[],
>idFields : Symbol(idFields, Decl(keyofAndIndexedAccess.ts, 468, 11))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 467, 47))
>idFields : Symbol(idFields, Decl(keyofAndIndexedAccess.ts, 478, 11))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 477, 47))
idMapping: { [oldId: string]: string }
>idMapping : Symbol(idMapping, Decl(keyofAndIndexedAccess.ts, 469, 18))
>oldId : Symbol(oldId, Decl(keyofAndIndexedAccess.ts, 470, 18))
>idMapping : Symbol(idMapping, Decl(keyofAndIndexedAccess.ts, 479, 18))
>oldId : Symbol(oldId, Decl(keyofAndIndexedAccess.ts, 480, 18))
): Record<K, string> {
>Record : Symbol(Record, Decl(lib.d.ts, --, --))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 467, 47))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 477, 47))
for (const idField of idFields) {
>idField : Symbol(idField, Decl(keyofAndIndexedAccess.ts, 472, 14))
>idFields : Symbol(idFields, Decl(keyofAndIndexedAccess.ts, 468, 11))
>idField : Symbol(idField, Decl(keyofAndIndexedAccess.ts, 482, 14))
>idFields : Symbol(idFields, Decl(keyofAndIndexedAccess.ts, 478, 11))
const newId = idMapping[obj[idField]];
>newId : Symbol(newId, Decl(keyofAndIndexedAccess.ts, 473, 13))
>idMapping : Symbol(idMapping, Decl(keyofAndIndexedAccess.ts, 469, 18))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 467, 66))
>idField : Symbol(idField, Decl(keyofAndIndexedAccess.ts, 472, 14))
>newId : Symbol(newId, Decl(keyofAndIndexedAccess.ts, 483, 13))
>idMapping : Symbol(idMapping, Decl(keyofAndIndexedAccess.ts, 479, 18))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 477, 66))
>idField : Symbol(idField, Decl(keyofAndIndexedAccess.ts, 482, 14))
if (newId) {
>newId : Symbol(newId, Decl(keyofAndIndexedAccess.ts, 473, 13))
>newId : Symbol(newId, Decl(keyofAndIndexedAccess.ts, 483, 13))
obj[idField] = newId;
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 467, 66))
>idField : Symbol(idField, Decl(keyofAndIndexedAccess.ts, 472, 14))
>newId : Symbol(newId, Decl(keyofAndIndexedAccess.ts, 473, 13))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 477, 66))
>idField : Symbol(idField, Decl(keyofAndIndexedAccess.ts, 482, 14))
>newId : Symbol(newId, Decl(keyofAndIndexedAccess.ts, 483, 13))
}
}
return obj;
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 467, 66))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 477, 66))
}
// Repro from #13285
function updateIds2<T extends { [x: string]: string }, K extends keyof T>(
>updateIds2 : Symbol(updateIds2, Decl(keyofAndIndexedAccess.ts, 479, 1))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 483, 20))
>x : Symbol(x, Decl(keyofAndIndexedAccess.ts, 483, 33))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 483, 54))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 483, 20))
>updateIds2 : Symbol(updateIds2, Decl(keyofAndIndexedAccess.ts, 489, 1))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 493, 20))
>x : Symbol(x, Decl(keyofAndIndexedAccess.ts, 493, 33))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 493, 54))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 493, 20))
obj: T,
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 483, 74))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 483, 20))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 493, 74))
>T : Symbol(T, Decl(keyofAndIndexedAccess.ts, 493, 20))
key: K,
>key : Symbol(key, Decl(keyofAndIndexedAccess.ts, 484, 11))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 483, 54))
>key : Symbol(key, Decl(keyofAndIndexedAccess.ts, 494, 11))
>K : Symbol(K, Decl(keyofAndIndexedAccess.ts, 493, 54))
stringMap: { [oldId: string]: string }
>stringMap : Symbol(stringMap, Decl(keyofAndIndexedAccess.ts, 485, 11))
>oldId : Symbol(oldId, Decl(keyofAndIndexedAccess.ts, 486, 18))
>stringMap : Symbol(stringMap, Decl(keyofAndIndexedAccess.ts, 495, 11))
>oldId : Symbol(oldId, Decl(keyofAndIndexedAccess.ts, 496, 18))
) {
var x = obj[key];
>x : Symbol(x, Decl(keyofAndIndexedAccess.ts, 488, 7))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 483, 74))
>key : Symbol(key, Decl(keyofAndIndexedAccess.ts, 484, 11))
>x : Symbol(x, Decl(keyofAndIndexedAccess.ts, 498, 7))
>obj : Symbol(obj, Decl(keyofAndIndexedAccess.ts, 493, 74))
>key : Symbol(key, Decl(keyofAndIndexedAccess.ts, 494, 11))
stringMap[x]; // Should be OK.
>stringMap : Symbol(stringMap, Decl(keyofAndIndexedAccess.ts, 485, 11))
>x : Symbol(x, Decl(keyofAndIndexedAccess.ts, 488, 7))
>stringMap : Symbol(stringMap, Decl(keyofAndIndexedAccess.ts, 495, 11))
>x : Symbol(x, Decl(keyofAndIndexedAccess.ts, 498, 7))
}
tests/baselines/reference/keyofAndIndexedAccess.types
+29
View File
@@ -2013,6 +2013,35 @@ function addToMyThingy<S extends KeyTypes>(key: S) {
>"a" : "a"
}
// Repro from #13102
type Handler<T> = {
>Handler : Handler<T>
>T : T
onChange: (name: keyof T) => void;
>onChange : (name: keyof T) => void
>name : keyof T
>T : T
};
function onChangeGenericFunction<T>(handler: Handler<T & {preset: number}>) {
>onChangeGenericFunction : <T>(handler: Handler<T & { preset: number; }>) => void
>T : T
>handler : Handler<T & { preset: number; }>
>Handler : Handler<T>
>T : T
>preset : number
handler.onChange('preset')
>handler.onChange('preset') : void
>handler.onChange : (name: keyof (T & { preset: number; })) => void
>handler : Handler<T & { preset: number; }>
>onChange : (name: keyof (T & { preset: number; })) => void
>'preset' : "preset"
}
// Repro from #13285
function updateIds<T extends Record<K, string>, K extends string>(
tests/cases/conformance/types/keyof/keyofAndIndexedAccess.ts
+10
View File
@@ -465,6 +465,16 @@ function addToMyThingy<S extends KeyTypes>(key: S) {
MyThingy[key].push("a");
}
// Repro from #13102
type Handler<T> = {
onChange: (name: keyof T) => void;
};
function onChangeGenericFunction<T>(handler: Handler<T & {preset: number}>) {
handler.onChange('preset')
}
// Repro from #13285
function updateIds<T extends Record<K, string>, K extends string>(