Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

add testcase and apply feedback from pr

Browse Source
This commit is contained in:
BigAru
2018-10-31 14:27:36 +01:00
parent 649b53c8de
commit 595131868f
7 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/refactors/convertArrowFunctionOrFunctionExpression.ts
+1 -1
View File
@@ -172,7 +172,7 @@ namespace ts.refactor.convertArrowFunctionOrFunctionExpression {
const head = statements[0];
let body: ConciseBody;
if (func.body.statements.length === 1 && (isReturnStatement(head) || isExpressionStatement(head))) {
if (func.body.statements.length === 1 && ((isReturnStatement(head) && !!head.expression) || isExpressionStatement(head))) {
body = head.expression!;
suppressLeadingAndTrailingTrivia(body);
copyComments(head, body, file, SyntaxKind.MultiLineCommentTrivia, /* hasTrailingNewLine */ false);
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_Availability_Anon.ts
+1 -1
View File
@@ -25,4 +25,4 @@ verify.not.refactorAvailable("Convert arrow function or function expression", "C
goTo.select("r", "q");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to named function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to anonymous function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_Availability_Anon_FnParam.ts
+1 -1
View File
@@ -31,4 +31,4 @@ verify.refactorAvailable("Convert arrow function or function expression", "Conve
goTo.select("p", "o");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to named function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to anonymous function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_Availability_Arrow.ts
+1 -1
View File
@@ -30,4 +30,4 @@ verify.not.refactorAvailable("Convert arrow function or function expression", "C
goTo.select("p", "o");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to named function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to anonymous function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_Availability_Arrow_FnParam.ts
+1 -1
View File
@@ -27,4 +27,4 @@ verify.not.refactorAvailable("Convert arrow function or function expression", "C
goTo.select("r", "q");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to named function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to anonymous function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_Availability_Arrow_MultiDecl.ts
+1 -1
View File
@@ -20,4 +20,4 @@ verify.not.refactorAvailable("Convert arrow function or function expression", "C
goTo.select("t", "s");
verify.refactorAvailable("Convert arrow function or function expression", "Convert to named function");
verify.refactorAvailable("Convert arrow function or function expression", "Convert to anonymous function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
verify.not.refactorAvailable("Convert arrow function or function expression", "Convert to arrow function");
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_ToArrow_EmptyReturn.ts
+15
View File
@@ -0,0 +1,15 @@
/// <reference path='fourslash.ts' />
//// const foo = /*x*/f/*y*/unction() {
//// return;
//// };
goTo.select("x", "y");
edit.applyRefactor({
refactorName: "Convert arrow function or function expression",
actionName: "Convert to arrow function",
actionDescription: "Convert to arrow function",
newContent: `const foo = () => {
return;
};`,
});