Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix find-all-references for destructured getter (#17483)

Browse Source 
* Fix find-all-references for destructured getter

* Handle setter too

* Use SymbolFlags.Accessor
This commit is contained in:
Andy
2017-08-02 06:51:26 -07:00
committed by GitHub
parent 33cc0a1814
commit 4f13bcfac1
2 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/findAllReferences.ts
+9 -4
View File
@@ -604,11 +604,16 @@ namespace ts.FindAllReferences.Core {
function getPropertySymbolOfObjectBindingPatternWithoutPropertyName(symbol: Symbol, checker: TypeChecker): Symbol | undefined {
const bindingElement = getObjectBindingElementWithoutPropertyName(symbol);
if (bindingElement) {
const typeOfPattern = checker.getTypeAtLocation(bindingElement.parent);
return typeOfPattern && checker.getPropertyOfType(typeOfPattern, (<Identifier>bindingElement.name).text);
if (!bindingElement) return undefined;
const typeOfPattern = checker.getTypeAtLocation(bindingElement.parent);
const propSymbol = typeOfPattern && checker.getPropertyOfType(typeOfPattern, (<Identifier>bindingElement.name).text);
if (propSymbol && propSymbol.flags & SymbolFlags.Accessor) {
// See GH#16922
Debug.assert(!!(propSymbol.flags & SymbolFlags.Transient));
return (propSymbol as TransientSymbol).target;
}
return undefined;
return propSymbol;
}
/**
tests/cases/fourslash/findAllRefsDestructureGetter.ts
+22
View File
@@ -0,0 +1,22 @@
/// <reference path="fourslash.ts" />
////class Test {
//// get [|{| "isDefinition": true, "isWriteAccess": true |}x|]() { return 0; }
////
//// set [|{| "isDefinition": true, "isWriteAccess": true |}y|](a: number) {}
////}
////const { [|{| "isDefinition": true, "isWriteAccess": true |}x|], [|{| "isDefinition": true, "isWriteAccess": true |}y|] } = new Test();
////[|x|]; [|y|];
const [x0, y0, x1, y1, x2, y2] = test.ranges();
verify.referenceGroups(x0, [{ definition: "(property) Test.x: number", ranges: [x0, x1, x2] }]);
verify.referenceGroups([x1, x2], [
{ definition: "(property) Test.x: number", ranges: [x0] },
{ definition: "const x: number", ranges: [x1, x2] },
]);
verify.referenceGroups(y0, [{ definition: "(property) Test.y: number", ranges: [y0, y1, y2] }]);
verify.referenceGroups([y1, y2], [
{ definition: "(property) Test.y: number", ranges: [y0] },
{ definition: "const y: number", ranges: [y1, y2] },
]);