Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove skipTransformationFlags

Browse Source
This commit is contained in:
Ron Buckton
2020-05-19 16:41:10 -07:00
parent 67aa311108
commit 415bc3eec0
3 changed files with 282 additions and 518 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/factory/nodeFactory.ts
+282 -504
View File
File diff suppressed because it is too large Load Diff
src/compiler/parser.ts
-9
View File
@@ -408,12 +408,10 @@ namespace ts {
parsingContext = 0;
identifiers = undefined!;
notParenthesizedArrow = undefined!;
factory.setSkipTransformationFlags(/*inDeclarationFile*/ false);
}
function parseSourceFileWorker(languageVersion: ScriptTarget, setParentNodes: boolean, scriptKind: ScriptKind): SourceFile {
const isDeclarationFile = isDeclarationFileName(fileName);
factory.setSkipTransformationFlags(isDeclarationFile);
if (isDeclarationFile) {
contextFlags |= NodeFlags.Ambient;
}
@@ -447,7 +445,6 @@ namespace ts {
fixupParentReferences(sourceFile);
}
factory.setSkipTransformationFlags(/*inDeclarationFile*/ false);
return sourceFile;
function reportPragmaDiagnostic(pos: number, end: number, diagnostic: DiagnosticMessage) {
@@ -6319,7 +6316,6 @@ namespace ts {
export namespace JSDocParser {
export function parseJSDocTypeExpressionForTests(content: string, start: number | undefined, length: number | undefined): { jsDocTypeExpression: JSDocTypeExpression, diagnostics: Diagnostic[] } | undefined {
initializeState("file.js", content, ScriptTarget.Latest, /*_syntaxCursor:*/ undefined, ScriptKind.JS);
factory.setSkipTransformationFlags(/*value*/ true); // reset in 'clearState'
scanner.setText(content, start, length);
currentToken = scanner.scan();
const jsDocTypeExpression = parseJSDocTypeExpression();
@@ -6338,7 +6334,6 @@ namespace ts {
// Parses out a JSDoc type expression.
export function parseJSDocTypeExpression(mayOmitBraces?: boolean): JSDocTypeExpression {
const pos = getNodePos();
const saveSkipTransformationFlags = factory.setSkipTransformationFlags(/*value*/ true);
const hasBrace = (mayOmitBraces ? parseOptional : parseExpected)(SyntaxKind.OpenBraceToken);
const type = doInsideOfContext(NodeFlags.JSDoc, parseJSDocType);
if (!mayOmitBraces || hasBrace) {
@@ -6347,13 +6342,11 @@ namespace ts {
const result = factory.createJSDocTypeExpression(type);
fixupParentReferences(result);
factory.setSkipTransformationFlags(saveSkipTransformationFlags);
return finishNode(result, pos);
}
export function parseIsolatedJSDocComment(content: string, start: number | undefined, length: number | undefined): { jsDoc: JSDoc, diagnostics: Diagnostic[] } | undefined {
initializeState("", content, ScriptTarget.Latest, /*_syntaxCursor:*/ undefined, ScriptKind.JS);
factory.setSkipTransformationFlags(/*value*/ true); // reset in 'clearState'
const jsDoc = doInsideOfContext(NodeFlags.JSDoc, () => parseJSDocCommentWorker(start, length));
const sourceFile = <SourceFile>{ languageVariant: LanguageVariant.Standard, text: content };
@@ -6364,7 +6357,6 @@ namespace ts {
}
export function parseJSDocComment(parent: HasJSDoc, start: number, length: number): JSDoc | undefined {
const saveSkipTransformationFlags = factory.setSkipTransformationFlags(true);
const saveToken = currentToken;
const saveParseDiagnosticsLength = parseDiagnostics.length;
const saveParseErrorBeforeNextFinishedNode = parseErrorBeforeNextFinishedNode;
@@ -6381,7 +6373,6 @@ namespace ts {
currentToken = saveToken;
parseDiagnostics.length = saveParseDiagnosticsLength;
parseErrorBeforeNextFinishedNode = saveParseErrorBeforeNextFinishedNode;
factory.setSkipTransformationFlags(saveSkipTransformationFlags);
return comment;
}
src/compiler/types.ts
-5
View File
@@ -6520,11 +6520,6 @@ namespace ts {
/* @internal */ readonly converters: NodeConverters;
createNodeArray<T extends Node>(elements?: readonly T[], hasTrailingComma?: boolean): NodeArray<T>;
/**
* This is used by the parser to skip transform flag aggregation in Declaration files or other contexts.
* @returns The previous value.
*/
/* @internal */ setSkipTransformationFlags(value: boolean): boolean;
/**
* Tracks setting an extraneous node on a parent. This is primarily used by the parser to add invalid nodes for grammar reporting purposes and is needed to
* correctly update transform flags after a node has been created.