Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed crash when looking for contextual inherited JSDocs for setters and getters (#60027)

Browse Source 
Co-authored-by: Gabriela Araujo Britto <garaujobritto@gmail.com>
This commit is contained in:
Mateusz Burzyński
2024-09-25 20:04:01 +02:00
committed by GitHub
parent e962037df3
commit 413f0fa831
2 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/services.ts
+8
View File
@@ -735,6 +735,8 @@ class SymbolObject implements Symbol {
if (context) {
if (isGetAccessor(context)) {
if (!this.contextualGetAccessorDocumentationComment) {
this.contextualGetAccessorDocumentationComment = emptyArray; // Set temporarily to avoid an infinite loop finding inherited tags
this.contextualGetAccessorDocumentationComment = getDocumentationComment(filter(this.declarations, isGetAccessor), checker);
}
if (length(this.contextualGetAccessorDocumentationComment)) {
@@ -743,6 +745,8 @@ class SymbolObject implements Symbol {
}
if (isSetAccessor(context)) {
if (!this.contextualSetAccessorDocumentationComment) {
this.contextualSetAccessorDocumentationComment = emptyArray; // Set temporarily to avoid an infinite loop finding inherited tags
this.contextualSetAccessorDocumentationComment = getDocumentationComment(filter(this.declarations, isSetAccessor), checker);
}
if (length(this.contextualSetAccessorDocumentationComment)) {
@@ -766,6 +770,8 @@ class SymbolObject implements Symbol {
if (context) {
if (isGetAccessor(context)) {
if (!this.contextualGetAccessorTags) {
this.contextualGetAccessorTags = emptyArray; // Set temporarily to avoid an infinite loop finding inherited tags
this.contextualGetAccessorTags = getJsDocTagsOfDeclarations(filter(this.declarations, isGetAccessor), checker);
}
if (length(this.contextualGetAccessorTags)) {
@@ -774,6 +780,8 @@ class SymbolObject implements Symbol {
}
if (isSetAccessor(context)) {
if (!this.contextualSetAccessorTags) {
this.contextualSetAccessorTags = emptyArray; // Set temporarily to avoid an infinite loop finding inherited tags
this.contextualSetAccessorTags = getJsDocTagsOfDeclarations(filter(this.declarations, isSetAccessor), checker);
}
if (length(this.contextualSetAccessorTags)) {
tests/cases/fourslash/quickInfoJsDocGetterSetterNoCrash1.ts
+18
View File
@@ -0,0 +1,18 @@
/// <reference path="fourslash.ts" />
// https://github.com/microsoft/TypeScript/issues/60024
//// class A implements A {
//// get x(): string { return "" }
//// }
//// const e = new A()
//// e.x/*1*/
////
//// class B implements B {
//// set x(v: string) {}
//// }
//// const f = new B()
//// f.x/*2*/
verify.quickInfoAt("1", "(property) A.x: string");
verify.quickInfoAt("2", "(property) B.x: string");