Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8429 from Microsoft/declaredTypeAsInitialType

Browse Source 
Declared type as initial type in control flow analysis
This commit is contained in:
Anders Hejlsberg
2016-05-02 21:57:56 -07:00
parent 8173ee9ba3 dbfe80b348
commit 2ff9c915a0
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/checker.ts
+1 -1
View File
@@ -7999,7 +7999,7 @@ namespace ts {
const defaultsToDeclaredType = !strictNullChecks || type.flags & TypeFlags.Any || !declaration ||
getRootDeclaration(declaration).kind === SyntaxKind.Parameter || isInAmbientContext(declaration) ||
getContainingFunctionOrModule(declaration) !== getContainingFunctionOrModule(node);
const flowType = getFlowTypeOfReference(node, type, defaultsToDeclaredType ? type : undefinedType);
const flowType = getFlowTypeOfReference(node, type, defaultsToDeclaredType ? type : addNullableKind(type, TypeFlags.Undefined));
if (strictNullChecks && !(type.flags & TypeFlags.Any) && !(getNullableKind(type) & TypeFlags.Undefined) && getNullableKind(flowType) & TypeFlags.Undefined) {
error(node, Diagnostics.Variable_0_is_used_before_being_assigned, symbolToString(symbol));
// Return the declared type to reduce follow-on errors
tests/cases/fourslash/quickInfoOnNarrowedType.ts
+2 -2
View File
@@ -31,8 +31,8 @@ verify.quickInfoIs('(parameter) strOrNum: string');
verify.completionListContains("strOrNum", "(parameter) strOrNum: string");
goTo.marker('4');
verify.quickInfoIs('let s: undefined');
verify.completionListContains("s", "let s: undefined");
verify.quickInfoIs('let s: string | undefined');
verify.completionListContains("s", "let s: string | undefined");
goTo.marker('5');
verify.quickInfoIs('let s: string | undefined');