JetKVM/cloud-api
1
0
Fork 0
mirror of https://github.com/jetkvm/cloud-api.git synced 2026-05-21 05:20:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: skip incompatible defaults and parallelize stable DB lookups

Browse Source 
getDefaultRelease previously picked the newest 100%-rolled-out release
without checking SKU compatibility. If that release lacked a compatible
artifact, the request 404'd downstream even though older 100%-rolled-out
releases had valid binaries for the SKU. It now filters to releases that
actually ship a compatible artifact before selecting the latest, falling
back to a 404 only when no compatible default exists.

The four DB lookups in the stable rollout-aware path are independent; run
them concurrently so background-check latency drops from ~4 round trips
to ~1.
This commit is contained in:
Adam Shiervani
2026-04-27 19:05:39 +02:00
parent 57ec20b041
commit f7775a00a0
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/releases.ts
+20 -8
View File
@@ -499,14 +499,23 @@ async function getDefaultRelease(type: ReleaseType, sku: string): Promise<DbRele
);
}
// Get the latest default version from the rolled out releases
// Only consider releases that ship a binary for this SKU. Without this,
// the newest 100%-rolled-out release wins even if it has no compatible
// artifact, masking older releases that do.
const compatibleReleases = rolledOutReleases.filter(r => r.artifacts.length > 0);
if (compatibleReleases.length === 0) {
throw new NotFoundError(
`No default ${type} release available for SKU "${sku}"`,
);
}
const latestVersion = semver.maxSatisfying(
rolledOutReleases.map(r => r.version),
compatibleReleases.map(r => r.version),
"*",
) as string;
// Get the release with the latest default version
const latestDefaultRelease = rolledOutReleases.find(r => r.version === latestVersion);
const latestDefaultRelease = compatibleReleases.find(r => r.version === latestVersion);
if (!latestDefaultRelease) {
throw new InternalServerError(
@@ -598,10 +607,13 @@ export async function Retrieve(req: Request, res: Response) {
return res.json(responseJson);
}
const latestAppRelease = await getLatestRelease("app", query.sku);
const latestSystemRelease = await getLatestRelease("system", query.sku);
const defaultAppRelease = await getDefaultRelease("app", query.sku);
const defaultSystemRelease = await getDefaultRelease("system", query.sku);
const [latestAppRelease, latestSystemRelease, defaultAppRelease, defaultSystemRelease] =
await Promise.all([
getLatestRelease("app", query.sku),
getLatestRelease("system", query.sku),
getDefaultRelease("app", query.sku),
getDefaultRelease("system", query.sku),
]);
// Background update checks follow rollout percentages so new releases roll
// out gradually. Devices outside the bucket fall back to the default (the