mirror of
https://github.com/zitadel/zitadel.git
synced 2026-07-25 18:28:00 +00:00
11dbb1b277
# Which Problems Are Solved Streams allow differentiating logs produced by different components of Zitadel. # How the Problems Are Solved The `backend/v3/instrumentation/logging` package now exposes convenience function for setting and getting a logger from the context. As well as high-level functions to emit log records at various levels. When constructing a new logger a "stream" needs to be specified: - **runtime**: General runtime logs, such as startup and shutdown messages. Default for logs that do not belong to the other categories. - **request**: Logs for incoming API and HTTP requests. - **event_handler**: Logs for event handling in projections. - **queue**: Logs for the job queue processing. - **event_pusher**: Logs for event pushing to the database. Disabled by default, contains sensitive information. Each line from the returned logger contains a `stream` field as well as a `version` field with the current Zitadel version. ## Runtime config Streams can be enabled by passing an array of stream names in the runtime config. Because some log streams may contain sensitive data (especially events), it is now also possible to mask values by their key. # Additional Changes - Wrap `slogctx` in the `logging` package. (Except API error converter packages, because of import cycle) - Add some docs to `logging` package so other devs understand how to add logging to Zitadel - Add `logging.OnError` and `logging.WithError` helper functions with `Panic()` and `Fatal()` methods, to preserve current calls in the `cmd` packages. - Add instance context extractor. - Only output request details in the request info log. Request ID remains propagated through context. - Moved middleware functionality into protocol specific packages. - Removed setting of URI to context in metric middleware. There were ony setters and no getters. (Unused value) - Reuse a single statusWriter in the middleware package for middlewares that need to know the response status. # Additional Context - Closes #11333 - Closes #11331 - Partly #11330 --------- Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>
107 lines
2.8 KiB
Go
107 lines
2.8 KiB
Go
package queue
|
|
|
|
import (
|
|
"context"
|
|
"encoding/hex"
|
|
"log/slog"
|
|
"time"
|
|
|
|
"github.com/riverqueue/river"
|
|
"github.com/riverqueue/river/rivertype"
|
|
|
|
"github.com/zitadel/zitadel/backend/v3/instrumentation/logging"
|
|
)
|
|
|
|
type logMiddleware struct {
|
|
river.MiddlewareDefaults
|
|
logger *slog.Logger
|
|
}
|
|
|
|
func newLogMiddleware() rivertype.Middleware {
|
|
return &logMiddleware{
|
|
logger: logging.New(logging.StreamQueue),
|
|
}
|
|
}
|
|
|
|
func (m *logMiddleware) InsertMany(
|
|
ctx context.Context,
|
|
manyParams []*rivertype.JobInsertParams,
|
|
doInner func(context.Context) ([]*rivertype.JobInsertResult, error),
|
|
) ([]*rivertype.JobInsertResult, error) {
|
|
start := time.Now()
|
|
ctx = logging.ToCtx(ctx, m.logger)
|
|
results, err := doInner(ctx)
|
|
if err != nil {
|
|
logging.WithError(ctx, err).Error("insert many error")
|
|
return results, err
|
|
}
|
|
logging.Debug(ctx, "jobs inserted",
|
|
slog.Int("count", len(results)),
|
|
slog.Duration("duration", time.Since(start)),
|
|
)
|
|
|
|
// Only do expensive operations if debug is enabled
|
|
if m.logger.Enabled(ctx, slog.LevelDebug) {
|
|
for _, result := range results {
|
|
logging.Debug(ctx, "inserted job details", attributesFromJobInsertResult(result)...)
|
|
}
|
|
}
|
|
return results, err
|
|
}
|
|
|
|
func (m *logMiddleware) Work(
|
|
ctx context.Context,
|
|
job *rivertype.JobRow,
|
|
doInner func(context.Context) error,
|
|
) error {
|
|
start := time.Now()
|
|
ctx = logging.ToCtx(ctx, m.logger)
|
|
ctx = logging.With(ctx, attributesFromJobRow(job)...)
|
|
if err := doInner(ctx); err != nil {
|
|
logging.WithError(ctx, err).Warn("job processing error")
|
|
return err
|
|
}
|
|
logging.Info(ctx, "job processed successfully",
|
|
slog.Duration("duration", time.Since(start)),
|
|
)
|
|
return nil
|
|
}
|
|
|
|
func attributesFromJobRow(j *rivertype.JobRow) []any {
|
|
attributes := make([]any, 0, 14)
|
|
attributes = append(attributes,
|
|
slog.String("queue", j.Queue),
|
|
slog.Int64("job_id", j.ID),
|
|
slog.String("kind", j.Kind),
|
|
slog.Int("priority", j.Priority),
|
|
slog.Int("max_attempts", j.MaxAttempts),
|
|
slog.String("state", string(j.State)),
|
|
slog.String("unique_key", hex.EncodeToString(j.UniqueKey)),
|
|
)
|
|
if j.AttemptedAt != nil {
|
|
attributes = append(attributes,
|
|
slog.Time("created_at", j.CreatedAt),
|
|
slog.Int("attempt", j.Attempt),
|
|
slog.Time("attempted_at", *j.AttemptedAt),
|
|
slog.Any("attempted_by", j.AttemptedBy),
|
|
)
|
|
}
|
|
if j.FinalizedAt != nil {
|
|
attributes = append(attributes, slog.Time("finalized_at", *j.FinalizedAt))
|
|
}
|
|
if !j.ScheduledAt.IsZero() {
|
|
attributes = append(attributes, slog.Time("scheduled_at", j.ScheduledAt))
|
|
}
|
|
if len(j.Tags) > 0 {
|
|
attributes = append(attributes, slog.Any("tags", j.Tags))
|
|
}
|
|
return attributes
|
|
}
|
|
|
|
func attributesFromJobInsertResult(j *rivertype.JobInsertResult) []any {
|
|
attributes := make([]any, 0, 15)
|
|
attributes = append(attributes, attributesFromJobRow(j.Job)...)
|
|
attributes = append(attributes, slog.Bool("unique_skipped_as_duplicate", j.UniqueSkippedAsDuplicate))
|
|
return attributes
|
|
}
|