GitHub/vienna-rss
1
0
Fork 0
mirror of https://github.com/ViennaRSS/vienna-rss.git synced 2026-04-07 19:27:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove __weak qualifiers from variables referenced within dispatch block

Browse Source 
The variables might be nil by the time the blocks are executed. In the
case of -createInitialSmartFolder: this leads to a smart folder with an
invalid search string.
This commit is contained in:
Eitot
2026-03-07 11:58:47 +01:00
parent be40651f2a
commit bda91d1ff8
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Vienna/Sources/Database/Database.m
+2 -3
View File
@@ -474,8 +474,7 @@ NSNotificationName const VNADatabaseDidDeleteFolderNotification = @"Database Did
if ([self createFolderOnDatabase:folderName underParent:VNAFolderTypeRoot withType:VNAFolderTypeSmart] >= 0) {
CriteriaTree * criteriaTree = [[CriteriaTree alloc] init];
criteriaTree.criteriaTree = [criteriaTree.criteriaTree arrayByAddingObject:(id<CriteriaElement>)criteria];
__weak NSString * preparedCriteriaString = criteriaTree.string;
NSString *preparedCriteriaString = criteriaTree.string;
[self.databaseQueue inDatabase:^(FMDatabase *db) {
[db executeUpdate:@"INSERT INTO smart_folders (folder_id, search_string) VALUES (?, ?)", @(db.lastInsertRowId), preparedCriteriaString];
}];
@@ -2255,7 +2254,7 @@ NSNotificationName const VNADatabaseDidDeleteFolderNotification = @"Database Did
{
NSMutableArray * newArray = [NSMutableArray array];
NSString * filterClause = @"";
__weak NSString * queryString;
NSString * queryString;
Folder * folder = nil;
__block NSInteger unread_count = 0;