2.0.3

Check xhr.status is non-zero to avoid running onXHRProgress on error
Previously, onXHRProgress was being run when readyState was being set to DONE on error, which was causing exceptions.
2016-01-08 22:31:45 +01:00 · 2015-10-13 15:46:01 -07:00 · 2015-10-01 23:01:00 -07:00 · 2015-10-01 22:26:59 -07:00
2 changed files with 7 additions and 5 deletions
@@ -120,7 +120,7 @@ ClientRequest.prototype._onFinish = function () {
 		}).then(function (response) {
 			self._fetchResponse = response
 			self._connect()
-		}).then(undefined, function (reason) {
+		}, function (reason) {
 			self.emit('error', reason)
 		})
 	} else {
@@ -183,12 +183,14 @@ ClientRequest.prototype._onFinish = function () {
 }

 /**
- * Checks if xhr.status is readable. Even though the spec says it should
- * be available in readyState 3, accessing it throws an exception in IE8
+ * Checks if xhr.status is readable and non-zero, indicating no error.
+ * Even though the spec says it should be available in readyState 3,
+ * accessing it throws an exception in IE8
 */
 function statusValid (xhr) {
 	try {
-		return (xhr.status !== null)
+		var status = xhr.status
+		return (status !== null && status !== 0)
 	} catch (e) {
 		return false
 	}
@@ -1,6 +1,6 @@
 {
  "name": "stream-http",
-  "version": "2.0.1",
+  "version": "2.0.3",
  "description": "Streaming http in the browser",
  "main": "index.js",
  "repository": {
Author	SHA1	Message	Date
John Hiesey	ae48c2c71c	2.0.3	2016-01-08 22:31:45 +01:00
John Hiesey	570f85ec18	Check xhr.status is non-zero to avoid running onXHRProgress on error Previously, onXHRProgress was being run when readyState was being set to DONE on error, which was causing exceptions.	2015-10-13 15:46:01 -07:00
John Hiesey	85381f0e3d	2.0.2	2015-10-01 23:01:00 -07:00
John Hiesey	3bea2a493f	Don't turn exceptions thrown in the callback into 'error' events When using the fetch api, exceptions thrown inside ClientRequest._onFinish, which also calls the user callback, were being caught and turned into 'error' events. This is not the correct behavior; these exceptions should remain uncaught to let the browser print them to the console.	2015-10-01 22:26:59 -07:00