stream_cdda: deprecate undocumented --cdda-span-{a,b} options

You probably wouldn't guess what this does from the name alone, but it
actually selects a range of tracks to play. It's slightly different than
using --start because it confines the range to just that track and you
cannot seek before it. The functionality is useful, but you can
accomplish exactly the same thing with --start and --end. Also the
implementation of the cdda option is weird because starting from a track
after 1 makes it impossible to seek before it. There's no reason to have
this when using the core option is simply better and works fine.
This commit is contained in:
Dudemanguy
2025-02-17 17:28:11 -06:00
parent dd6e3a0ece
commit bb3265b9d3
2 changed files with 3 additions and 2 deletions
+1
View File
@@ -0,0 +1 @@
deprecate `--cdda-span-a` and `--cdda-span-b`
+2 -2
View File
@@ -76,8 +76,8 @@ const struct m_sub_options stream_cdda_conf = {
{"overlap", OPT_INT(search_overlap), M_RANGE(0, 75)},
{"toc-offset", OPT_INT(toc_offset)},
{"skip", OPT_BOOL(skip)},
{"span-a", OPT_INT(span[0])},
{"span-b", OPT_INT(span[1])},
{"span-a", OPT_INT(span[0]), .deprecation_message = "--start=#N"},
{"span-b", OPT_INT(span[1]), .deprecation_message = "--end=#N"},
{"cdtext", OPT_BOOL(cdtext)},
{0}
},